From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89E16C433EF for ; Tue, 14 Sep 2021 02:03:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 69D5A61130 for ; Tue, 14 Sep 2021 02:03:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232959AbhINCFK (ORCPT ); Mon, 13 Sep 2021 22:05:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231210AbhINCFH (ORCPT ); Mon, 13 Sep 2021 22:05:07 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7AEE9C061760 for ; Mon, 13 Sep 2021 19:03:50 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id i4so8100732lfv.4 for ; Mon, 13 Sep 2021 19:03:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tobHcPJqhSNN4ZgtQaxMXpHgpTB6zZsMk6e9QdMIJao=; b=COw8J9SZUs4LkLiixQE+bnMy4NhxzCRXjrXYewVuOym1vN7v5KNNtqhQIlVcrbvboC UjjjEk1x1NdooPYMhBvKaSWvMvmm+9qbRiHG23qPOwLueInAFV1LTxwOeLxyCpMeQrus dKVrFrAyLVCKJ4IB9zqk3uoXaWuxBLuq4iGm4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tobHcPJqhSNN4ZgtQaxMXpHgpTB6zZsMk6e9QdMIJao=; b=iwWVfmM5MOBYwXGGwtmW5vaqluxA3jRnEVxFSG7V5bomH4P8oo07gSyBBw2kE0/uua Nf96BZJ49o7foXBiP/MAZmTL+cR9/g7FAFVyApEZCA75TAsSbouND/a+XeApzxG276YO VFbXKTBAQ4DidAhqzkeO7RAMgRrrc/zHb2GI6IaF5/J9wNWomvHuZBSuUQEFSV+ZUYGY tVd/kLEUTqlqbaOzW3cv/QVsuYWiDzHxBnqqCs6N2OgckJltOKV33SucwlLjf8NDxz6v bR7f1b4pmJscb+wSWPvixQ8jdmqDL4UFLRnvId5uCENO3qRH8RCgn51Z0fUG+VCQaZcb 3c7w== X-Gm-Message-State: AOAM533W7R2sR6lyaFCV2ogAjl9J4ME2mfR1mOWSCa2hppW8sL7decD5 LpNKy83P2/Vgl99Iq0ojf6mMF0NtSKLQ6urNjk4= X-Google-Smtp-Source: ABdhPJwx0djGAH1hUiVz6m98K5fkkJNFFFguPT/BWjHMDJ7EhRWzHB/TLKyvd9fZBnfbxcoWcRM3Iw== X-Received: by 2002:a05:6512:31cd:: with SMTP id j13mr11409935lfe.69.1631585028656; Mon, 13 Sep 2021 19:03:48 -0700 (PDT) Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com. [209.85.208.181]) by smtp.gmail.com with ESMTPSA id a16sm1153011ljq.22.2021.09.13.19.03.47 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Sep 2021 19:03:47 -0700 (PDT) Received: by mail-lj1-f181.google.com with SMTP id f2so20775037ljn.1 for ; Mon, 13 Sep 2021 19:03:47 -0700 (PDT) X-Received: by 2002:a2e:1542:: with SMTP id 2mr13338597ljv.249.1631585027415; Mon, 13 Sep 2021 19:03:47 -0700 (PDT) MIME-Version: 1.0 References: <20210914100853.3f502bc9@canb.auug.org.au> <20210914105359.5c651d55@canb.auug.org.au> In-Reply-To: From: Linus Torvalds Date: Mon, 13 Sep 2021 19:03:31 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: linux-next: build failure after merge of the origin tree To: Stephen Rothwell Cc: Linux Kernel Mailing List , Linux Next Mailing List , Michael Ellerman , PowerPC Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 13, 2021 at 6:37 PM Linus Torvalds wrote: > > Anyway, that just makes me think that something like that patch in my > previous email is the way to go, but I would like to stress (again) > how little testing it had: exactly none. > > So please consider that nothing more than a hand-wavy "something like this". The alternative would be to just add a #ifndef __ASSEMBLY__ ... #endif around the whole thing. I could do that without asking for help from the powerpc people. But it really does seem kind of wrong to include a "compiler attributes" header file to compile a *.S file. It's not like any of those attributes are valid in asm anyway. I did just verify that the patch I sent out seems to cross-compile ok. At least for the power64 defconfig. So that's _some_ testing, and implies that the patch isn't complete garbage. Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CD32C433F5 for ; Tue, 14 Sep 2021 02:04:38 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6BD2E60F51 for ; Tue, 14 Sep 2021 02:04:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6BD2E60F51 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4H7mr36Qctz2yxj for ; Tue, 14 Sep 2021 12:04:35 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linux-foundation.org header.i=@linux-foundation.org header.a=rsa-sha256 header.s=google header.b=COw8J9SZ; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linuxfoundation.org (client-ip=2a00:1450:4864:20::236; helo=mail-lj1-x236.google.com; envelope-from=torvalds@linuxfoundation.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linux-foundation.org header.i=@linux-foundation.org header.a=rsa-sha256 header.s=google header.b=COw8J9SZ; dkim-atps=neutral Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4H7mqG067Yz2yHN for ; Tue, 14 Sep 2021 12:03:53 +1000 (AEST) Received: by mail-lj1-x236.google.com with SMTP id r3so20788169ljc.4 for ; Mon, 13 Sep 2021 19:03:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tobHcPJqhSNN4ZgtQaxMXpHgpTB6zZsMk6e9QdMIJao=; b=COw8J9SZUs4LkLiixQE+bnMy4NhxzCRXjrXYewVuOym1vN7v5KNNtqhQIlVcrbvboC UjjjEk1x1NdooPYMhBvKaSWvMvmm+9qbRiHG23qPOwLueInAFV1LTxwOeLxyCpMeQrus dKVrFrAyLVCKJ4IB9zqk3uoXaWuxBLuq4iGm4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tobHcPJqhSNN4ZgtQaxMXpHgpTB6zZsMk6e9QdMIJao=; b=AK9Mq9BpEyTmi6ARc4F+MwXpy3Mo+O8gRewAm+oYyC4dFjxSE+XzB9ROW+iQF1pJDa De0ZowNgCAj7ZHLSdO6AXYxaMw1h1hUCmcG+CHRPnEAz+pY7PNIQ5eV2XSkJDofVKy90 Kwn5MipcRsNGRliiMtinpsTtkGWBR0+mpVX3WRIJsqegULsNhMfepFSa2HYgsnoyEnOt BgWxvnzZ4o8dfoQ4n6cchTtMqxIQbWzvFZ1URyNdSAWSb1BtLkx7DYzI1okfZ7VS+/mn 699rHDa0qn2evhIpGxUbbW2G5VuXeLM7ES/KAWhXA/SMCyO7Es+BU6WnY09JAdEbF0VG 5pHQ== X-Gm-Message-State: AOAM533Hf3Ip6JKKg+RkB+7pYbQAZllQjyzbYmJYQ9zaCb2dnjQ3H7pN /Kiiydrf3W/pZLPuTGaIWyN2POqJMvpDDXWyVgE= X-Google-Smtp-Source: ABdhPJy+PHpVIqXrh0ZURQ870WAAR/jeN74bby83P6DVmfFpxerKrQwNWhsS36PB3q4wElM/TRgB/A== X-Received: by 2002:a2e:6c05:: with SMTP id h5mr13501072ljc.42.1631585028507; Mon, 13 Sep 2021 19:03:48 -0700 (PDT) Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com. [209.85.208.179]) by smtp.gmail.com with ESMTPSA id g14sm32285lfe.46.2021.09.13.19.03.47 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Sep 2021 19:03:47 -0700 (PDT) Received: by mail-lj1-f179.google.com with SMTP id o11so13255467ljp.8 for ; Mon, 13 Sep 2021 19:03:47 -0700 (PDT) X-Received: by 2002:a2e:1542:: with SMTP id 2mr13338597ljv.249.1631585027415; Mon, 13 Sep 2021 19:03:47 -0700 (PDT) MIME-Version: 1.0 References: <20210914100853.3f502bc9@canb.auug.org.au> <20210914105359.5c651d55@canb.auug.org.au> In-Reply-To: From: Linus Torvalds Date: Mon, 13 Sep 2021 19:03:31 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: linux-next: build failure after merge of the origin tree To: Stephen Rothwell Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux Next Mailing List , PowerPC , Linux Kernel Mailing List Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Sep 13, 2021 at 6:37 PM Linus Torvalds wrote: > > Anyway, that just makes me think that something like that patch in my > previous email is the way to go, but I would like to stress (again) > how little testing it had: exactly none. > > So please consider that nothing more than a hand-wavy "something like this". The alternative would be to just add a #ifndef __ASSEMBLY__ ... #endif around the whole thing. I could do that without asking for help from the powerpc people. But it really does seem kind of wrong to include a "compiler attributes" header file to compile a *.S file. It's not like any of those attributes are valid in asm anyway. I did just verify that the patch I sent out seems to cross-compile ok. At least for the power64 defconfig. So that's _some_ testing, and implies that the patch isn't complete garbage. Linus