From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17ECDC433E7 for ; Mon, 12 Oct 2020 21:46:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C161D20878 for ; Mon, 12 Oct 2020 21:46:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602539191; bh=OhvSKP97jCVgcsAB9zbb4FeX++0Rx1iQyfeMZA4YINQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=zL6+UmcbzhTUTUxVwbQEQWjCq4OhtdViBoJJLvuchd26ksswfnrY8PB3L8j2ljZvQ hlV1zu9UDPkzK/2p15qlp1icR7f4V/8/RwU+m36SOpNUBsfj/lLli/Rc2ExpeQxfZv zizHIZdu90WZGQsTFrkef3CP11qrgPOpk1hwm35s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730668AbgJLVqa (ORCPT ); Mon, 12 Oct 2020 17:46:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727167AbgJLVqa (ORCPT ); Mon, 12 Oct 2020 17:46:30 -0400 Received: from mail-lf1-x143.google.com (mail-lf1-x143.google.com [IPv6:2a00:1450:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9DD4C0613D0 for ; Mon, 12 Oct 2020 14:46:29 -0700 (PDT) Received: by mail-lf1-x143.google.com with SMTP id h6so19853573lfj.3 for ; Mon, 12 Oct 2020 14:46:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jcj0FDQEdTyI9jLGbrsM++CDc4aPSACJ/ntrnYfOykU=; b=E8beS6Vul0tNp9f6I3CYvbBngOfB/LbOo0hsQystbwHbkaK7vAg5a6ntf8euvt1GhG xqLG1Qp8S+i29TM98JEsWajE6jpS751UC7jzJ5lVCuo+T+JFNChpcqQCLyEqxFwF/q+i 1RDd0k8PwgncGNOalDPmrDaVryOuwESOnHG1U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jcj0FDQEdTyI9jLGbrsM++CDc4aPSACJ/ntrnYfOykU=; b=TGonG+hb+clWGySjvoDGjajq2GYjLxmGztBaoA1eqDyDovXiPIl9gLkYYUZH7gTx1l usR7N3hAvZZWnW5xk7/E8Wk5XDUx4o6KxarNy8BJFYxAJMpfGbwSBwJ2c3J44Gin/Jwu Rr+qOOJPLIj9tjBH6Ty04nLeaNlRGmQ5nJTJCK+C3lLWBmnePo3X+B/3OJqTzzdnEC9s JehpKo3+H58xkgZStZDN8LKgJcDWjZKjbtH2MYtIunzCq/LscyiLkbjJ5CL7ZXlDda0M h+Ijm8TahURgWgK2qyQ2JjD4hV9l4tn0K4CYuvXP+aiUGSfWeJdZk5hMh0ADfScQM8pG fZNg== X-Gm-Message-State: AOAM53207ZNC60AUhcPsPk6OXXbE+w00Bapk9NPaVFCoAHnGejcmCOYa uNBkVu8AStlnVMTEAU7OKi2AptKXUDH0+w== X-Google-Smtp-Source: ABdhPJzD0ZF43GdsvlbRTkqbBxzMoGsf602FOygXbGKH29ENlegs5oWOAI1RuFUDTVzm4NO2vsg8cQ== X-Received: by 2002:ac2:446b:: with SMTP id y11mr5713864lfl.403.1602539187717; Mon, 12 Oct 2020 14:46:27 -0700 (PDT) Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com. [209.85.208.176]) by smtp.gmail.com with ESMTPSA id b14sm1472352lfo.39.2020.10.12.14.46.26 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Oct 2020 14:46:27 -0700 (PDT) Received: by mail-lj1-f176.google.com with SMTP id a4so18261135lji.12 for ; Mon, 12 Oct 2020 14:46:26 -0700 (PDT) X-Received: by 2002:a2e:8092:: with SMTP id i18mr10484981ljg.314.1602539186509; Mon, 12 Oct 2020 14:46:26 -0700 (PDT) MIME-Version: 1.0 References: <20201012101012.GD25311@zn.tnic> <20201012212709.GM25311@zn.tnic> In-Reply-To: From: Linus Torvalds Date: Mon, 12 Oct 2020 14:46:10 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] x86/platform updates for v5.10 To: Mike Travis Cc: Borislav Petkov , x86-ml , lkml Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 12, 2020 at 2:42 PM Mike Travis wrote: > > It should have been an unsigned long instead of an int as Linus > suggested. I'm not sure it's a write only variable as I think the mask > is used to check if the interrupt occurred (I'll have to look closer). At least "git grep" only shows two assignments to it. Of course, that would miss any cases that play games with preprocessor token pasting etc, so it's not entirely meaningful, but it's certainly a hint.. And yes, I expect that the fix is to just make it "unsigned long", but if it truly isn't actually used, maybe removal is better. Linus