From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24A73C433E2 for ; Sat, 11 Jul 2020 18:22:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 00B8320786 for ; Sat, 11 Jul 2020 18:22:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594491727; bh=AUBBbysgdMeR71Y6xbwcXY/YIVqMzNZkIcPQpyj09H4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=P+WVZxFA/uj0am6vokqNqtRtL9XNEr4hLvn/AhYIYAcxw+Ej0jVaG//CJ8Dlm9cdD zYubHr1AT60dzurBWHHARxHfwBD32vyfMXOjRGc4ElhODTXOJQDZNN+XSKSRIjAfFX 5PQUYb/S8nx3i+RUg2zYbno6KSFMfj+Lqs0SLjdQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728777AbgGKSWF (ORCPT ); Sat, 11 Jul 2020 14:22:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728510AbgGKSWF (ORCPT ); Sat, 11 Jul 2020 14:22:05 -0400 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40169C08C5DD for ; Sat, 11 Jul 2020 11:22:04 -0700 (PDT) Received: by mail-lj1-x243.google.com with SMTP id e8so10175740ljb.0 for ; Sat, 11 Jul 2020 11:22:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qptBZzYQmGUSrB1gYaro4KC86w7xRACt4nGpxA934Lg=; b=MS0M6Jpdfk5BRX9IT/yz435ln8+5sFvRJ5xcVUEVxD5BVgZX9q3pL4EfWbDc3q4Jkr e50VjG3ye4PDFlZy8RDkfbelBtcZP6hNhsexP/JMdK3XJmaM7/ypSusjb8G6D9Qy6xRk mWs+G1YR76GNa9sv/YeWuA+fcLo5auw5Y4kPs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qptBZzYQmGUSrB1gYaro4KC86w7xRACt4nGpxA934Lg=; b=p5nRdnIzuuk8m6biT7cgacrTjmBquH1C8cO+0nkVlWf0AUSRJGdA4dUp9L81IB1M1T eOsvFVbPuhqa0C7nbgzF5E3Dwz6uHN6l5AGATDX1qLPE0ljUbAyCeYMBT8zo9JxV57C0 bpQ75d96yBzcGF704rHymNnCVfdlh7z0fpPq8da+waBro09PhKUpBPC+aycJ9RsubVMN eyFegqPAjNmAsahwDgkx4ot/iX5PIkX3NenNMCU1FAsUkcWBx+/reO1c0HvD90LI6Ner nwXXxs0JFPyEiYrWzzb+JXPvlh/ENtgN7FSaCvZFxBkvX9kQc2oazPZaBueOjFLyhgVC d4uw== X-Gm-Message-State: AOAM533NPLhvSqLa3d1lhtLCayUG970tFW6UpLqYGdmNV3raq9jp1zTW 4GSf+uXMbc0EiLcBoyuW0LJ3ZYJo/5s= X-Google-Smtp-Source: ABdhPJxHIQK4z3jC0csP+SyHazF+FgTjkiR41/ytzpWAiWJglEPlHF5st3UhDfweXAOq7ivdLHZpbQ== X-Received: by 2002:a2e:5746:: with SMTP id r6mr45780400ljd.205.1594491722340; Sat, 11 Jul 2020 11:22:02 -0700 (PDT) Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com. [209.85.208.177]) by smtp.gmail.com with ESMTPSA id s4sm3304312lfc.71.2020.07.11.11.22.00 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Jul 2020 11:22:00 -0700 (PDT) Received: by mail-lj1-f177.google.com with SMTP id f5so10123131ljj.10 for ; Sat, 11 Jul 2020 11:22:00 -0700 (PDT) X-Received: by 2002:a05:651c:1b6:: with SMTP id c22mr38521209ljn.421.1594491719786; Sat, 11 Jul 2020 11:21:59 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Linus Torvalds Date: Sat, 11 Jul 2020 11:21:43 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: WARNING: at mm/mremap.c:211 move_page_tables in i386 To: Naresh Kamboju Cc: Joel Fernandes , "Kirill A. Shutemov" , William Kucharski , linux- stable , open list , linux-mm , Arnd Bergmann , Andrew Morton , Roman Gushchin , Michal Hocko , lkft-triage@lists.linaro.org, Chris Down , Michel Lespinasse , Fan Yang , Brian Geffon , Anshuman Khandual , Will Deacon , Catalin Marinas , pugaowei@gmail.com, Jerome Glisse , Greg Kroah-Hartman , Mel Gorman , Hugh Dickins , Al Viro , Tejun Heo , Sasha Levin , Oleg Nesterov Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 11, 2020 at 11:12 AM Linus Torvalds wrote: > > The fact that it seems to happen with > > https://github.com/linux-test-project/ltp/blob/master/testcases/kernel/mem/thp/thp01.c > > makes me think it's somehow related to THP mappings, but I don't see > why those would matter. All the same pmd freeing should still have > happened, afaik. No, I think the only reason it happens with that test-case is simply because that test-case tests many different argument sizes, and as part of that it ends up then hitting the "stack is exactly one pmd in size" case when the stack alignment is right too. So the THP part is almost certainly a red herring. Maybe. Considering that I don't see what's wrong, anything is possible. Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91C86C433DF for ; Sat, 11 Jul 2020 18:27:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4E9D820725 for ; Sat, 11 Jul 2020 18:27:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="MS0M6Jpd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E9D820725 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C90296B0002; Sat, 11 Jul 2020 14:27:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C40A06B0005; Sat, 11 Jul 2020 14:27:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B30026B0006; Sat, 11 Jul 2020 14:27:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0153.hostedemail.com [216.40.44.153]) by kanga.kvack.org (Postfix) with ESMTP id 9DB0A6B0002 for ; Sat, 11 Jul 2020 14:27:25 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 1D434180AD81A for ; Sat, 11 Jul 2020 18:27:25 +0000 (UTC) X-FDA: 77026627650.19.rule06_56003a726ed9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id EA1AA1ACC27 for ; Sat, 11 Jul 2020 18:27:24 +0000 (UTC) X-HE-Tag: rule06_56003a726ed9 X-Filterd-Recvd-Size: 5398 Received: from mail-ed1-f65.google.com (mail-ed1-f65.google.com [209.85.208.65]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Sat, 11 Jul 2020 18:27:24 +0000 (UTC) Received: by mail-ed1-f65.google.com with SMTP id a8so7303853edy.1 for ; Sat, 11 Jul 2020 11:27:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qptBZzYQmGUSrB1gYaro4KC86w7xRACt4nGpxA934Lg=; b=MS0M6Jpdfk5BRX9IT/yz435ln8+5sFvRJ5xcVUEVxD5BVgZX9q3pL4EfWbDc3q4Jkr e50VjG3ye4PDFlZy8RDkfbelBtcZP6hNhsexP/JMdK3XJmaM7/ypSusjb8G6D9Qy6xRk mWs+G1YR76GNa9sv/YeWuA+fcLo5auw5Y4kPs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qptBZzYQmGUSrB1gYaro4KC86w7xRACt4nGpxA934Lg=; b=bTtWRKoz0XQ+1srJIIgWAhCuY5M4B9jmu6DsXL+R6pjMJysECd8Yn+eHkIaz9kik8p hotIHNCvU3uzVT9Oip3Mv5l+qiN7jFwZPAWfaLjc/JoGxnFRcvyovxyW9iiL3VWyJ2SU Kk6L+/ln1uErpBsYz7yrkdFUdoKpWvKQxAW7bsepv4sa19RjX7kxlFYbIvnaoH2hljsE qj2Oe1Pyo+y0q8LyAUycXnE2/9lXctRVuifEeHvwxZrc+YUTwHGyL5ZUZ/6xbpTX0QAJ prq4iRlmfPJY0LyILPb8nVBNImgdeaQOlJoZQI97PdBs3B3ikbse8PZTyGln637iixZ3 xQeg== X-Gm-Message-State: AOAM532duZm3iMjlhM9wl1Jitf3H4enexyddpXag0OlCmV3Kst4+bywD QyGXEEyxCPpQS92H5wM0qiW+MmIATEI= X-Google-Smtp-Source: ABdhPJzZf7xLWqpNfR4Eq3ZOYEh51O73jrJ80BViGIhcUdlDKC2oy+ChIxfnkNZjUhOb+MTKiYSjww== X-Received: by 2002:aa7:c2cf:: with SMTP id m15mr57297290edp.27.1594492043053; Sat, 11 Jul 2020 11:27:23 -0700 (PDT) Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com. [209.85.208.45]) by smtp.gmail.com with ESMTPSA id o17sm6092079ejb.105.2020.07.11.11.27.22 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Jul 2020 11:27:22 -0700 (PDT) Received: by mail-ed1-f45.google.com with SMTP id d18so7282472edv.6 for ; Sat, 11 Jul 2020 11:27:22 -0700 (PDT) X-Received: by 2002:a05:651c:1b6:: with SMTP id c22mr38521209ljn.421.1594491719786; Sat, 11 Jul 2020 11:21:59 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Linus Torvalds Date: Sat, 11 Jul 2020 11:21:43 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: WARNING: at mm/mremap.c:211 move_page_tables in i386 To: Naresh Kamboju Cc: Joel Fernandes , "Kirill A. Shutemov" , William Kucharski , linux- stable , open list , linux-mm , Arnd Bergmann , Andrew Morton , Roman Gushchin , Michal Hocko , lkft-triage@lists.linaro.org, Chris Down , Michel Lespinasse , Fan Yang , Brian Geffon , Anshuman Khandual , Will Deacon , Catalin Marinas , pugaowei@gmail.com, Jerome Glisse , Greg Kroah-Hartman , Mel Gorman , Hugh Dickins , Al Viro , Tejun Heo , Sasha Levin , Oleg Nesterov Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: EA1AA1ACC27 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jul 11, 2020 at 11:12 AM Linus Torvalds wrote: > > The fact that it seems to happen with > > https://github.com/linux-test-project/ltp/blob/master/testcases/kernel/mem/thp/thp01.c > > makes me think it's somehow related to THP mappings, but I don't see > why those would matter. All the same pmd freeing should still have > happened, afaik. No, I think the only reason it happens with that test-case is simply because that test-case tests many different argument sizes, and as part of that it ends up then hitting the "stack is exactly one pmd in size" case when the stack alignment is right too. So the THP part is almost certainly a red herring. Maybe. Considering that I don't see what's wrong, anything is possible. Linus