From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 289BCC49EA5 for ; Sat, 26 Jun 2021 17:02:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E4ED261C33 for ; Sat, 26 Jun 2021 17:02:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229952AbhFZREp (ORCPT ); Sat, 26 Jun 2021 13:04:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229916AbhFZREo (ORCPT ); Sat, 26 Jun 2021 13:04:44 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0E2BC061574 for ; Sat, 26 Jun 2021 10:02:20 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id i13so22237825lfc.7 for ; Sat, 26 Jun 2021 10:02:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ctIXdUKpJejkVwrHGwaovBS1OaqH6yohK5/qSMXJwIM=; b=bbCgi7VG5oVF2e5aiEuOc+fpffvOAvOaKnjYr/Dn+R0NuFDbpZTBQyopLUkaVkvO/o vUiPEv0+luwtBDUQ6VcHTrH7AmllBMvlf2yTIVgKRSHnnVd7henLah2eXyF/eKO9Eg8z j63JuUbhdqI6bMlcL/BxcH3ShOQ/QtCFGIkj4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ctIXdUKpJejkVwrHGwaovBS1OaqH6yohK5/qSMXJwIM=; b=TjC8rv9SFhm91Ub9M20yhA4NavQGoA5CLOTC2yG7fj6/5udImizlAaG6P3mqf0XWYX j8IbYWqjXEQSEnH8BoQy46iTYncZGmJiVe5jWxjxTnHDA3mQbeLzpjZoRTJDwzV5O763 7iqk/Bq2LrMGhq8ZwEKHZFNJmyHCr1eezQuoZotb4dYfAf+Lp1KJ00KC7hp18Rx07WBk YrVZB3/ALh9Up4P4bKEhaOhhuo5X23qxLHvNHW5xPhxOJnr7HObKxlfcXjaAGapCpxSI zRY4J9mj8cP+OAqG65UboO1RXniDxFjqZfBbCxXX1lpZc6FlYO8TvhK4rnYBNoubtpjj FeWw== X-Gm-Message-State: AOAM533klNCYPvQb8ULYlywMAWzpiaXdahQzz7Q/3phjeW8iPcPQ1Dqk wEKHcOt21m2P/cDuga5x5nC3IfZMVOYEPEOW X-Google-Smtp-Source: ABdhPJw9qBweKRhpmAy3aX3GYzHsDNPizt+tnqwywpyqOuP1wQcvtsjK7RMqy+QEKfRJDYVl7HjPkw== X-Received: by 2002:a05:6512:3f92:: with SMTP id x18mr12347771lfa.369.1624726939014; Sat, 26 Jun 2021 10:02:19 -0700 (PDT) Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com. [209.85.208.174]) by smtp.gmail.com with ESMTPSA id t24sm941189ljj.97.2021.06.26.10.02.18 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 26 Jun 2021 10:02:18 -0700 (PDT) Received: by mail-lj1-f174.google.com with SMTP id f13so17263073ljp.10 for ; Sat, 26 Jun 2021 10:02:18 -0700 (PDT) X-Received: by 2002:a2e:2201:: with SMTP id i1mr5233250lji.61.1624726938027; Sat, 26 Jun 2021 10:02:18 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Linus Torvalds Date: Sat, 26 Jun 2021 10:02:02 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] orangefs: an adjustment and a fix... To: Mike Marshall Cc: linux-fsdevel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Sat, Jun 26, 2021 at 7:14 AM Mike Marshall wrote: > > If it is not too late for these... the readahead adjustment > was suggested by Matthew Wilcox and looks like how I should > have written it in the first place... It wasn't too late - I pulled these. And then I un-pulled them. You removed all the uses of "file", but left the variable, so it all warns about fs/orangefs/inode.c: In function =E2=80=98orangefs_readahead=E2=80=99: fs/orangefs/inode.c:252:22: warning: unused variable =E2=80=98file=E2=80= =99 [-Wunused-variable] 252 | struct file *file =3D rac->file; | ^~~~ so clearly this has gotten absolutely zero testing. Linus