From: Linus Torvalds <torvalds@linux-foundation.org>
To: Frederic Weisbecker <frederic@kernel.org>
Cc: "Alan J. Wylie" <alan@wylie.me.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
stable <stable@vger.kernel.org>
Subject: Re: Regression in posix-cpu-timers.c (was Re: Linux 5.14.4)
Date: Wed, 15 Sep 2021 11:41:42 -0700 [thread overview]
Message-ID: <CAHk-=wgiiqmy1jE0i9EYkCiE+KNHDTJQVktczZgyJwqL-okRgA@mail.gmail.com> (raw)
In-Reply-To: <20210915183152.GA22415@lothringen>
On Wed, Sep 15, 2021 at 11:31 AM Frederic Weisbecker
<frederic@kernel.org> wrote:
>
> Right, this should fix the issue: https://lore.kernel.org/lkml/20210913145332.232023-1-frederic@kernel.org/
Hmm.
Can you explain why the fix isn't just to revert that original commit?
It looks like the only real difference is that now it does *extra
work* with all that tick_nohz_dep_set_signal().
Isn't it easier to just leave any old timer ticking, and not do the
extra work until it expires and you notice "ok, it's not important"?
IOW, that original commit explicitly broke the only case it changed -
the timer being disabled. So why isn't it just reverted? What is it
that kleeps us wanting to do the extra work for the disabled timer
case?
As long as it's fixed, I'm all ok with this, but I'm looking at the
commit message for that broken commit, and I'm looking at the commit
message for the fix, and I'm not seeing an actual _explanation_ for
this churn.
Linus
next prev parent reply other threads:[~2021-09-15 18:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 8:09 Linux 5.14.4 Greg Kroah-Hartman
2021-09-15 8:09 ` Greg Kroah-Hartman
2021-09-15 17:45 ` Regression in posix-cpu-timers.c (was Re: Linux 5.14.4) Alan J. Wylie
2021-09-15 18:09 ` Greg Kroah-Hartman
2021-09-15 18:53 ` Alan J. Wylie
2021-09-16 8:51 ` Greg Kroah-Hartman
2021-09-15 18:31 ` Frederic Weisbecker
2021-09-15 18:41 ` Linus Torvalds [this message]
2021-09-15 21:15 ` Frederic Weisbecker
2021-09-15 19:20 ` Alan J. Wylie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wgiiqmy1jE0i9EYkCiE+KNHDTJQVktczZgyJwqL-okRgA@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=alan@wylie.me.uk \
--cc=frederic@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.