From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E60B1C6FD1C for ; Fri, 24 Mar 2023 16:40:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231626AbjCXQkT (ORCPT ); Fri, 24 Mar 2023 12:40:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231623AbjCXQkQ (ORCPT ); Fri, 24 Mar 2023 12:40:16 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22D1F1A669 for ; Fri, 24 Mar 2023 09:40:15 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id ek18so10259748edb.6 for ; Fri, 24 Mar 2023 09:40:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1679676013; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NkqrrrBli7iwioLLpZaqx7X4Cp1aCl3V92ectHxHlRw=; b=P8fF38dqC7mw9gR50t3xfU0Ct4Nh3npY6bKtO0d0nGq8Nl8Rv6ETrQVG9oxcsQiDCP CHDU/FOdQ20gQdHBZQNU62irjEaj0204Jf2AYW5kuTzmAVqDaXXNkR0/h9D8HhgrPbrL yfrespfSxEuMuSQRx27xgZNMt1QigBMmFwVF8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679676013; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NkqrrrBli7iwioLLpZaqx7X4Cp1aCl3V92ectHxHlRw=; b=qygYcNm9sbHimsv6qxnF1lHVE8UmFpdfEXlXys/i9bSQziGrLrIWYZQWUrVRMpJ2pq RfH0oo7Qg+OU219BzIaE+96wp416N8zxFxZJcFbqUdKfz/5Tr9gR2jt4EVL7XYzZiL4N /VEhDV1hdzheMQ2397hFz2WEZhGfTV5psxCyC+Bhvsd4NqCppW/OkTds6t8Lw4yHCPEx AsoaG3+Sclm3cWreuCxWuCbST6ybi3XiuC/yj1yyaMwHXXS1tfi5ntFByJtTNLvqQMVT eeO82OBsiHiOnNFszgXOQqHIuHsT8t0KSlnMIV85Uyb1n9hxq8bMSHqrm8BzHYp1z8+V fYmg== X-Gm-Message-State: AAQBX9eiEK+xbRpQLl3U5vWSE3iPJQ3HK4xBPA57m7y2RzZVsNMgwIBU MmlWqGniYh2Bod+Agp7/zusXYv4cw+yn3UdnxlR1SQ== X-Google-Smtp-Source: AKy350Zs+XeHNLb9ZfqI8Qp/Cu3KhFj46R9LCwE1VS7wCR4wxg8rUde60trrT/3N6r0nxxQo7kNZ1w== X-Received: by 2002:a17:906:ca0c:b0:930:1914:88fe with SMTP id jt12-20020a170906ca0c00b00930191488femr3191734ejb.68.1679676013257; Fri, 24 Mar 2023 09:40:13 -0700 (PDT) Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com. [209.85.208.50]) by smtp.gmail.com with ESMTPSA id n11-20020a17090673cb00b0093dbb008281sm1623442ejl.130.2023.03.24.09.40.12 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Mar 2023 09:40:12 -0700 (PDT) Received: by mail-ed1-f50.google.com with SMTP id w9so10323637edc.3 for ; Fri, 24 Mar 2023 09:40:12 -0700 (PDT) X-Received: by 2002:a17:906:7846:b0:933:1967:a984 with SMTP id p6-20020a170906784600b009331967a984mr1673964ejm.15.1679676012002; Fri, 24 Mar 2023 09:40:12 -0700 (PDT) MIME-Version: 1.0 References: <20230324123626.2177476-1-sashal@kernel.org> In-Reply-To: <20230324123626.2177476-1-sashal@kernel.org> From: Linus Torvalds Date: Fri, 24 Mar 2023 09:39:55 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] capability: test_deny_namespace breakage due to capability conversion to u64 To: Sasha Levin Cc: andrii@kernel.org, mykolal@fb.com, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 24, 2023 at 5:36=E2=80=AFAM Sasha Levin wro= te: > > Commit f122a08b197d ("capability: just use a 'u64' instead of a 'u32[2]' > array") attempts to use BIT_LL() but actually wanted to use BIT_ULL(), > fix it up to make the test compile and run again. This got fixed differently by e8c8361cfdbf ("selftests/bpf: Fix progs/test_deny_namespace.c issues"). I wonder what drugs made me think BIT_LL() was ok. Maybe my wife puts something in the coffee? Linus