From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5015C433EF for ; Thu, 16 Sep 2021 20:17:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 95FED61207 for ; Thu, 16 Sep 2021 20:17:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238378AbhIPUSm (ORCPT ); Thu, 16 Sep 2021 16:18:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229456AbhIPUSk (ORCPT ); Thu, 16 Sep 2021 16:18:40 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D2D0C061574 for ; Thu, 16 Sep 2021 13:17:19 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id b15so4787569lfe.7 for ; Thu, 16 Sep 2021 13:17:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KWrZXTMMEqJtqrGMGepc86HxXmmszewV5GT+dchm6nE=; b=a+yaa6b3Vz/aWhJ6PBuJI4QWj7FqZSfl7CICaqyFPJCb2Fl1X9ECyQTS011hVSPuQY tvEr/Nvpx2uA+FO1SRfqZ51Q5eHmF3E0XVSEImc+B8hRPLEvHvliEoiC3qaDCZyG2spq 0IEoPJI4w0I5e08bXCu0DAGQhQBZLJpHxp+nc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KWrZXTMMEqJtqrGMGepc86HxXmmszewV5GT+dchm6nE=; b=kV/LAenZJqTHcGT6NuvFZKLP/OyY4x4q/0cmBYWU1V0bgicai0HaKUilULfGLW1J5D USA6d9H8v9wXFZ5Q4c3j/gTiZGWF3XU7KF6RJPWNGou9ve/3Xp1esGZoBrJ6j/fjcGoQ tnD/K5sjZmUIf6g3dqAGDumSpAYIhC6oxJfvzwMekRX8xu/CRmeG3/OQHof+SUay9hWv QhjXOUvwFNuUAPxos6WiSqBZ/trqNLjVmG9t/aM3Wuf3rJxfeW3IuJBuHRxmM6stxfQ8 r/rzJNSezKtxuw7dvt11CFgQ8JuTYtFugDiXCbtD7BilZELBSI0ftuGvW1HcjLhv3zoo wIbg== X-Gm-Message-State: AOAM5314U9RgRz6VFOnotERmjQeZE02mYPoEGDQLSeRSJzqhn5Amnwod FBkIZFnudVLnF4oWhl6XY3BvpWTxFw45LW4bIJc= X-Google-Smtp-Source: ABdhPJxpZCSbNtOABf0vssHTVt1OwPWPsbIs7dWM3JEpvQWSg8wYldmBj1YnEkMGBiIcyusto1Inkg== X-Received: by 2002:a05:6512:3405:: with SMTP id i5mr5308512lfr.396.1631823436925; Thu, 16 Sep 2021 13:17:16 -0700 (PDT) Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com. [209.85.167.50]) by smtp.gmail.com with ESMTPSA id a25sm436797ljj.109.2021.09.16.13.17.16 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Sep 2021 13:17:16 -0700 (PDT) Received: by mail-lf1-f50.google.com with SMTP id g1so23356442lfj.12 for ; Thu, 16 Sep 2021 13:17:16 -0700 (PDT) X-Received: by 2002:a2e:8185:: with SMTP id e5mr6219496ljg.31.1631823435793; Thu, 16 Sep 2021 13:17:15 -0700 (PDT) MIME-Version: 1.0 References: <163177338366.682366.5998343833719057348.stgit@devnote2> <163177341667.682366.1520674275752512771.stgit@devnote2> <20210916092630.48e01b5e@gandalf.local.home> In-Reply-To: <20210916092630.48e01b5e@gandalf.local.home> From: Linus Torvalds Date: Thu, 16 Sep 2021 13:16:59 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 4/4] bootconfig: Rename xbc_destroy_all() to xbc_fini() To: Steven Rostedt Cc: Masami Hiramatsu , Mike Rapoport , Andrew Morton , LKML , Ingo Molnar , Linux-MM , Vlastimil Babka Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 16, 2021 at 6:26 AM Steven Rostedt wrote: > > > I didn't know this was a thing. But looking for other use cases with > "*_fini(", there seems to be plenty of precedence in the kernel for this > change. I wouldn't encourage it. It's an odd compiler thing, where initializers and destructors are in 'init' and 'fini' segments respectively. It makes absolutely no sense in any other context, and the fact that it has bled into kernel usage is not a good thing imnsho. Honestly, "exit" is the normal prefix/postfix, and is actually a real word. As is "destroy", used elsewhere. So I'm not going to NAK 'fini', but it's a completely stupid and pointless thing to use and there are better character sequences that aren't any more typing and are real words. Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49250C433EF for ; Thu, 16 Sep 2021 20:17:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C556D6120C for ; Thu, 16 Sep 2021 20:17:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C556D6120C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 57684940007; Thu, 16 Sep 2021 16:17:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 526B16B0072; Thu, 16 Sep 2021 16:17:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3EF3D940007; Thu, 16 Sep 2021 16:17:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0208.hostedemail.com [216.40.44.208]) by kanga.kvack.org (Postfix) with ESMTP id 2FF106B0071 for ; Thu, 16 Sep 2021 16:17:19 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id DCFD42BFCB for ; Thu, 16 Sep 2021 20:17:18 +0000 (UTC) X-FDA: 78594546156.01.84FC8C2 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by imf15.hostedemail.com (Postfix) with ESMTP id 900A8D0000AB for ; Thu, 16 Sep 2021 20:17:18 +0000 (UTC) Received: by mail-lf1-f54.google.com with SMTP id i25so23591090lfg.6 for ; Thu, 16 Sep 2021 13:17:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KWrZXTMMEqJtqrGMGepc86HxXmmszewV5GT+dchm6nE=; b=a+yaa6b3Vz/aWhJ6PBuJI4QWj7FqZSfl7CICaqyFPJCb2Fl1X9ECyQTS011hVSPuQY tvEr/Nvpx2uA+FO1SRfqZ51Q5eHmF3E0XVSEImc+B8hRPLEvHvliEoiC3qaDCZyG2spq 0IEoPJI4w0I5e08bXCu0DAGQhQBZLJpHxp+nc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KWrZXTMMEqJtqrGMGepc86HxXmmszewV5GT+dchm6nE=; b=7IjIUWxVU5ha6NvsPNwSwjqqtAdwlIR0FcVfZ/xzeG3fXjbPizPAB4jFePZ/my3q+o 3PxGXqwLujyH/y+I/bgoVf1dG5HForzIWSsk8tQ65zAoWUb1k4qcq19IrE6PZ1veH0EB zMSxCFjfIKRS6QpBsOZqVSDvtFWFIeCkAtA4jvHq6C62/DgZ4OI2dBoeittD2bJTXj/z 4aZAzRwOPhxbrv8u1c2Jp2SO+d8uEt3sU7l+8wW07kRRQZy6otgOH4v96Gl5QwQkgo8R +UhK7s9IYooCwHuUAPqJi1jGmgE+WUiZIfCsEVtrWT7JbXWKatYWleoepfA23lcGfcZS HatQ== X-Gm-Message-State: AOAM533DSw0XBJDRmIcQqkEtIKhKKP9p7BKUWFSGJvKT6eb6en/RyqR4 0yzm7yJG0gW0RzA97NXil22w4bdMCB9H6tm5r7w= X-Google-Smtp-Source: ABdhPJxDJ4YW7ObbFPBxX+DGCYQTAXvpxeRS68P3ZO/ep8vr5e1AuyZKZKYbJuioE0o+yJgA7y2j5w== X-Received: by 2002:a05:6512:2622:: with SMTP id bt34mr5514588lfb.39.1631823436763; Thu, 16 Sep 2021 13:17:16 -0700 (PDT) Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com. [209.85.167.51]) by smtp.gmail.com with ESMTPSA id b12sm439310ljf.62.2021.09.16.13.17.16 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Sep 2021 13:17:16 -0700 (PDT) Received: by mail-lf1-f51.google.com with SMTP id t10so17589159lfd.8 for ; Thu, 16 Sep 2021 13:17:16 -0700 (PDT) X-Received: by 2002:a2e:8185:: with SMTP id e5mr6219496ljg.31.1631823435793; Thu, 16 Sep 2021 13:17:15 -0700 (PDT) MIME-Version: 1.0 References: <163177338366.682366.5998343833719057348.stgit@devnote2> <163177341667.682366.1520674275752512771.stgit@devnote2> <20210916092630.48e01b5e@gandalf.local.home> In-Reply-To: <20210916092630.48e01b5e@gandalf.local.home> From: Linus Torvalds Date: Thu, 16 Sep 2021 13:16:59 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 4/4] bootconfig: Rename xbc_destroy_all() to xbc_fini() To: Steven Rostedt Cc: Masami Hiramatsu , Mike Rapoport , Andrew Morton , LKML , Ingo Molnar , Linux-MM , Vlastimil Babka Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=a+yaa6b3; spf=pass (imf15.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.167.54 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 900A8D0000AB X-Stat-Signature: cx9oun6f44yt8jnhay7asfdi94ewg9yd X-HE-Tag: 1631823438-715180 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 16, 2021 at 6:26 AM Steven Rostedt wrote: > > > I didn't know this was a thing. But looking for other use cases with > "*_fini(", there seems to be plenty of precedence in the kernel for this > change. I wouldn't encourage it. It's an odd compiler thing, where initializers and destructors are in 'init' and 'fini' segments respectively. It makes absolutely no sense in any other context, and the fact that it has bled into kernel usage is not a good thing imnsho. Honestly, "exit" is the normal prefix/postfix, and is actually a real word. As is "destroy", used elsewhere. So I'm not going to NAK 'fini', but it's a completely stupid and pointless thing to use and there are better character sequences that aren't any more typing and are real words. Linus