From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 906E9C433E0 for ; Thu, 4 Mar 2021 21:16:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 624056500C for ; Thu, 4 Mar 2021 21:16:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239293AbhCDVQP (ORCPT ); Thu, 4 Mar 2021 16:16:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237519AbhCDVPx (ORCPT ); Thu, 4 Mar 2021 16:15:53 -0500 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18CDCC061756 for ; Thu, 4 Mar 2021 13:15:13 -0800 (PST) Received: by mail-lj1-x236.google.com with SMTP id e2so27969169ljo.7 for ; Thu, 04 Mar 2021 13:15:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=C4GiH7OsFqBXNgPH9lEXvnAS/VBedlFXUn708GSVLWs=; b=HNy3dt+f1rBLexxgKM508D0xHwg6OpIpHIGpOed+5RHLqIKoVYGKTjERUIERsyQCur RghFiw+842AbLBDt4WeumgW2bbCFFuIa9qbNGLWZ+j3f6wOegcZa4SwhZWdWbN0gkWuQ Lq5DV+yjKFHmzW8AkALe9YvH9OYxFPaunwJPU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=C4GiH7OsFqBXNgPH9lEXvnAS/VBedlFXUn708GSVLWs=; b=SZhjFNbp7Fo8LTVZWCGZE0K6wRmqqZwviMV5BSkVhdQDzAWbO4WHDmZcu1h46jzF3V SOsbJhq0en8aHmiHSyCAQf2VuuD+551V32FJNSvdi2e4LSZbvlUlBhW2AdztWNNiSjbM HhZ0Hd/lYy6bZHxXKyxhg/ZC5JTh1q25z8O/6kczQa3zuFkoTZM4AaIRV4CJFE95JJBQ 6YjdJ9KUtKmtEyryjRuuwCgaRjLMLyIF+8Q8Z0bMcN/CJu9XdB7rCNyZJ420zXfHQZO1 Z1enjg4Lk4bTpeg/w3XEH5VPbZsBxXq+bm17Run2K7Lq5epkxyslZEEjDWoKPyQnWiGP JCVw== X-Gm-Message-State: AOAM5338aJWIJSr1QmY9CA6reo28cIAVn80Nyew54GGwfSqceqjfJPKQ O63Tbp6ERCyhrSOc+9E1LJJTg4kzmbmHCA== X-Google-Smtp-Source: ABdhPJzinQFoGuH+/mEHlV3ZqYsuSbF3graqEPdUu9T8kR0eFGbI1xq+AFEm2XqFUGX1OUiUszv0Mw== X-Received: by 2002:a05:651c:3c1:: with SMTP id f1mr3318816ljp.507.1614892511084; Thu, 04 Mar 2021 13:15:11 -0800 (PST) Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com. [209.85.208.169]) by smtp.gmail.com with ESMTPSA id y2sm59157lfs.51.2021.03.04.13.15.08 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Mar 2021 13:15:09 -0800 (PST) Received: by mail-lj1-f169.google.com with SMTP id k12so26135423ljg.9 for ; Thu, 04 Mar 2021 13:15:08 -0800 (PST) X-Received: by 2002:a2e:9bd0:: with SMTP id w16mr3223231ljj.465.1614892508416; Thu, 04 Mar 2021 13:15:08 -0800 (PST) MIME-Version: 1.0 References: <20210302192700.399054668@linuxfoundation.org> <175fac9c-ac3f-bd82-9e5d-2c2970cfc519@roeck-us.net> In-Reply-To: From: Linus Torvalds Date: Thu, 4 Mar 2021 13:14:52 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 5.10 000/657] 5.10.20-rc4 review To: Naresh Kamboju Cc: Guenter Roeck , Greg Kroah-Hartman , open list , Shuah Khan , Florian Fainelli , patches@kernelci.org, lkft-triage@lists.linaro.org, Jon Hunter , linux-stable , Pavel Machek , Andrew Morton Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 4, 2021 at 9:56 AM Naresh Kamboju wrote: > > On Thu, 4 Mar 2021 at 01:34, Guenter Roeck wrote: > > > > Upstream has: > > > > e71a8d5cf4b4 tty: fix up iterate_tty_read() EOVERFLOW handling > > ddc5fda74561 tty: fix up hung_up_tty_read() conversion > > I have applied these two patches and the reported problem did not solve. Hmm. Upstream has: * 3342ff2698e9 ("tty: protect tty_write from odd low-level tty disciplines") * a9cbbb80e3e7 ("tty: avoid using vfs_iocb_iter_write() for redirected console writes") * 17749851eb9c ("tty: fix up hung_up_tty_write() conversion") G e71a8d5cf4b4 ("tty: fix up iterate_tty_read() EOVERFLOW handling") G ddc5fda74561 ("tty: fix up hung_up_tty_read() conversion") * c7135bbe5af2 ("tty: fix up hung_up_tty_write() conversion") d7fe75cbc23c ("tty: teach the n_tty ICANON case about the new "cookie continuations" too") 15ea8ae8e03f ("tty: teach n_tty line discipline about the new "cookie continuations"") 64a69892afad ("tty: clean up legacy leftovers from n_tty line discipline") * 9bb48c82aced ("tty: implement write_iter") * dd78b0c483e3 ("tty: implement read_iter") * 3b830a9c34d5 ("tty: convert tty_ldisc_ops 'read()' function to take a kernel pointer") Where those ones marked with '*' seem to be in v5.10.y, and the one prefixed with 'G' are the ones Guenter mentioned. (We seem to have the "tty: fix up hung_up_tty_write() conversion" commit twice. I'm not sure how that happened, but whatever). But that still leaves three commits that don't seem to be in 5.10.y: d7fe75cbc23c ("tty: teach the n_tty ICANON case about the new "cookie continuations" too") 15ea8ae8e03f ("tty: teach n_tty line discipline about the new "cookie continuations"") 64a69892afad ("tty: clean up legacy leftovers from n_tty line discipline") and they might fix what are otherwise short reads. Which is allowed by POSIX, afaik, but .. Do those three commits fix your test-case? (And maybe my filtering and trying to figure out what is upstream and what is in 5.10.y is broken, and there's something else there too). Linus