From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C82B7C433DB for ; Sun, 27 Dec 2020 19:07:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8FD972242A for ; Sun, 27 Dec 2020 19:07:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726227AbgL0TGx (ORCPT ); Sun, 27 Dec 2020 14:06:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726000AbgL0TGx (ORCPT ); Sun, 27 Dec 2020 14:06:53 -0500 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85FBCC061794 for ; Sun, 27 Dec 2020 11:06:12 -0800 (PST) Received: by mail-lf1-x130.google.com with SMTP id o19so19716035lfo.1 for ; Sun, 27 Dec 2020 11:06:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=y8fqVZQrGyzGR3fKvawdKPLLMQ3PRjIKQI/vPT2IhXs=; b=BrCa080DCUCABbSmkb2AHz+tkPAsSZAYYLf/SsKuVNh2efFAPi4uhdM2cJbVlHIwTB dasGzkvNdIeiXkmJMSS9Sw0wGRQtnX4Au/36WOd2zuYKUlXYhEMOcIx97LQhfOkIuLor Rilj++tTrqhrbKcixUhshxcMha96z36F4Y54o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=y8fqVZQrGyzGR3fKvawdKPLLMQ3PRjIKQI/vPT2IhXs=; b=iBR00JKty52xpYHTz7tH3l26+CnpFcagg9QnZqIjHYKqPOBZTCmHXbCQIVyk80yN3V Ls7p0c/o4eE4DET4NXs1CRHmzWCxGz4CDRe04prEsOYwiPrRjhYfH7ELxIq3vgJqiLvr RtSJZNyo7nSP33ybEIuJnonaW5WBVnWjxNG2k+TdNUgWAHTCGzGitAGue4eR/Y1svhFg IeOrwlQlv/0Y5qEPuzWxBqTc6NivDikP1rDozVdRmRluHgwn4I1uQVIgZE+rZ9cXYMYC T1L/P2hSDZtT0JfAyArMY3eQQG76vdPp9wGROTdJRfYUgkbYQtyo7Skzid2v/MjSMLig FJmg== X-Gm-Message-State: AOAM531OEFMa2gjLljNcbTy5l3QdmZ4XGI/Vdz0RoqAPKA7wOKQSlP1j vEjVjaMWfwbDwloo7iZGoGFcVyjBbm5kwA== X-Google-Smtp-Source: ABdhPJzXX7pxnQoVFWMceXSfSTtVBqiFP29vNxFTZiG8T0ydaYxQygFC2b63gXD93cIMfDCkMoSxaQ== X-Received: by 2002:a2e:89ce:: with SMTP id c14mr19472143ljk.483.1609095970294; Sun, 27 Dec 2020 11:06:10 -0800 (PST) Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com. [209.85.167.52]) by smtp.gmail.com with ESMTPSA id 11sm6151685ljw.27.2020.12.27.11.06.08 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Dec 2020 11:06:09 -0800 (PST) Received: by mail-lf1-f52.google.com with SMTP id s26so19627052lfc.8 for ; Sun, 27 Dec 2020 11:06:08 -0800 (PST) X-Received: by 2002:a2e:b4af:: with SMTP id q15mr19576111ljm.507.1609095968615; Sun, 27 Dec 2020 11:06:08 -0800 (PST) MIME-Version: 1.0 References: <16089960203931@kroah.com> <5ab86253-7703-e892-52b7-e6a8af579822@iki.fi> In-Reply-To: From: Linus Torvalds Date: Sun, 27 Dec 2020 11:05:52 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: LXC broken with 5.10-stable?, ok with 5.9-stable (Re: Linux 5.10.3) To: Jussi Kivilinna Cc: Greg Kroah-Hartman , Linux Kernel Mailing List , Andrew Morton , stable , lwn@lwn.net, Jiri Slaby Content-Type: multipart/mixed; boundary="0000000000009e972905b776d991" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --0000000000009e972905b776d991 Content-Type: text/plain; charset="UTF-8" On Sun, Dec 27, 2020 at 10:39 AM Jussi Kivilinna wrote: > > 5.10.3 with patch compiles fine, but does not solve the issue. Duh. adding the read_iter only fixes kernel_read(). For splice, it also needs a .splice_read = generic_file_splice_read, in the file operations, something like this... Does that get things working? Linus --0000000000009e972905b776d991 Content-Type: application/octet-stream; name=patch Content-Disposition: attachment; filename=patch Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kj7i6lyu0 IGZzL3Byb2NfbmFtZXNwYWNlLmMgfCA5ICsrKysrKy0tLQogMSBmaWxlIGNoYW5nZWQsIDYgaW5z ZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9mcy9wcm9jX25hbWVzcGFj ZS5jIGIvZnMvcHJvY19uYW1lc3BhY2UuYwppbmRleCBlNTlkNGJiM2E4OWUuLmVhZmI3NTc1NWZh MyAxMDA2NDQKLS0tIGEvZnMvcHJvY19uYW1lc3BhY2UuYworKysgYi9mcy9wcm9jX25hbWVzcGFj ZS5jCkBAIC0zMjAsNyArMzIwLDggQEAgc3RhdGljIGludCBtb3VudHN0YXRzX29wZW4oc3RydWN0 IGlub2RlICppbm9kZSwgc3RydWN0IGZpbGUgKmZpbGUpCiAKIGNvbnN0IHN0cnVjdCBmaWxlX29w ZXJhdGlvbnMgcHJvY19tb3VudHNfb3BlcmF0aW9ucyA9IHsKIAkub3BlbgkJPSBtb3VudHNfb3Bl biwKLQkucmVhZAkJPSBzZXFfcmVhZCwKKwkucmVhZF9pdGVyCT0gc2VxX3JlYWRfaXRlciwKKwku c3BsaWNlX3JlYWQJPSBnZW5lcmljX2ZpbGVfc3BsaWNlX3JlYWQsCiAJLmxsc2VlawkJPSBzZXFf bHNlZWssCiAJLnJlbGVhc2UJPSBtb3VudHNfcmVsZWFzZSwKIAkucG9sbAkJPSBtb3VudHNfcG9s bCwKQEAgLTMyOCw3ICszMjksOCBAQCBjb25zdCBzdHJ1Y3QgZmlsZV9vcGVyYXRpb25zIHByb2Nf bW91bnRzX29wZXJhdGlvbnMgPSB7CiAKIGNvbnN0IHN0cnVjdCBmaWxlX29wZXJhdGlvbnMgcHJv Y19tb3VudGluZm9fb3BlcmF0aW9ucyA9IHsKIAkub3BlbgkJPSBtb3VudGluZm9fb3BlbiwKLQku cmVhZAkJPSBzZXFfcmVhZCwKKwkucmVhZF9pdGVyCT0gc2VxX3JlYWRfaXRlciwKKwkuc3BsaWNl X3JlYWQJPSBnZW5lcmljX2ZpbGVfc3BsaWNlX3JlYWQsCiAJLmxsc2VlawkJPSBzZXFfbHNlZWss CiAJLnJlbGVhc2UJPSBtb3VudHNfcmVsZWFzZSwKIAkucG9sbAkJPSBtb3VudHNfcG9sbCwKQEAg LTMzNiw3ICszMzgsOCBAQCBjb25zdCBzdHJ1Y3QgZmlsZV9vcGVyYXRpb25zIHByb2NfbW91bnRp bmZvX29wZXJhdGlvbnMgPSB7CiAKIGNvbnN0IHN0cnVjdCBmaWxlX29wZXJhdGlvbnMgcHJvY19t b3VudHN0YXRzX29wZXJhdGlvbnMgPSB7CiAJLm9wZW4JCT0gbW91bnRzdGF0c19vcGVuLAotCS5y ZWFkCQk9IHNlcV9yZWFkLAorCS5yZWFkX2l0ZXIJPSBzZXFfcmVhZF9pdGVyLAorCS5zcGxpY2Vf cmVhZAk9IGdlbmVyaWNfZmlsZV9zcGxpY2VfcmVhZCwKIAkubGxzZWVrCQk9IHNlcV9sc2VlaywK IAkucmVsZWFzZQk9IG1vdW50c19yZWxlYXNlLAogfTsK --0000000000009e972905b776d991--