From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCFFBC6377D for ; Mon, 19 Jul 2021 19:59:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C09E661004 for ; Mon, 19 Jul 2021 19:59:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1385822AbhGSTKq (ORCPT ); Mon, 19 Jul 2021 15:10:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1385193AbhGSSuS (ORCPT ); Mon, 19 Jul 2021 14:50:18 -0400 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33C5FC0613E0 for ; Mon, 19 Jul 2021 12:21:20 -0700 (PDT) Received: by mail-lj1-x235.google.com with SMTP id h9so27913164ljm.5 for ; Mon, 19 Jul 2021 12:29:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cvseTVwISQQYVhM74Otk0kHaj1gV421l1SCA3Nj6+8A=; b=bG065vqODgODNuvvz8mm0qHyJG6bF2CQmrIx298YPsPIfm1XQziVg1hw4cyEeNraRs As5mkoiZv9EFfjI3rygNALG/BoZwX1W+bpEUGC32eW7jeK+OzXHmykLB8a8dTBNQlzHs hWbkQvF2brbeFqyBxVGR9lMGFE15eZqGdyFsw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cvseTVwISQQYVhM74Otk0kHaj1gV421l1SCA3Nj6+8A=; b=bVeEwJFZ2NGgBtmnt07dc/d9g4R8/30/73letp30wuBv7R9JAbdkWpz4WZp907IdSa 1ceInJUczZNOvsYs/yvm+zri/Yg0XkjCIgQpINn8e/PJRSOUv7pZHj6VyQbBQvlNM88v 6W2Ljv+O75j/R+FkhRjDZeiqx9TPGImiMPZBcymXAF57TXUHFEMVjc7CeEmRfrRiSXRh L2nTsaG5h4EgLFpxRvn+oYNa/QkFbrrl37YHGQwmBnaCwZN/TWYheWesuPdl7YZKnuwu 54wfzY/2e0RxaBfPYDvL7X0/PESf6/0D3OhffU4XAeVclGm6DYoJCdU2iyjV+d1GMijr 9gkg== X-Gm-Message-State: AOAM532sKWWMpWx8RfE9KjFPA0qGSUmTqqjRHHHysesYQds27I6B3ED/ kYbmcDOYMXBEnVw27Yahj7Dn61FQr0CmShDS X-Google-Smtp-Source: ABdhPJzBqE9YPiSjfIUuhRwebMkow/YEYsvtPD91H086nfo0KdBFCsT0a2twe7oS0mFAEtrPNc7sPQ== X-Received: by 2002:a2e:a22b:: with SMTP id i11mr9360896ljm.57.1626722992785; Mon, 19 Jul 2021 12:29:52 -0700 (PDT) Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com. [209.85.167.49]) by smtp.gmail.com with ESMTPSA id f8sm701958lfe.141.2021.07.19.12.29.51 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jul 2021 12:29:52 -0700 (PDT) Received: by mail-lf1-f49.google.com with SMTP id m16so325007lfg.13 for ; Mon, 19 Jul 2021 12:29:51 -0700 (PDT) X-Received: by 2002:a05:6512:404:: with SMTP id u4mr18798424lfk.40.1626722990987; Mon, 19 Jul 2021 12:29:50 -0700 (PDT) MIME-Version: 1.0 References: <20210718223932.2703330-1-agruenba@redhat.com> <20210718223932.2703330-6-agruenba@redhat.com> In-Reply-To: <20210718223932.2703330-6-agruenba@redhat.com> From: Linus Torvalds Date: Mon, 19 Jul 2021 12:29:35 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 5/6] iov_iter: Introduce ITER_FLAG_FAST_ONLY flag To: Andreas Gruenbacher Cc: Alexander Viro , Jan Kara , Matthew Wilcox , Christoph Hellwig , cluster-devel , linux-fsdevel , Linux Kernel Mailing List , ocfs2-devel@oss.oracle.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 18, 2021 at 3:40 PM Andreas Gruenbacher wrote: > > Introduce a new ITER_FLAG_FAST_ONLY flag I think the code is fine, but I think it might be best to call this "ITER_FLAG_NOIO" or something like that. The "FAST_ONLY" name makes sense in the context of "get_user_pages_fast()" where we have that "fast" naming (and the long history too). But I don't think it makes much sense as a name in the context of iov_iter. Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57EB3C07E95 for ; Mon, 19 Jul 2021 19:30:02 +0000 (UTC) Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB131610D2 for ; Mon, 19 Jul 2021 19:30:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB131610D2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=ocfs2-devel-bounces@oss.oracle.com Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16JJRGc2006035; Mon, 19 Jul 2021 19:30:01 GMT Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 39w83cs1tb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 19 Jul 2021 19:30:00 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 16JJAPsQ106510; Mon, 19 Jul 2021 19:29:59 GMT Received: from oss.oracle.com (oss-old-reserved.oracle.com [137.254.22.2]) by userp3030.oracle.com with ESMTP id 39umaxjr5n-1; Mon, 19 Jul 2021 19:29:59 +0000 Received: from localhost ([127.0.0.1] helo=lb-oss.oracle.com) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1m5Yxi-0007Fj-O3; Mon, 19 Jul 2021 12:29:58 -0700 Received: from aserp3030.oracle.com ([141.146.126.71]) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1m5Yxg-0007FU-SM for ocfs2-devel@oss.oracle.com; Mon, 19 Jul 2021 12:29:56 -0700 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 16JJBECb157830 for ; Mon, 19 Jul 2021 19:29:56 GMT Received: from mx0b-00069f01.pphosted.com (mx0b-00069f01.pphosted.com [205.220.177.26]) by aserp3030.oracle.com with ESMTP id 39upe8uee5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 19 Jul 2021 19:29:56 +0000 Received: from pps.filterd (m0246580.ppops.net [127.0.0.1]) by mx0b-00069f01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16JJS3pI009736 for ; Mon, 19 Jul 2021 19:29:55 GMT Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by mx0b-00069f01.pphosted.com with ESMTP id 39w4k7x05k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=OK) for ; Mon, 19 Jul 2021 19:29:54 +0000 Received: by mail-lj1-f175.google.com with SMTP id d17so7806704ljq.12 for ; Mon, 19 Jul 2021 12:29:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cvseTVwISQQYVhM74Otk0kHaj1gV421l1SCA3Nj6+8A=; b=G2+Zi0zFbhX/UDGXaHgn45YoACiWVzInm6jAqLNPgepLpQL07SLfhd/hvQLvXBF4kD iNPuJwWWSPFlXY666qF5iXrbmhKfIRmiB7OMaSCL5FlThcToIGKEW6HC95qXXvFnuwkW G0anl69rezpDGGV2VSoY/c7y/N15bMUDmSnPQkVb1Ra+rk7PDCcuoolxbL0NSYGXwZ4t ScMWSKDtlaQ8mrqmgkX+rNs9fX4jWjpMJsGuEVITFv7j6anzjZdPhGeYv2dTZ3Ony3qg mBUsCoaDBEL3Euz155Q1dPHC42xGzQjwdC0x7dTPtPogATjRRK4fYgUvSqxz8VvUkTSy tVZQ== X-Gm-Message-State: AOAM530D5z7JO+lCrCxfqn2qPveH1nagpwwJNuMRtRWPeFGC+DtcbhU+ ZfhSbrg1lVrozG4dmJdcAZ3pvSp4otCz9DQg X-Google-Smtp-Source: ABdhPJzIoKHUQczBDX7AhY3BcLC52g9geXmycTtjMIvK4ttUn3IgcgPdfKG+YpJ4Xfhq7cg0dJCv6Q== X-Received: by 2002:a2e:b00f:: with SMTP id y15mr24300143ljk.258.1626722992477; Mon, 19 Jul 2021 12:29:52 -0700 (PDT) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com. [209.85.167.53]) by smtp.gmail.com with ESMTPSA id t10sm2102900ljk.56.2021.07.19.12.29.51 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jul 2021 12:29:51 -0700 (PDT) Received: by mail-lf1-f53.google.com with SMTP id i5so32109603lfe.2 for ; Mon, 19 Jul 2021 12:29:51 -0700 (PDT) X-Received: by 2002:a05:6512:404:: with SMTP id u4mr18798424lfk.40.1626722990987; Mon, 19 Jul 2021 12:29:50 -0700 (PDT) MIME-Version: 1.0 References: <20210718223932.2703330-1-agruenba@redhat.com> <20210718223932.2703330-6-agruenba@redhat.com> In-Reply-To: <20210718223932.2703330-6-agruenba@redhat.com> From: Linus Torvalds Date: Mon, 19 Jul 2021 12:29:35 -0700 X-Gmail-Original-Message-ID: Message-ID: To: Andreas Gruenbacher X-Source-IP: 209.85.208.175 X-ServerName: mail-lj1-f175.google.com X-Proofpoint-SPF-Result: pass X-Proofpoint-SPF-Record: v=spf1 ip4:198.145.29.98/31 ip4:72.55.140.81 include:_spf.google.com include:amazonses.com include:_spf.salesforce.com ~all X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10050 signatures=668682 X-Proofpoint-Spam-Details: rule=tap_notspam policy=tap score=0 impostorscore=0 adultscore=0 mlxlogscore=999 mlxscore=0 priorityscore=30 malwarescore=0 lowpriorityscore=0 suspectscore=0 bulkscore=0 clxscore=350 phishscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2107190111 X-Spam: Clean X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10050 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0 bulkscore=0 malwarescore=0 phishscore=0 mlxlogscore=999 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2107190110 Cc: cluster-devel , Jan Kara , Linux Kernel Mailing List , Christoph Hellwig , Alexander Viro , linux-fsdevel , ocfs2-devel@oss.oracle.com Subject: Re: [Ocfs2-devel] [PATCH v2 5/6] iov_iter: Introduce ITER_FLAG_FAST_ONLY flag X-BeenThere: ocfs2-devel@oss.oracle.com X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: ocfs2-devel-bounces@oss.oracle.com Errors-To: ocfs2-devel-bounces@oss.oracle.com X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10050 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 spamscore=0 mlxscore=0 adultscore=0 mlxlogscore=999 suspectscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2107190110 X-Proofpoint-GUID: CmpHzirxA_z22MpJXq4J1YqHElM8yvni X-Proofpoint-ORIG-GUID: CmpHzirxA_z22MpJXq4J1YqHElM8yvni On Sun, Jul 18, 2021 at 3:40 PM Andreas Gruenbacher wrote: > > Introduce a new ITER_FLAG_FAST_ONLY flag I think the code is fine, but I think it might be best to call this "ITER_FLAG_NOIO" or something like that. The "FAST_ONLY" name makes sense in the context of "get_user_pages_fast()" where we have that "fast" naming (and the long history too). But I don't think it makes much sense as a name in the context of iov_iter. Linus _______________________________________________ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Date: Mon, 19 Jul 2021 12:29:35 -0700 Subject: [Cluster-devel] [PATCH v2 5/6] iov_iter: Introduce ITER_FLAG_FAST_ONLY flag In-Reply-To: <20210718223932.2703330-6-agruenba@redhat.com> References: <20210718223932.2703330-1-agruenba@redhat.com> <20210718223932.2703330-6-agruenba@redhat.com> Message-ID: List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Sun, Jul 18, 2021 at 3:40 PM Andreas Gruenbacher wrote: > > Introduce a new ITER_FLAG_FAST_ONLY flag I think the code is fine, but I think it might be best to call this "ITER_FLAG_NOIO" or something like that. The "FAST_ONLY" name makes sense in the context of "get_user_pages_fast()" where we have that "fast" naming (and the long history too). But I don't think it makes much sense as a name in the context of iov_iter. Linus