From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F010AC433E0 for ; Thu, 14 Jan 2021 18:18:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB2E623A50 for ; Thu, 14 Jan 2021 18:18:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728600AbhANSSW (ORCPT ); Thu, 14 Jan 2021 13:18:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726035AbhANSSW (ORCPT ); Thu, 14 Jan 2021 13:18:22 -0500 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E93CC061575 for ; Thu, 14 Jan 2021 10:17:41 -0800 (PST) Received: by mail-lf1-x12e.google.com with SMTP id o17so9388263lfg.4 for ; Thu, 14 Jan 2021 10:17:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TIhd1uC2z/B49SFr+5F6fuw8ur1PxMBEOpX9JeU0Qpc=; b=AoB8ftutsiFSPCw0cLKCQs0z3iibi8buOE+leA0p6M8n8cLzFROGUPZBIn7ctD38k3 P8PjCxgmmEPwmAxrvDK/44szweqhYTqRRhQ7ABljYS6nvUa+dFzpzyrpyeJb+Zevv9Ut Kqv0YJ+aqmNv1B67+g6LHOBYTHPMx/XbaQCkM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TIhd1uC2z/B49SFr+5F6fuw8ur1PxMBEOpX9JeU0Qpc=; b=DKrOH5mmwWGQkks4Vt0iuxrbcAkEn1/mn4ZaNGR1FzoX7JhLyzgZSlMjdj6+oyF4l/ Tst5JMm5Ap45qcgX/5N67Ebq77uqeEvUjtF2AqIr3iI43tK+38mMjuWx+gYlizT5VsXS dfSkqt+Dc7XsRFhnxl5Lm675P98Xrbvp9GTvHlWaxjqxXgodLZRWyq6hwDXmVr88ar9A IUvXTp/mAGtfX9z1DGgw91O4Sr6jZTHfsm6P0Qyv1TeN5nf0YFL8Zt6MtyZEblQY7B/f PhLkU+Bqm8cXcAviWQawS9uUf95+IF+T+/h7iUluhCPmoXIqsoKH7BcRZ7KgHdj9qAij rBAA== X-Gm-Message-State: AOAM533bGVi5IHT/33XcXxRosfWPhHL/bmdnj2cTcJ2hr6xMy9K3No/o wEW7ZzOGAkdQPPnHra41vKcKHqdVFvWb0g== X-Google-Smtp-Source: ABdhPJyAaZ0KpCbmoQ9oPOKkpTl/x1cDmxtIkoXoFZyrwaKG63HzPNRUEZA+XVgkc6frN4TCf7w7ZA== X-Received: by 2002:a19:844b:: with SMTP id g72mr3614742lfd.7.1610648259587; Thu, 14 Jan 2021 10:17:39 -0800 (PST) Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com. [209.85.167.54]) by smtp.gmail.com with ESMTPSA id h28sm617378lfk.159.2021.01.14.10.17.38 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Jan 2021 10:17:38 -0800 (PST) Received: by mail-lf1-f54.google.com with SMTP id m25so9332416lfc.11 for ; Thu, 14 Jan 2021 10:17:38 -0800 (PST) X-Received: by 2002:ac2:4987:: with SMTP id f7mr3584520lfl.41.1610648258222; Thu, 14 Jan 2021 10:17:38 -0800 (PST) MIME-Version: 1.0 References: <20210114175934.13070-1-will@kernel.org> <20210114175934.13070-6-will@kernel.org> In-Reply-To: <20210114175934.13070-6-will@kernel.org> From: Linus Torvalds Date: Thu, 14 Jan 2021 10:17:22 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH 5/8] mm: Pass 'address' to map to do_set_pte() and drop FAULT_FLAG_PREFAULT To: Will Deacon Cc: Linux Kernel Mailing List , Linux-MM , Linux ARM , Catalin Marinas , Jan Kara , Minchan Kim , Andrew Morton , "Kirill A . Shutemov" , Vinayak Menon , Hugh Dickins , Android Kernel Team Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 14, 2021 at 10:01 AM Will Deacon wrote: > > Rather than modifying the 'address' field of the 'struct vm_fault_info' > passed to do_set_pte(), leave that to identify the real faulting address > and pass in the virtual address to be mapped by the new pte as a > separate argument. Ack. In fact - apart from the question I had about the 'info' sub-structure - ack on the whole series. But this one struck me particularly as "that's simpler and clearer" even if that finish_fault() case is now not as pretty (but with an unnamed structure it would be slightly simpler, at least). Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DE67C433E0 for ; Thu, 14 Jan 2021 18:17:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CC5DA23B55 for ; Thu, 14 Jan 2021 18:17:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC5DA23B55 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 62A9E8D0104; Thu, 14 Jan 2021 13:17:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5DB6D8D0102; Thu, 14 Jan 2021 13:17:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F1908D0104; Thu, 14 Jan 2021 13:17:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0127.hostedemail.com [216.40.44.127]) by kanga.kvack.org (Postfix) with ESMTP id 391528D0102 for ; Thu, 14 Jan 2021 13:17:43 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 00F01181AF5C1 for ; Thu, 14 Jan 2021 18:17:43 +0000 (UTC) X-FDA: 77705188806.28.army06_5a0387627528 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id C26416D75 for ; Thu, 14 Jan 2021 18:17:42 +0000 (UTC) X-HE-Tag: army06_5a0387627528 X-Filterd-Recvd-Size: 4194 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Thu, 14 Jan 2021 18:17:42 +0000 (UTC) Received: by mail-lf1-f52.google.com with SMTP id o17so9388302lfg.4 for ; Thu, 14 Jan 2021 10:17:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TIhd1uC2z/B49SFr+5F6fuw8ur1PxMBEOpX9JeU0Qpc=; b=AoB8ftutsiFSPCw0cLKCQs0z3iibi8buOE+leA0p6M8n8cLzFROGUPZBIn7ctD38k3 P8PjCxgmmEPwmAxrvDK/44szweqhYTqRRhQ7ABljYS6nvUa+dFzpzyrpyeJb+Zevv9Ut Kqv0YJ+aqmNv1B67+g6LHOBYTHPMx/XbaQCkM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TIhd1uC2z/B49SFr+5F6fuw8ur1PxMBEOpX9JeU0Qpc=; b=WFZN3vpLYfZm/iHC28V9KJDEpimPHFk+WOCQhOauTiJNFMw/niJFRGltHZ0NN7ERv+ NOwyTxgtr9W0o/pYJdTz3qcrmT3EfU4ZEyktySICyMukSCVFmdZMK+hTvTthAgPAQUxo g0D6YtRvAtVee9Z+tmbPQHlgWtRCabbUxxib24gMi/EgEDYmj2jg+EmFpSAVRYW4RTI3 mtvzwS6YGxHXDjTYF8mqPHkCCkACNWGHqXaFjpqZdH8YhPpRIMDeiK/SfNp3hW6PJj7m hGaNPljFS0x+gLeWQyryF9jtBjeVv961cu0Xs6RfT2Fi6FVgvJdarSq/RWRkMKxk/3/2 bvDg== X-Gm-Message-State: AOAM531hZfMpLrpDJtJSY0AlzLfKXwSygGn+JaoV7/uZhWJGt1zXfYkf zzsGlSqfLFS/DkYgwBNb1LQGGySk2w5A8Q== X-Google-Smtp-Source: ABdhPJy3v7Huei2oyfCh+GZp5Sy2+NCr6VdchDbcOAVxZ+QKThm9GXcKeS8CW3uLBf1WcPwEnx1g6g== X-Received: by 2002:a19:4f57:: with SMTP id a23mr3766200lfk.495.1610648259876; Thu, 14 Jan 2021 10:17:39 -0800 (PST) Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com. [209.85.167.44]) by smtp.gmail.com with ESMTPSA id i10sm617241lfd.202.2021.01.14.10.17.38 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Jan 2021 10:17:38 -0800 (PST) Received: by mail-lf1-f44.google.com with SMTP id 23so9331010lfg.10 for ; Thu, 14 Jan 2021 10:17:38 -0800 (PST) X-Received: by 2002:ac2:4987:: with SMTP id f7mr3584520lfl.41.1610648258222; Thu, 14 Jan 2021 10:17:38 -0800 (PST) MIME-Version: 1.0 References: <20210114175934.13070-1-will@kernel.org> <20210114175934.13070-6-will@kernel.org> In-Reply-To: <20210114175934.13070-6-will@kernel.org> From: Linus Torvalds Date: Thu, 14 Jan 2021 10:17:22 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH 5/8] mm: Pass 'address' to map to do_set_pte() and drop FAULT_FLAG_PREFAULT To: Will Deacon Cc: Linux Kernel Mailing List , Linux-MM , Linux ARM , Catalin Marinas , Jan Kara , Minchan Kim , Andrew Morton , "Kirill A . Shutemov" , Vinayak Menon , Hugh Dickins , Android Kernel Team Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 14, 2021 at 10:01 AM Will Deacon wrote: > > Rather than modifying the 'address' field of the 'struct vm_fault_info' > passed to do_set_pte(), leave that to identify the real faulting address > and pass in the virtual address to be mapped by the new pte as a > separate argument. Ack. In fact - apart from the question I had about the 'info' sub-structure - ack on the whole series. But this one struck me particularly as "that's simpler and clearer" even if that finish_fault() case is now not as pretty (but with an unnamed structure it would be slightly simpler, at least). Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72E36C433DB for ; Thu, 14 Jan 2021 18:19:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D002223A50 for ; Thu, 14 Jan 2021 18:19:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D002223A50 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Gwh0Xg+iVWyxFUkZOqQmljM1kFMqQhIqcwogUixgOvA=; b=151c5soRjrMBjQX7QodwHrGLY Kn1wG711HFleZYrSkY6K3KF0/iSzZDCx6TwbqSIIaAqrqnNgLR5gyrZtfNIeLKkXPvlhR77XwhFNb 7DMiVGzLeGR4l2HYsDeIwG2Ld0T/RtfGB6Cq783BAYYlnWeBbOXLxn9Hlda00UHQ1AjZosR2BNawn GmMwIsb3rl9NVjmPoPfzQzmMf9WGj0apF7Nc0OW7gSF0xvHjHA9cfPVdLrZ6baW6arL9Xrf9uw6Ku KImxGacar/x/UUWWWnuy1dKeomeQNOt3F7s2e/CUpi2cJ0iLEaHL0Y56ko4h7UKzMjvmyqH9rOGeZ ZbQ01OT6A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l07C3-0002QL-CR; Thu, 14 Jan 2021 18:17:59 +0000 Received: from mail-lj1-x22c.google.com ([2a00:1450:4864:20::22c]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l07Bz-0002Mt-PX for linux-arm-kernel@lists.infradead.org; Thu, 14 Jan 2021 18:17:57 +0000 Received: by mail-lj1-x22c.google.com with SMTP id f11so7525944ljm.8 for ; Thu, 14 Jan 2021 10:17:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TIhd1uC2z/B49SFr+5F6fuw8ur1PxMBEOpX9JeU0Qpc=; b=AoB8ftutsiFSPCw0cLKCQs0z3iibi8buOE+leA0p6M8n8cLzFROGUPZBIn7ctD38k3 P8PjCxgmmEPwmAxrvDK/44szweqhYTqRRhQ7ABljYS6nvUa+dFzpzyrpyeJb+Zevv9Ut Kqv0YJ+aqmNv1B67+g6LHOBYTHPMx/XbaQCkM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TIhd1uC2z/B49SFr+5F6fuw8ur1PxMBEOpX9JeU0Qpc=; b=UjZf8sb7tV44+QmNZ7Q8HHn+teU7bWlrjBZ/8gEwI2Ze/C8ijAdUscNFN/YML7V6kt 4ZKR5iB5UEyrMw87UwwuHV+ZEHTD4nGbmb7DUlVCG/vzvC+43knf2Xi3b02CPIY4QYfU CT2F0gQWnyy8Alsxi5ny3TXBaHjEIcn/FJQMVBgboWrqxqxL2W/0P5cPtf5IGeRvUcE4 YQc8Vm98CXPKbz0TPeSxmAQOEXcWmXu5DQR4cMDFQtNoL4h2qphbbMFz9HsbWBQrD59S 73ERQ6x9zVXj5d8owHTAGmgir4Zg+w2LehPt6u72JNSMj9S3PLAvkq74YceMWhRqVwNQ c++w== X-Gm-Message-State: AOAM532Z62TnmWfaKYN5dgVQtwr3PFce6g1NfdKYFlLUqBrfEpouhx+r Jh7HBikQ/61NbtWP4y8fMjcP+T0eKfj2ww== X-Google-Smtp-Source: ABdhPJxozrwvb3GA5qGKDKy0fdf5MWu2waVVWywHc2NnInNPUBOdVquTj+LaWNWFGr2Vh1L/YCy0/A== X-Received: by 2002:a05:651c:114:: with SMTP id a20mr3609949ljb.392.1610648259385; Thu, 14 Jan 2021 10:17:39 -0800 (PST) Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com. [209.85.167.41]) by smtp.gmail.com with ESMTPSA id d10sm619600lfj.281.2021.01.14.10.17.38 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Jan 2021 10:17:38 -0800 (PST) Received: by mail-lf1-f41.google.com with SMTP id o10so9321837lfl.13 for ; Thu, 14 Jan 2021 10:17:38 -0800 (PST) X-Received: by 2002:ac2:4987:: with SMTP id f7mr3584520lfl.41.1610648258222; Thu, 14 Jan 2021 10:17:38 -0800 (PST) MIME-Version: 1.0 References: <20210114175934.13070-1-will@kernel.org> <20210114175934.13070-6-will@kernel.org> In-Reply-To: <20210114175934.13070-6-will@kernel.org> From: Linus Torvalds Date: Thu, 14 Jan 2021 10:17:22 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH 5/8] mm: Pass 'address' to map to do_set_pte() and drop FAULT_FLAG_PREFAULT To: Will Deacon X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210114_131755_870987_006FF14B X-CRM114-Status: GOOD ( 12.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jan Kara , Minchan Kim , Catalin Marinas , Hugh Dickins , Linux Kernel Mailing List , Linux-MM , Vinayak Menon , "Kirill A . Shutemov" , Andrew Morton , Android Kernel Team , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 14, 2021 at 10:01 AM Will Deacon wrote: > > Rather than modifying the 'address' field of the 'struct vm_fault_info' > passed to do_set_pte(), leave that to identify the real faulting address > and pass in the virtual address to be mapped by the new pte as a > separate argument. Ack. In fact - apart from the question I had about the 'info' sub-structure - ack on the whole series. But this one struck me particularly as "that's simpler and clearer" even if that finish_fault() case is now not as pretty (but with an unnamed structure it would be slightly simpler, at least). Linus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel