From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DBDBC433DF for ; Mon, 29 Jun 2020 19:12:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 49242206E2 for ; Mon, 29 Jun 2020 19:12:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593457941; bh=6iFnLyCLXDyOVpSBa3/MoyeGT0lEkCOfwaPXDKabib0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=LgUrkiVHXveJzuGe6bDNb9R9vr9Jo7Ceih+ZoKas3Mm96t+/vBdrBkEpuH+eUJ/Hi RJsirYUXNVle4VT/v2EZ4aN82XP4d/M44CrSHbsPMbUcY2+R142YZjokMmYG+ZByQF XuiJER564E9HfZk711Buqmg4+qNLO3cCcVtaCByc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730859AbgF2TMU (ORCPT ); Mon, 29 Jun 2020 15:12:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730767AbgF2TK5 (ORCPT ); Mon, 29 Jun 2020 15:10:57 -0400 Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com [IPv6:2a00:1450:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFD56C031413 for ; Mon, 29 Jun 2020 12:10:56 -0700 (PDT) Received: by mail-lf1-x142.google.com with SMTP id y18so9773591lfh.11 for ; Mon, 29 Jun 2020 12:10:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=tSA8ywi78rUHFSpY/Nh0QOGhLyb0fCOpr5Vs4TKLX4I=; b=DdZYOk3C2gqHJgrApbFwYh4JVw30MMHLelRJPuRrFQHuCgzURGP0ySVe+bMXX7P0bc HdR5v5nmxQAKjBr/BJwcCjZ0q6O5mvmktqcNB4/IlzJBckOkjWLgl4r7Ec18e7wl7SnO SG0pnoDk7iVjw0PsWVE3QvC7A0cEGr6+qyrlM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=tSA8ywi78rUHFSpY/Nh0QOGhLyb0fCOpr5Vs4TKLX4I=; b=Z8JBLSno2SK06EBW2DTglcYHwW4comG3cEDI2fmDzx4BXoPIn27NkHIHIisveIRo6C 1e5c/OvHMvFP43plBbx93aReQ9ltfByOsJuTBCZjtIkJ+CC3vJAAK9vmesDuHXRz5s+6 +eE5LruPke7okCjCX0+jXEzZM/rLFWy3c42pSvncAspBliZEaEokg4Rvo0/MTfDF5otm 6aeyxClHFYzElW0gWKK8NyJ8HVa7rZosVpJz1Xmh0wMLAArIV04X8FXKhUBmLXmeTjGs Jutx58+pkEbdRcLHnGVKAzqVmKIDmqilyE+jVRWJfLafKi6MU59OFq/GksKw11WVnMc7 AgvA== X-Gm-Message-State: AOAM530nW9IV8YsD/EGgoyozhBfOfMfIj17qcgOtXfBPVNgxHAKatPt+ L5tekEsj/fx+AeMNcERGfq51hLCd7BE= X-Google-Smtp-Source: ABdhPJwlEfQLP1LT2BtBsFK2LnbKxSxLZGSpFRx7AAnSvI0BgxMFKQIjIfWdvqN0UTp1JUXi1mGCzA== X-Received: by 2002:a05:6512:682:: with SMTP id t2mr10004517lfe.101.1593457855048; Mon, 29 Jun 2020 12:10:55 -0700 (PDT) Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com. [209.85.208.181]) by smtp.gmail.com with ESMTPSA id y188sm141083lfc.36.2020.06.29.12.10.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jun 2020 12:10:54 -0700 (PDT) Received: by mail-lj1-f181.google.com with SMTP id 9so19460790ljv.5 for ; Mon, 29 Jun 2020 12:10:53 -0700 (PDT) X-Received: by 2002:a2e:999a:: with SMTP id w26mr3408927lji.371.1593457853564; Mon, 29 Jun 2020 12:10:53 -0700 (PDT) MIME-Version: 1.0 References: <20200624162901.1814136-4-hch@lst.de> <20200624175548.GA25939@lst.de> <20200629152912.GA26172@lst.de> <20200629180730.GA4600@lst.de> <20200629183636.GA6539@lst.de> In-Reply-To: <20200629183636.GA6539@lst.de> From: Linus Torvalds Date: Mon, 29 Jun 2020 12:10:37 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 03/11] fs: add new read_uptr and write_uptr file operations To: Christoph Hellwig Cc: David Laight , Al Viro , Luis Chamberlain , Kees Cook , Iurii Zaikin , Linux Kernel Mailing List , linux-fsdevel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 29, 2020 at 11:36 AM Christoph Hellwig wrote: > > Having resurrect my work there really are tons of int cases. Which > makes me thing that splitting out a setsockopt_int method which gets > passed value instead of a pointer, then converting all the simple cases > to that first and then doing the real shit later sounds like a prom=D1=96= sing > idea. Try my hacky patch first, and just change the code that does if (get_user(val, (int __user *)optval)) { err =3D -EFAULT; to do val =3D *(int *)optval; In fact, that pattern seems to be so common that you can probably almost do it with a sed-script or something. Linus