From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 176B1C433DB for ; Sun, 27 Dec 2020 20:13:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AEE7B207AB for ; Sun, 27 Dec 2020 20:13:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726300AbgL0UNB (ORCPT ); Sun, 27 Dec 2020 15:13:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726067AbgL0UNA (ORCPT ); Sun, 27 Dec 2020 15:13:00 -0500 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 082ECC061794 for ; Sun, 27 Dec 2020 12:12:20 -0800 (PST) Received: by mail-lf1-x131.google.com with SMTP id b26so19833237lff.9 for ; Sun, 27 Dec 2020 12:12:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ASNmgMMwfzw0LbrYHtLnhPGdwLHLSLekD8OCrKhQBS0=; b=BYaAyo5dGZ2AVajdkz7XJpp87lRLqPcUThVTo4lD3YD5OauF4LnkAOIra7E7n4G/9q T7MpcJLXkjoX64GXVD0UrN+L8ckt2LCePtd9QynxUmxbZD2vNYa7t/+eaEJ20pBj0C1o uNCXBsFV0vquG0IBR/Xq4jM9V+W+kodBhXqLQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ASNmgMMwfzw0LbrYHtLnhPGdwLHLSLekD8OCrKhQBS0=; b=c2tP5XgmYhLlqrfTlY4vckiMcnqe8p45TojHq1KKXh17HZQrkylf3zncPaBZU1RfXp Log7hN3L5NqBupmP90GhvvCmH6cwdTcemiFe60McJh/xRhhkWhVzKNsAk6Um1WyxMwyD KTPqyVgDvGGdNxC6yGujHKcZ3Oc11Fl2qCMUDwZQCmNzNLLb7n0OCGHceh4Q1a+Yc0hk JrP6IQuosZFfVXxW8pjzDmh+wY5Q/x5XQOIXkOfy5NxdUVWkUaSXjLKsCrWmMohI2Gif Z7Gf+pVGvHjdjyi3Tg1dqvFd3O29ZbDNmKwZEsTyV7WdwLrzoZSd/nrH/uEg5NLyksCB jEkA== X-Gm-Message-State: AOAM530TiA2IIzlEIQyvpEpzJqNjgD7oj1UHXTLwfGnqixQ1ytWaxNrv ziDRxXDiYfOVAxM+eCp7gy4c48h1MhDqEA== X-Google-Smtp-Source: ABdhPJw1DaSckgCETW48lefFj/pU7c0ssjiirA38VrC5K//QtPwrHK3liKw1Iea/WdwxDQBTZ/C0GA== X-Received: by 2002:a05:651c:120f:: with SMTP id i15mr21642188lja.339.1609099938036; Sun, 27 Dec 2020 12:12:18 -0800 (PST) Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com. [209.85.167.44]) by smtp.gmail.com with ESMTPSA id u25sm6169585lji.99.2020.12.27.12.12.16 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Dec 2020 12:12:16 -0800 (PST) Received: by mail-lf1-f44.google.com with SMTP id s26so19834892lfc.8 for ; Sun, 27 Dec 2020 12:12:16 -0800 (PST) X-Received: by 2002:a2e:9b13:: with SMTP id u19mr19433416lji.48.1609099936085; Sun, 27 Dec 2020 12:12:16 -0800 (PST) MIME-Version: 1.0 References: <16089960203931@kroah.com> <5ab86253-7703-e892-52b7-e6a8af579822@iki.fi> In-Reply-To: From: Linus Torvalds Date: Sun, 27 Dec 2020 12:12:00 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: LXC broken with 5.10-stable?, ok with 5.9-stable (Re: Linux 5.10.3) To: Jussi Kivilinna , Christoph Hellwig Cc: Greg Kroah-Hartman , Linux Kernel Mailing List , Andrew Morton , stable , lwn@lwn.net, Jiri Slaby Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 27, 2020 at 11:05 AM Linus Torvalds wrote: > > On Sun, Dec 27, 2020 at 10:39 AM Jussi Kivilinna wrote: > > > > 5.10.3 with patch compiles fine, but does not solve the issue. > > Duh. adding the read_iter only fixes kernel_read(). For splice, it also needs a > > .splice_read = generic_file_splice_read, > > in the file operations, something like this... Ok, I verified that patch with the test-case in the bugzilla, and it seems trivially fine. So it's committed as 14e3e989f6a5 ("proc mountinfo: make splice available again") now. Linus