From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D633DC433DF for ; Sun, 18 Oct 2020 16:19:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 23C8820773 for ; Sun, 18 Oct 2020 16:19:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="STmM/5K2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 23C8820773 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 382966B005C; Sun, 18 Oct 2020 12:19:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 30B5C6B0062; Sun, 18 Oct 2020 12:19:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D2E36B0068; Sun, 18 Oct 2020 12:19:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0100.hostedemail.com [216.40.44.100]) by kanga.kvack.org (Postfix) with ESMTP id E12316B005C for ; Sun, 18 Oct 2020 12:19:10 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 6BE0C8249980 for ; Sun, 18 Oct 2020 16:19:10 +0000 (UTC) X-FDA: 77385555660.06.pail29_63040722722f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id 3BC911018C2EB for ; Sun, 18 Oct 2020 16:19:10 +0000 (UTC) X-HE-Tag: pail29_63040722722f X-Filterd-Recvd-Size: 3747 Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Sun, 18 Oct 2020 16:19:09 +0000 (UTC) Received: by mail-lj1-f196.google.com with SMTP id a28so3661995ljn.3 for ; Sun, 18 Oct 2020 09:19:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IaibGbYkQt7+Uesss4+3vVEA04d0eAX9knMf40T0bqg=; b=STmM/5K2ys3sxbyWhBGwpNJq/4rT3xBxbgVkq+AafaPP8zoEnc07QXFuNoGBD3Ofne 8QoGK2amSRUISqcd3Pwg0iRVJFUort6XDPS9BLNoiWknlXYjH4Dmi/JhbkNDSx/6fXN0 P02y+9QVl/WqYMIgupeckKNLsZJcvgsz/+qGI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IaibGbYkQt7+Uesss4+3vVEA04d0eAX9knMf40T0bqg=; b=myoQTLUX3XQCCmV8bcWsJ/kYefFJym5fZ4dmqBgHjvv8S28Nae0kFeSEFA0+zHWEux iczsQZqidm+xsDf34/S0KU0UoignCpQHmCpr6g5kKRVWHtBUQNfS+KFYW1o+dHGNjNhI 7+GiNM6I2Qn3zGnDCzrGYi472zLp3qTPY5h8wcWBIQhg0rc+NFDy1WDyv43y5aejSIXw 1TWoQmTxGiLTLQbsVLirqWRldZRggIbY2+E9iijPGoN4DX1gpl3wyLobSpPJBdbhOfgr i3aD50WDi1s9i5VtjrHVd1ijWrPWMKen0Shf+IW3k6JwttqQdPcWPXIu2Mz46wyzcBP2 GeoA== X-Gm-Message-State: AOAM530cCsxGFX1uBHddyh33LxXJK6pneqM5EWh4zyRfaB39I84nAMZU 7RKb9hSj6OuEpHj+4Rc8USSIwx8jPSpgYA== X-Google-Smtp-Source: ABdhPJzcPcAaa8S+2snIeCwZbZwIJV1C62KtKa4B5G+/3POCzqaoBjee/Uv6Pn/yUMLf00HFE+Dr0A== X-Received: by 2002:a2e:8702:: with SMTP id m2mr4620567lji.21.1603037947674; Sun, 18 Oct 2020 09:19:07 -0700 (PDT) Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com. [209.85.208.172]) by smtp.gmail.com with ESMTPSA id x4sm3152990ljj.62.2020.10.18.09.19.06 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Oct 2020 09:19:06 -0700 (PDT) Received: by mail-lj1-f172.google.com with SMTP id c21so8501383ljj.0 for ; Sun, 18 Oct 2020 09:19:06 -0700 (PDT) X-Received: by 2002:a2e:8815:: with SMTP id x21mr5402447ljh.312.1603037945814; Sun, 18 Oct 2020 09:19:05 -0700 (PDT) MIME-Version: 1.0 References: <20201017161314.88890b87fae7446ccc13c902@linux-foundation.org> <20201017231425.0OZYgQdDr%akpm@linux-foundation.org> In-Reply-To: <20201017231425.0OZYgQdDr%akpm@linux-foundation.org> From: Linus Torvalds Date: Sun, 18 Oct 2020 09:18:50 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [patch 16/40] selftests/vm: use a common gup_test.h To: Andrew Morton Cc: Jonathan Corbet , Jerome Glisse , John Hubbard , Linux-MM , mm-commits@vger.kernel.org, Ralph Campbell , Shuah Khan Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Oct 17, 2020 at 4:14 PM Andrew Morton wrote: > > --- a/mm/gup_test.c~selftests-vm-use-a-common-gup_testh > +++ a/mm/gup_test.c > @@ -4,22 +4,7 @@ > +#include "../../../../mm/gup_test.h" > +++ a/mm/gup_test.h There is no way I'm applying a crazy patch like this. That can't be right. And even if it works, it *still* isn't right. Linus