From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 006D5C7618F for ; Tue, 16 Jul 2019 19:06:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CB0FF20665 for ; Tue, 16 Jul 2019 19:06:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563303993; bh=eS+e3j6KlbhbCBZhOl1ZsUQOC29NSfGH32NfQt1p0EA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=tAqw8R+8huyMLX/x0sPeVvyn5hYXMTHZPly2zTJ+fFFndoJAq0JbeHlgcYFH3AID0 0PicUCenb65i1+L8yjZxQO7QNX4wsSsWz9E53dqARuCJJK+oYtd6MwqQTQFBkzfzWg LKWfVl86Ccv03GMXy/AM7NyunVYdQJUZr/7hfcFg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388345AbfGPTGc (ORCPT ); Tue, 16 Jul 2019 15:06:32 -0400 Received: from mail-lf1-f65.google.com ([209.85.167.65]:35835 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726213AbfGPTGc (ORCPT ); Tue, 16 Jul 2019 15:06:32 -0400 Received: by mail-lf1-f65.google.com with SMTP id p197so14527194lfa.2 for ; Tue, 16 Jul 2019 12:06:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LG1qgJpNmSz1iQ9LvaU/8VdF6DJ/KTavEjwp2ttw70g=; b=MwJ2nfHlclEgRkyb3cO8wydTVc4MkHxq5lpaq+vveKIfNftcJMYxbpp1YoaN5DdVVy Iv7VpTl9fhuMRXW8GqMFmHLv8j+EEvX22qy3iQXAwEJFEsq6eRXCiH6+xf5mxjLOd/sA uSM3b50XkOSu5HmVh63QGVthYBPE2OL0vrEog= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LG1qgJpNmSz1iQ9LvaU/8VdF6DJ/KTavEjwp2ttw70g=; b=jiucmckUrgobOOdtFP+FesYKWEb9mlWdCjw4WZzDhIhKs7IegaV1qusgNyPRhdU7ZU coRBHAElGmHFQJkhQWsj9dEDmpeI1zrtNyWXcnZx/mzlh+c8MKVd5G0M3KabCBi4WPVH 1ZNN+gCfwX/CVqtvQrPwO2esz1JuF4ok2GcTECKAbZS5a9Hpc+rF48NiM8QVe+3SF39B 4jZXPUVy73J+kG9Ire9d6fk5HZwad0mxDPknvnwXCW9wt0jnFdQRBaKX5BKbLkPvfFub Rp+HeBE+PbdZPjKydrCl7YDBwYxJxPwzlUKkKWaOVEhyzQ5045qdHQ0XR33Epycq818a 8srA== X-Gm-Message-State: APjAAAWexUsm/G6juDtcBoU79pJGArZum68rLi3BtBfwa3AOBgvBdZRb IkuVde97lM9zI+jOGXRs0z7PM3Kl6yo= X-Google-Smtp-Source: APXvYqx2s/KYlErDNkeE/tWNhzOf6qb9Od2px90IuHgP4w1JNl/55f4SmqwqYTRaTU0ASG+JdZpFiQ== X-Received: by 2002:ac2:4351:: with SMTP id o17mr15464638lfl.100.1563303989523; Tue, 16 Jul 2019 12:06:29 -0700 (PDT) Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com. [209.85.167.48]) by smtp.gmail.com with ESMTPSA id s7sm3909944lje.95.2019.07.16.12.06.28 for (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 16 Jul 2019 12:06:28 -0700 (PDT) Received: by mail-lf1-f48.google.com with SMTP id 62so9653119lfa.8 for ; Tue, 16 Jul 2019 12:06:28 -0700 (PDT) X-Received: by 2002:ac2:4565:: with SMTP id k5mr15576134lfm.170.1563303988234; Tue, 16 Jul 2019 12:06:28 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Linus Torvalds Date: Tue, 16 Jul 2019 12:06:11 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] SafeSetID LSM changes for 5.3 To: Micah Morton Cc: Linux Kernel Mailing List , linux-security-module Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 15, 2019 at 9:05 AM Micah Morton wrote: > > I'm maintaining the new SafeSetID LSM and was told to set up my own > tree for sending pull requests rather than sending my changes through > James Morris and the security subsystem tree. Yes. It would be good if you also added yourself to the MAINTAINERS file. Right now there's no entry for security/safesetid at all. > This is my first time doing one of these pull requests so hopefully I > didn't screw something up. So a couple of notes: - *please* don't rebase your work in the day before Was this in linux-next? was this tested at all? Hard to tell, since it was rebased recently, so for all I know it's all completely new - don't use a random kernel-of-the-day as the base for development This is related to the rebasing issue, but is true even if you don't rebase. There is no way that it was a good idea to pick my random - possibly completely broken - kernel from Sunday afternoon in the middle of a merge window as a base for development. If you start development, or if you have to rebase (for some *good* reason) you need to do so on a good stable base, not on the quick-sand that is "random kernel of the day during the busiest merge activity". - Please use the "git pull-request" format and then add any extra notes you feel are necessary Yes, your pull request is *almost* git pull-request, but you seem to have actively removed whitespace making it almost illegible. It's really hard to pick out the line that has the actual git repository address, because it's basically hidden inside one big blob of text. I've pulled this as-is since it's the first time, but I expect better next time. There are various resources on some cleanliness issues, and people fairly recently tried to combine it under Documentation/maintainer/rebasing-and-merging.rst which covers at least the basics on why not to rebase etc. And if you *do* end up rebasing, consider the end result "untested", so then it should have been done before the merge window even started, and the rebased branch should have been in linux-next. And not sent to me the very next day. Linus