From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38A18C433E0 for ; Tue, 9 Jun 2020 18:06:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F343D20691 for ; Tue, 9 Jun 2020 18:06:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="Jtw1w5cB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F343D20691 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4B5EE6B0003; Tue, 9 Jun 2020 14:06:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 418646B0006; Tue, 9 Jun 2020 14:06:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3538D6B0003; Tue, 9 Jun 2020 14:06:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0213.hostedemail.com [216.40.44.213]) by kanga.kvack.org (Postfix) with ESMTP id 10F006B0003 for ; Tue, 9 Jun 2020 14:06:54 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id BBA8E18002059 for ; Tue, 9 Jun 2020 18:06:53 +0000 (UTC) X-FDA: 76910454306.18.soda72_2f030b426dc4 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id 4A60E10614270 for ; Tue, 9 Jun 2020 18:06:52 +0000 (UTC) X-HE-Tag: soda72_2f030b426dc4 X-Filterd-Recvd-Size: 4207 Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Tue, 9 Jun 2020 18:06:51 +0000 (UTC) Received: by mail-lj1-f196.google.com with SMTP id y11so24622943ljm.9 for ; Tue, 09 Jun 2020 11:06:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PmiDPm5RfKYNou3XKpZ532bv/zr0tLm/MyKAvW3Kqws=; b=Jtw1w5cBseC0bEGq8urdCKKV/qVD2LSSHZRZb/+4L6FcSoOhKqNk10VpzCVSSb4AWp TEWgQEwyE0Rp6+H5kOp+1VM40qa4jBSOc4GNaTmPF0Ube00PZfriH8jmi7LyNBMhQSFe pRDZM1vnKgBnVyvC7zejdGcITIfVFj0uqIHBA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PmiDPm5RfKYNou3XKpZ532bv/zr0tLm/MyKAvW3Kqws=; b=KbgCwS+44TtEls4zwv4r04kU1ewscHbUOrmQcw7i/HjxYVHUdbSOe6L2dvYkJVrLwI t2x3cCResRBYHKDSGyHQL969VqbZFFKYXDtFODftPF0nPvtvJfmWq0eL7EWOExrstnBy WZYlVZFsAN6AL8Bcmwwoyk43nhDJrxCau6n3l0g+Dzs3VjRcmwDmiHTijb1PJgYInaON HThKr6B6bQ/uahIzk5m8b9T1u2ytMGcQAkB0eWIBDHzDdLEG8xoVQf7OxPiiHuEES0HZ zOn9aERJunaRI8xpHuKjGtxVYWIh0W4fL4bHzg4FSxJ1lIEidlhI3Izi7mjfW1R5cfWC re4Q== X-Gm-Message-State: AOAM532rm3Iaw9fCQMOE0GFyb6Fx0JdZD8IqukAvS0alBobvzJq7gOP6 c4XYrdESNCVkupXb3WzQCm2HvMLBC2k= X-Google-Smtp-Source: ABdhPJxivxhaDEOWn1uHeNEHZ+L3uAoRIUsfJDj/aKvW0msdkNfxci8UI0f2q1vZE9S6WtMtSLuL1Q== X-Received: by 2002:a2e:b003:: with SMTP id y3mr14479093ljk.78.1591726009405; Tue, 09 Jun 2020 11:06:49 -0700 (PDT) Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com. [209.85.208.180]) by smtp.gmail.com with ESMTPSA id n23sm5155461lfq.76.2020.06.09.11.06.48 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jun 2020 11:06:48 -0700 (PDT) Received: by mail-lj1-f180.google.com with SMTP id y11so24622774ljm.9 for ; Tue, 09 Jun 2020 11:06:48 -0700 (PDT) X-Received: by 2002:a2e:8e78:: with SMTP id t24mr6933881ljk.314.1591726007801; Tue, 09 Jun 2020 11:06:47 -0700 (PDT) MIME-Version: 1.0 References: <20200608212922.5b7fa74ca3f4e2444441b7f9@linux-foundation.org> <20200609043501.zcGYY277G%akpm@linux-foundation.org> In-Reply-To: From: Linus Torvalds Date: Tue, 9 Jun 2020 11:06:31 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [patch 91/93] x86: use non-set_fs based maccess routines To: Andrew Morton Cc: Alexei Starovoitov , Daniel Borkmann , Christoph Hellwig , Peter Anvin , Linux-MM , Masami Hiramatsu , Ingo Molnar , mm-commits@vger.kernel.org, Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4A60E10614270 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 9, 2020 at 11:01 AM Linus Torvalds wrote: > > Because right now it does something horribly horribly wrong if the > type of 'src' is at all different from the type of dst, or either of > them is different from 'type' Never mind, it's intentional, and the macro always uses 'type' for the access size. I guess I can see the reason for that, and despite the name it's more akin to the unsafe_copy_loop() helper than unsafe_get_user(). The lack parentheses was a real issue, though. And I still think it _should_ have been more like unsafe_get_user(), since now it's basically useless for anything but that copy loop. Linus