All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Joe Perches <joe@perches.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	 geert@linux-m68k.org, gregkh@linuxfoundation.org,
	netdev@vger.kernel.org,  workflows@vger.kernel.org,
	mario.limonciello@amd.com
Subject: Re: [PATCH v2] scripts: get_maintainer: steer people away from using file paths
Date: Wed, 26 Jul 2023 14:07:28 -0700	[thread overview]
Message-ID: <CAHk-=whZHcergYrraQGgazmOGMbuPsDfRMBXjFLo1aEQPqH2xQ@mail.gmail.com> (raw)
In-Reply-To: <20230726133648.54277d76@kernel.org>

On Wed, 26 Jul 2023 at 13:36, Jakub Kicinski <kuba@kernel.org> wrote:
>
> Just so I fully understand what you're saying - what do you expect me
> to do? Send the developer a notifications saying "please repost" with
> this CC list? How is that preferable to making them do it right the
> first time?!

Not at all.

The whole point is that you already end up relying on scripting to
notice that some people should be cc'd, so just add them
automatically.

Why would you

 (a) waste your own time asking the original developer to re-do his submission

 (b) ask the original developer to do something that clearly long-time
developers don't do

 (c) waste *everybody's* time re-submitting a change that was detected
automatically and could just have been done automatically in the first
place?

just make patchwork add the cc's automatically to the patch - and send
out emails to the people it added.

Patchwork already sends out emails for other things. Guess how I know?
Because I get the patchwork-bot emails all the time for things I have
been cc'd on.  Including, very much, the netdevbpf ones.

And people who don't want to be notified can already register with
patchwork to not be notified. It's right there in that

   Deet-doot-dot, I am a bot.
   https://korg.docs.kernel.org/patchwork/pwbot.html

footer.

So I would literally suggest you just stop asking people to do things
that automation CAN DO BETTER.

The patchwork notification could be just a small note (the same way
the pull request notes are) that point to the submission, and say
"your name has been added to the Cc for this patch because it claims
to fix something you authored or acked".

See what I'm saying? Why are you wasting your time on this? Why are
you making new developers do pointless stuff that is better done by a
script, since you're just asking the developer to run a script in the
first place?

You are just wasting literally EVERYBODY'S time with your workflow
rules. For no actual advantage, since the whole - and only - point of
this all was that it was scriptable, and is in fact already being
scripted, which is how you even notice the issue in the first place.

You seem to be just overly attached to having people waste their time
on running a script that you run automatically *anyway*, and make that
some "required thing for inexperienced developers".

And it can't even be the right thing to do, when experienced
developers don't do it.

That, to me, seems completely crazy.

                   Linus

  reply	other threads:[~2023-07-26 21:07 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-26 15:15 [PATCH v2] scripts: get_maintainer: steer people away from using file paths Jakub Kicinski
2023-07-26 15:20 ` Mario Limonciello
2023-07-26 15:43 ` Joe Perches
2023-07-26 16:23   ` Jakub Kicinski
2023-07-26 16:45     ` Linus Torvalds
2023-07-26 16:51       ` Joe Perches
2023-07-26 18:20       ` Jakub Kicinski
2023-07-26 18:29         ` Linus Torvalds
2023-07-26 18:45           ` Limonciello, Mario
2023-07-26 18:48             ` Linus Torvalds
2023-07-26 18:48           ` Jakub Kicinski
2023-07-26 18:59             ` Linus Torvalds
2023-07-26 19:05               ` Linus Torvalds
2023-07-26 19:37                 ` Linus Torvalds
2023-07-26 20:03                   ` Jakub Kicinski
2023-07-26 20:13                     ` Linus Torvalds
2023-07-26 20:36                       ` Jakub Kicinski
2023-07-26 21:07                         ` Linus Torvalds [this message]
2023-07-26 21:57                           ` Jakub Kicinski
2023-07-26 22:02                             ` Linus Torvalds
2023-07-26 22:15                             ` Linus Torvalds
2023-07-26 23:47                             ` Konstantin Ryabitsev
2023-07-27  0:11                               ` Jakub Kicinski
2023-07-27  0:24                                 ` Konstantin Ryabitsev
2023-07-27  0:27                                   ` Jakub Kicinski
2023-07-27  0:33                                     ` Konstantin Ryabitsev
2023-07-27  1:07                                       ` Joe Perches
2023-07-27 11:00                                   ` Andrew Lunn
2023-07-28 20:29                                     ` Konstantin Ryabitsev
2023-07-28 20:38                                       ` Jakub Kicinski
2023-07-28 20:50                                         ` Konstantin Ryabitsev
2023-07-29  0:22                                       ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=whZHcergYrraQGgazmOGMbuPsDfRMBXjFLo1aEQPqH2xQ@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=kuba@kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=netdev@vger.kernel.org \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.