From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 879F8C43331 for ; Fri, 3 Apr 2020 18:01:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 588C9206F5 for ; Fri, 3 Apr 2020 18:01:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585936892; bh=7zmbXy9Ngm7ydugKdrnEPuKqypDBIdC9kEsYoVRFRUg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=ylyZImI8f+qg9wPnU7MibCN1Botc5PUDL8SyWa6U9VzIpEgQWaGYayi00XUz6KgpS /yNYaZHDk8gJz904uxX83c2uwVhca+eDHBhDcZi0KLBa27VP4sOkZkZ7oQxD0U2FZ5 H9PKwdssTJZTSzAJMZlqhisFM4MO8YP+kpd0MG4w= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404394AbgDCSBb (ORCPT ); Fri, 3 Apr 2020 14:01:31 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:35201 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728513AbgDCSBa (ORCPT ); Fri, 3 Apr 2020 14:01:30 -0400 Received: by mail-lj1-f196.google.com with SMTP id k21so7922872ljh.2 for ; Fri, 03 Apr 2020 11:01:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GJVFgRSGYKBnNbBPTVD/IukQXQa7rwPwND5Kh+NTBuo=; b=Ys0nLdOPaMPZHWrNpQG57PugKN6mkPGdJSUx/TQDpwY2GQmZdYkhxJaiTGDykgi3DV b9peyP0pK7wyoIA4rX92GpUwZxOJ1gL4WdkK8qsym8w0OHPBQz5LC8Pgsely+7R6EED/ Y1qrLKu/XLubSi3S/jM7cWoFX4dK0Vuw/7IEk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GJVFgRSGYKBnNbBPTVD/IukQXQa7rwPwND5Kh+NTBuo=; b=CmKZ2S2rbDc0+gjPkl96Lhp+i+E5QLRYCuHdztUAYY1B4Ep702/MJjfyryq9M2T/bn G2RbE/tBo4oiK4MgXAnMUFDl9fMBf7+TyCi37nvcMCU/PBaCey1b/x6Ix0nWn+IakETG okXn4xbQlAwJrJIbVKdGPWD/MAXcbQa0fGZudEJFPXFeB7fL00pcZsol+l2u4lvk2B6H DrZ2Gzh1TbDUK5xfbiv3lE+oWk18LPqrxlWpTgBF8mZpUlurR7ulOBZK1d4p3PP21olV 2VToR1VqwRQMKT69CWH3u5MWufOx3NXZ/MYApz2DIMqK3bxAjozdHQMi9riGJA2MnfxU 5MCA== X-Gm-Message-State: AGi0PuZEF2iWgEonyJ+6neT5B+aMNE9SJynATQLdB0SLHt0Ud/PqbNLe /Ha548CP40Ulil0a/dD1WYz5OMOPwuM= X-Google-Smtp-Source: APiQypKnGS8j5JnvV6+AX+j4b7TukVykzor1tDBx+LJFEIJKj61JI0V5cgNNZqe7iqpITgbm+SOWTw== X-Received: by 2002:a2e:91cc:: with SMTP id u12mr5875418ljg.244.1585936888402; Fri, 03 Apr 2020 11:01:28 -0700 (PDT) Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com. [209.85.208.181]) by smtp.gmail.com with ESMTPSA id c203sm4602756lfd.38.2020.04.03.11.01.27 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Apr 2020 11:01:27 -0700 (PDT) Received: by mail-lj1-f181.google.com with SMTP id t17so7848792ljc.12 for ; Fri, 03 Apr 2020 11:01:27 -0700 (PDT) X-Received: by 2002:a2e:8652:: with SMTP id i18mr5777613ljj.265.1585936886747; Fri, 03 Apr 2020 11:01:26 -0700 (PDT) MIME-Version: 1.0 References: <36e43241c7f043a24b5069e78c6a7edd11043be5.1585898438.git.christophe.leroy@c-s.fr> <42da416106d5c1cf92bda1e058434fe240b35f44.1585898438.git.christophe.leroy@c-s.fr> In-Reply-To: <42da416106d5c1cf92bda1e058434fe240b35f44.1585898438.git.christophe.leroy@c-s.fr> From: Linus Torvalds Date: Fri, 3 Apr 2020 11:01:10 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 5/5] uaccess: Rename user_access_begin/end() to user_full_access_begin/end() To: Christophe Leroy Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Dave Airlie , Daniel Vetter , Al Viro , Andrew Morton , Kees Cook , Peter Anvin , Linux Kernel Mailing List , linuxppc-dev , Linux-MM , linux-arch , intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 3, 2020 at 12:21 AM Christophe Leroy wrote: > > Now we have user_read_access_begin() and user_write_access_begin() > in addition to user_access_begin(). I realize Al asked for this, but I don't think it really adds anything to the series. The "full" makes the names longer, but not really any more legible. So I like 1-4, but am unconvinced about 5 and would prefer that to be dropped. Sorry for the bikeshedding. And I like this series much better without the cookie that was discussed, and just making the hard rule be that they can't nest. Some architecture may obviously use a cookie internally if they have some nesting behavior of their own, but it doesn't look like we have any major reason to expose that as the actual interface. The only other question is how to synchronize this? I'm ok with it going through the ppc tree, for example, and just let others build on that. Maybe using a shared immutable branch with 5.6 as a base? Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 743AFC2BA16 for ; Fri, 3 Apr 2020 18:01:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2CBEF2077D for ; Fri, 3 Apr 2020 18:01:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="Ys0nLdOP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2CBEF2077D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B518C8E0008; Fri, 3 Apr 2020 14:01:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B02128E0007; Fri, 3 Apr 2020 14:01:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9F0888E0008; Fri, 3 Apr 2020 14:01:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0156.hostedemail.com [216.40.44.156]) by kanga.kvack.org (Postfix) with ESMTP id 85BA88E0007 for ; Fri, 3 Apr 2020 14:01:32 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 462BB180AD81D for ; Fri, 3 Apr 2020 18:01:32 +0000 (UTC) X-FDA: 76667311224.12.rose20_81cbd7be11511 X-HE-Tag: rose20_81cbd7be11511 X-Filterd-Recvd-Size: 4808 Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Fri, 3 Apr 2020 18:01:31 +0000 (UTC) Received: by mail-lj1-f195.google.com with SMTP id p14so7851581lji.11 for ; Fri, 03 Apr 2020 11:01:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GJVFgRSGYKBnNbBPTVD/IukQXQa7rwPwND5Kh+NTBuo=; b=Ys0nLdOPaMPZHWrNpQG57PugKN6mkPGdJSUx/TQDpwY2GQmZdYkhxJaiTGDykgi3DV b9peyP0pK7wyoIA4rX92GpUwZxOJ1gL4WdkK8qsym8w0OHPBQz5LC8Pgsely+7R6EED/ Y1qrLKu/XLubSi3S/jM7cWoFX4dK0Vuw/7IEk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GJVFgRSGYKBnNbBPTVD/IukQXQa7rwPwND5Kh+NTBuo=; b=VL6uuBTlSTF1zm1FvAZ1QtHRhlTscnZni/RyIM9LlZxn/3s6GIyFUzk90lhX5ciXEX LZilo+LSkv+tLrliQdlc8og9ipn/1isBt89TrJBl9xCwyfIbgbGRDEGQz7COe3R6TpBA 2ztxRn+GRdqa1Bi5Ht2M4zG9VEGF8L3MPxSkRnBeocLyhImMbNNV8TtcftWCczF0YJBr nPnkBhD+NQ9xiI7b5VUkw+40dnYAG7FQIFR2mJ3CmzGVdoydKJvSpDpCbE1eY1Gqhjrq RbfQB2+W+kYjLSbaw2YIqUWyxkmVv9hMz+oi6U0w+Eqwpqkx1Z3gC7q7CDBBtcCA8xST raCg== X-Gm-Message-State: AGi0PuZl0gY99JGG3eGnINc3QJLP2yes54MBXEyl+kec7mXX+dz0gDm7 HYxnlhSGj3p0TTXdgSYhaEwMgFmqBTo= X-Google-Smtp-Source: APiQypJmtditg6y5zpsgkCuY5Ct29ID+sbT7UdcQRAz/E44bLMluj72E+PPyVYic+13WN2RSt4jU2w== X-Received: by 2002:a2e:b005:: with SMTP id y5mr5501701ljk.25.1585936888550; Fri, 03 Apr 2020 11:01:28 -0700 (PDT) Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com. [209.85.208.173]) by smtp.gmail.com with ESMTPSA id g5sm5358837ljl.106.2020.04.03.11.01.27 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Apr 2020 11:01:27 -0700 (PDT) Received: by mail-lj1-f173.google.com with SMTP id v16so7892213ljg.5 for ; Fri, 03 Apr 2020 11:01:27 -0700 (PDT) X-Received: by 2002:a2e:8652:: with SMTP id i18mr5777613ljj.265.1585936886747; Fri, 03 Apr 2020 11:01:26 -0700 (PDT) MIME-Version: 1.0 References: <36e43241c7f043a24b5069e78c6a7edd11043be5.1585898438.git.christophe.leroy@c-s.fr> <42da416106d5c1cf92bda1e058434fe240b35f44.1585898438.git.christophe.leroy@c-s.fr> In-Reply-To: <42da416106d5c1cf92bda1e058434fe240b35f44.1585898438.git.christophe.leroy@c-s.fr> From: Linus Torvalds Date: Fri, 3 Apr 2020 11:01:10 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 5/5] uaccess: Rename user_access_begin/end() to user_full_access_begin/end() To: Christophe Leroy Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Dave Airlie , Daniel Vetter , Al Viro , Andrew Morton , Kees Cook , Peter Anvin , Linux Kernel Mailing List , linuxppc-dev , Linux-MM , linux-arch , intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 3, 2020 at 12:21 AM Christophe Leroy wrote: > > Now we have user_read_access_begin() and user_write_access_begin() > in addition to user_access_begin(). I realize Al asked for this, but I don't think it really adds anything to the series. The "full" makes the names longer, but not really any more legible. So I like 1-4, but am unconvinced about 5 and would prefer that to be dropped. Sorry for the bikeshedding. And I like this series much better without the cookie that was discussed, and just making the hard rule be that they can't nest. Some architecture may obviously use a cookie internally if they have some nesting behavior of their own, but it doesn't look like we have any major reason to expose that as the actual interface. The only other question is how to synchronize this? I'm ok with it going through the ppc tree, for example, and just let others build on that. Maybe using a shared immutable branch with 5.6 as a base? Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FAF0C43331 for ; Fri, 3 Apr 2020 18:03:33 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BAC43206F5 for ; Fri, 3 Apr 2020 18:03:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="Ys0nLdOP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BAC43206F5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 48v78f2VwhzF0fc for ; Sat, 4 Apr 2020 05:03:30 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linuxfoundation.org (client-ip=2a00:1450:4864:20::141; helo=mail-lf1-x141.google.com; envelope-from=torvalds@linuxfoundation.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linux-foundation.org header.i=@linux-foundation.org header.a=rsa-sha256 header.s=google header.b=Ys0nLdOP; dkim-atps=neutral Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com [IPv6:2a00:1450:4864:20::141]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 48v76Q62p3zDqg1 for ; Sat, 4 Apr 2020 05:01:34 +1100 (AEDT) Received: by mail-lf1-x141.google.com with SMTP id j17so6535677lfe.7 for ; Fri, 03 Apr 2020 11:01:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GJVFgRSGYKBnNbBPTVD/IukQXQa7rwPwND5Kh+NTBuo=; b=Ys0nLdOPaMPZHWrNpQG57PugKN6mkPGdJSUx/TQDpwY2GQmZdYkhxJaiTGDykgi3DV b9peyP0pK7wyoIA4rX92GpUwZxOJ1gL4WdkK8qsym8w0OHPBQz5LC8Pgsely+7R6EED/ Y1qrLKu/XLubSi3S/jM7cWoFX4dK0Vuw/7IEk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GJVFgRSGYKBnNbBPTVD/IukQXQa7rwPwND5Kh+NTBuo=; b=S8g1Bw93+XcusWIiVHSn486IBDcLrp2XwffcpDzcHKazUupm7fAucuXws6JpgwhkU9 gBzXNtAc62zGmg/IDSp8LyPySPFXqFBDMc+qr4Mzy9Uad1aA9v93j+7M2DeRhGDJHcQH 8KX46rZorA+U3JGGELh/qH7HYQi6cb+gREJK7gMwClUfgnh89GYLrAWudYnE7SbJ2IVQ ZhFEAUF1HvM8qevAcpgW3hAZTRHgPjS0qXm118Zpv77ycC1dt1tVKK/+CIBiS3pcTSTj wzv3t5sQ0qFmQszJxYqmX1670bZypiJJvO/HdPStMn7dbIZ91hsYI+wBeoF3FGS9sYrz jQ6A== X-Gm-Message-State: AGi0PuaWqcu0TmDCtPMMPf+PF+VyV99Lys7JbNc2QvOaaa430W4Oz/bu XRoAPioJHpxPBTzIGpG1JEw61UedKo0= X-Google-Smtp-Source: APiQypJ1pv1wW2lELWcesXxNTzTb2B8AyVfwegM5zIVpq01vncaKdCi5ZeoQIfetteymhIb4fjdB/Q== X-Received: by 2002:a05:6512:3042:: with SMTP id b2mr6367901lfb.92.1585936888582; Fri, 03 Apr 2020 11:01:28 -0700 (PDT) Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com. [209.85.208.174]) by smtp.gmail.com with ESMTPSA id e2sm5301437ljl.83.2020.04.03.11.01.27 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Apr 2020 11:01:27 -0700 (PDT) Received: by mail-lj1-f174.google.com with SMTP id p14so7851353lji.11 for ; Fri, 03 Apr 2020 11:01:27 -0700 (PDT) X-Received: by 2002:a2e:8652:: with SMTP id i18mr5777613ljj.265.1585936886747; Fri, 03 Apr 2020 11:01:26 -0700 (PDT) MIME-Version: 1.0 References: <36e43241c7f043a24b5069e78c6a7edd11043be5.1585898438.git.christophe.leroy@c-s.fr> <42da416106d5c1cf92bda1e058434fe240b35f44.1585898438.git.christophe.leroy@c-s.fr> In-Reply-To: <42da416106d5c1cf92bda1e058434fe240b35f44.1585898438.git.christophe.leroy@c-s.fr> From: Linus Torvalds Date: Fri, 3 Apr 2020 11:01:10 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 5/5] uaccess: Rename user_access_begin/end() to user_full_access_begin/end() To: Christophe Leroy Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch , Kees Cook , Dave Airlie , intel-gfx@lists.freedesktop.org, Peter Anvin , Linux Kernel Mailing List , Linux-MM , Paul Mackerras , Al Viro , Daniel Vetter , Andrew Morton , linuxppc-dev Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Apr 3, 2020 at 12:21 AM Christophe Leroy wrote: > > Now we have user_read_access_begin() and user_write_access_begin() > in addition to user_access_begin(). I realize Al asked for this, but I don't think it really adds anything to the series. The "full" makes the names longer, but not really any more legible. So I like 1-4, but am unconvinced about 5 and would prefer that to be dropped. Sorry for the bikeshedding. And I like this series much better without the cookie that was discussed, and just making the hard rule be that they can't nest. Some architecture may obviously use a cookie internally if they have some nesting behavior of their own, but it doesn't look like we have any major reason to expose that as the actual interface. The only other question is how to synchronize this? I'm ok with it going through the ppc tree, for example, and just let others build on that. Maybe using a shared immutable branch with 5.6 as a base? Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E871C2BA12 for ; Fri, 3 Apr 2020 18:01:33 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 47A8E20BED for ; Fri, 3 Apr 2020 18:01:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="Ys0nLdOP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 47A8E20BED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C0DFD89D99; Fri, 3 Apr 2020 18:01:32 +0000 (UTC) Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com [IPv6:2a00:1450:4864:20::142]) by gabe.freedesktop.org (Postfix) with ESMTPS id D5DA489D99 for ; Fri, 3 Apr 2020 18:01:30 +0000 (UTC) Received: by mail-lf1-x142.google.com with SMTP id n20so6498888lfl.10 for ; Fri, 03 Apr 2020 11:01:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GJVFgRSGYKBnNbBPTVD/IukQXQa7rwPwND5Kh+NTBuo=; b=Ys0nLdOPaMPZHWrNpQG57PugKN6mkPGdJSUx/TQDpwY2GQmZdYkhxJaiTGDykgi3DV b9peyP0pK7wyoIA4rX92GpUwZxOJ1gL4WdkK8qsym8w0OHPBQz5LC8Pgsely+7R6EED/ Y1qrLKu/XLubSi3S/jM7cWoFX4dK0Vuw/7IEk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GJVFgRSGYKBnNbBPTVD/IukQXQa7rwPwND5Kh+NTBuo=; b=dd+MC5MHIkbnpOyWJFp4ZqC7pMYEqp4VQXAhmtiYcUoyYIMpfkQarBmK5jBjzuwpyf r0ZdDl9CnySrW3lFC81n2r8KIgfByi7HUmaAQpAaJVzxR+mDjW38hbZNDkzmlKn2F1JA xgiCfy0ATTU8uxo0nG+bapp+PlcmZow2/OitkkTzCt2H7n0yTdFEVXEU/K/KajWT+F5K u4xFyrFtkSGtZN8veyWEJK2+/Xzr02u0rH6YxDcRrb4qVygbwObaHAGANN1peIFOxxRf 2txGiQ8PLYCM9rUvl5oxOdv8swZyOKt71YJshc6z+AGoAuk7KlxXw0eYqZLINHKwcNo4 LgLg== X-Gm-Message-State: AGi0PubTrW7yEhiVQA9MCM5XOcTuDH6NoH2khODYMb2I8sK1+3yXLQ2w Hj3Zf1cxbs+OayLxtKIZrA3x+NLQxp8= X-Google-Smtp-Source: APiQypKaWqmnvNgXUju95f5po2esy7DcGOHpaN38EAPK55WeiX57fHfrf8Bkemq0+F/QnIbOfEkaAw== X-Received: by 2002:ac2:51c3:: with SMTP id u3mr5768209lfm.25.1585936888623; Fri, 03 Apr 2020 11:01:28 -0700 (PDT) Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com. [209.85.208.179]) by smtp.gmail.com with ESMTPSA id b21sm5259300ljj.46.2020.04.03.11.01.27 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Apr 2020 11:01:27 -0700 (PDT) Received: by mail-lj1-f179.google.com with SMTP id i20so7863898ljn.6 for ; Fri, 03 Apr 2020 11:01:27 -0700 (PDT) X-Received: by 2002:a2e:8652:: with SMTP id i18mr5777613ljj.265.1585936886747; Fri, 03 Apr 2020 11:01:26 -0700 (PDT) MIME-Version: 1.0 References: <36e43241c7f043a24b5069e78c6a7edd11043be5.1585898438.git.christophe.leroy@c-s.fr> <42da416106d5c1cf92bda1e058434fe240b35f44.1585898438.git.christophe.leroy@c-s.fr> In-Reply-To: <42da416106d5c1cf92bda1e058434fe240b35f44.1585898438.git.christophe.leroy@c-s.fr> From: Linus Torvalds Date: Fri, 3 Apr 2020 11:01:10 -0700 X-Gmail-Original-Message-ID: Message-ID: To: Christophe Leroy Subject: Re: [Intel-gfx] [PATCH v2 5/5] uaccess: Rename user_access_begin/end() to user_full_access_begin/end() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch , Kees Cook , Dave Airlie , Benjamin Herrenschmidt , intel-gfx@lists.freedesktop.org, Peter Anvin , Linux Kernel Mailing List , Linux-MM , Paul Mackerras , Al Viro , Michael Ellerman , Andrew Morton , linuxppc-dev Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Apr 3, 2020 at 12:21 AM Christophe Leroy wrote: > > Now we have user_read_access_begin() and user_write_access_begin() > in addition to user_access_begin(). I realize Al asked for this, but I don't think it really adds anything to the series. The "full" makes the names longer, but not really any more legible. So I like 1-4, but am unconvinced about 5 and would prefer that to be dropped. Sorry for the bikeshedding. And I like this series much better without the cookie that was discussed, and just making the hard rule be that they can't nest. Some architecture may obviously use a cookie internally if they have some nesting behavior of their own, but it doesn't look like we have any major reason to expose that as the actual interface. The only other question is how to synchronize this? I'm ok with it going through the ppc tree, for example, and just let others build on that. Maybe using a shared immutable branch with 5.6 as a base? Linus _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx