From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CF67C433EF for ; Tue, 7 Jun 2022 22:08:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1382365AbiFGWIc (ORCPT ); Tue, 7 Jun 2022 18:08:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379813AbiFGVG3 (ORCPT ); Tue, 7 Jun 2022 17:06:29 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63F2321110F for ; Tue, 7 Jun 2022 11:50:23 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id bg6so17196790ejb.0 for ; Tue, 07 Jun 2022 11:50:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lxgwqXrTE5CS81OOTZfgrmr4rRv5j2bUa4aaRbpCvDQ=; b=UIn4bvZhXW7AF2rT52jP/vHIPjI8XyKoA3dn2Q+Bi0s2HH11YyOvGVEVe86JVSoGKI BaaWsQh6OrE4aTrQmY6fkIGKtAYybadmY8CgsBkfKkdrn9/E2Hw2YgipoxbbIFvguJ8i wugGZSlCqni+gcqC9Yso1tIQl10wVmmIOsHm0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lxgwqXrTE5CS81OOTZfgrmr4rRv5j2bUa4aaRbpCvDQ=; b=08u5zEVxSIYwFNoAdPnywnEzHOLG0uSLi1hg7XS/yQ7HkA6KBSUzde6CirNDF/Mx7K aEy7toveV/lDYaveBaZYHbFDwSZ+55zGA4/n5nM2uJ/XIM3/Mio3kAnJ7ksqIe7i2vnd bGVTEi1OGQgq+SJZlOmykx+Oxzw//TdlDNRfI71QpVf4xHXAyIsfC0hWq7Qh/zWoCAyl MpNqHNm3pJ5eLilJqK/IC00Ne+hsduALAu8WU/oK7H0bqaKdzvUQvXgCjNbJ3duTEJAh +h+32RuzOrS+KIE6WvzZQD5E+4O/O1Jm5/PFeaegt/GhKyTZkb6D2suNyGe0JYsyhs5Q dzSw== X-Gm-Message-State: AOAM533ROkZhzIn1V9v3E1EHvzmgX9EtF4xon/Dx+obI5xZESYWvlqKv D3w/NLD+Ua45umk4hrF0Zg6xGkcuwZgC3hDSHUI= X-Google-Smtp-Source: ABdhPJwCpSrPk7PXgXlO65PYgzwn0dW99k0EymupWGqkCJbmkBpFx02J5QdaEkeko+YGoY2vtwNeWQ== X-Received: by 2002:a17:906:9751:b0:711:e80e:fcb with SMTP id o17-20020a170906975100b00711e80e0fcbmr2994093ejy.74.1654627815733; Tue, 07 Jun 2022 11:50:15 -0700 (PDT) Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com. [209.85.221.44]) by smtp.gmail.com with ESMTPSA id z3-20020a170906270300b00704a5c530ccsm8140850ejc.162.2022.06.07.11.50.13 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jun 2022 11:50:14 -0700 (PDT) Received: by mail-wr1-f44.google.com with SMTP id u8so21038247wrm.13 for ; Tue, 07 Jun 2022 11:50:13 -0700 (PDT) X-Received: by 2002:a05:6000:1b0f:b0:210:313a:ef2a with SMTP id f15-20020a0560001b0f00b00210313aef2amr28815309wrz.281.1654627813569; Tue, 07 Jun 2022 11:50:13 -0700 (PDT) MIME-Version: 1.0 References: <20220605162537.1604762-1-yury.norov@gmail.com> In-Reply-To: From: Linus Torvalds Date: Tue, 7 Jun 2022 11:49:57 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] net/bluetooth: fix erroneous use of bitmap_from_u64() To: Luiz Augusto von Dentz Cc: Yury Norov , Marcel Holtmann , Johan Hedberg , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Guo Ren , linux-bluetooth , Netdev , Linux Kernel Mailing List , linux-csky@vger.kernel.org, Sudip Mukherjee , Alexander Gordeev , Andy Shevchenko , Christian Borntraeger , Claudio Imbrenda , David Hildenbrand , Heiko Carstens , Janosch Frank , Rasmus Villemoes , Sven Schnelle , Vasily Gorbik Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 6, 2022 at 11:00 PM Luiz Augusto von Dentz wrote: > > Right, thanks for fixing it. About some of the changes perhaps we > should use BIT when declaring values in enum hci_conn_flags? That sounds sane, although with just two flag values I'm not sure it matters. But I guess it would document the fact that it's a bitmask, not an ordinal value, and it looks like that header is already using BIT() elsewhere so there are no new header file dependencies.. Linus