From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8920C433EF for ; Fri, 17 Sep 2021 18:48:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BAFA061241 for ; Fri, 17 Sep 2021 18:48:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235912AbhIQSuN (ORCPT ); Fri, 17 Sep 2021 14:50:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235203AbhIQSuM (ORCPT ); Fri, 17 Sep 2021 14:50:12 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5A62C061574 for ; Fri, 17 Sep 2021 11:48:49 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id h17so33532942edj.6 for ; Fri, 17 Sep 2021 11:48:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Cpak71tpwGIH8sDgLDrdJbMzVDQHoqt6rJZasCMwdzc=; b=PPZqYKySWRBXLCmQqLignaVRzeemkJWbOSVm4Nk3LB3/dwYqxZT99gFitFC859Cqmo 5dHLqIWjBbL09xTf3eNTCSAzEfwW62QnHoObFrYVOWn0PPzzY6lksRvKhahbrO9bPfvT /jfwN2l8iu/pKIRl254LqCHUDuwZMUECiAh00= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Cpak71tpwGIH8sDgLDrdJbMzVDQHoqt6rJZasCMwdzc=; b=mYL3x0p0zvq6gRP5b0SCea+5b2Yz1JD4k9g2iYh6ZiDxy7g0APEI2ADcPMf5nvEDVx nsXmhirs0bdJu19D3hvG/oWISg8UPhcCrvjA721yc52S8kzdGUGajFe2XU2ySF2ROz+o RZVy+lKmprl9up93XpK8ZOrGrIhpbP55O7U9cylG4w7T3u8WF45RqWPisWDwRdixGLc7 wSAUcdapPC0cLYv6dKCOBYQfAYb85B0Mn46DzEhDh+MtCkJ0LCtTva7U26WR5x8uLPof jypre9rRNKUTsf04Fs4xAgYD3dSlD/yhk3Gqqp+XzVyPG2iaUnKf1QlD5YGnbrPmG/nz KRbQ== X-Gm-Message-State: AOAM531I8gj0TL22po1xcwUvHHPslElmrMg6fBq76W8ZcmVlZ9Z7M3Lz FeucaPsmVs5qAHj2x9pKnZ1/UoqoKQjojQkG/Q4= X-Google-Smtp-Source: ABdhPJxE+1zxO/YJglL939bQyHQb+motttSfKITSckSUBR+/CYzDfVvAukAn5jPT7yzgLDU6CSlpXg== X-Received: by 2002:a17:906:4dd5:: with SMTP id f21mr13726456ejw.106.1631904528020; Fri, 17 Sep 2021 11:48:48 -0700 (PDT) Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com. [209.85.221.42]) by smtp.gmail.com with ESMTPSA id g9sm2670865ejo.60.2021.09.17.11.48.47 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Sep 2021 11:48:47 -0700 (PDT) Received: by mail-wr1-f42.google.com with SMTP id t8so9685570wri.1 for ; Fri, 17 Sep 2021 11:48:47 -0700 (PDT) X-Received: by 2002:a19:ae15:: with SMTP id f21mr9099719lfc.402.1631904049054; Fri, 17 Sep 2021 11:40:49 -0700 (PDT) MIME-Version: 1.0 References: <20210917061104.2680133-1-brendanhiggins@google.com> <20210917061104.2680133-6-brendanhiggins@google.com> <202109170856.8DDB49112D@keescook> In-Reply-To: <202109170856.8DDB49112D@keescook> From: Linus Torvalds Date: Fri, 17 Sep 2021 11:40:33 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1 5/6] mmc: sdhci-of-aspeed: build kunit tests without structleak plugin To: Kees Cook Cc: Brendan Higgins , Shuah Khan , David Gow , Arnd Bergmann , Rafael Wysocki , Jonathan Cameron , Lars-Peter Clausen , Ulf Hansson , andreas.noever@gmail.com, michael.jamet@intel.com, Mika Westerberg , YehezkelShB@gmail.com, Masahiro Yamada , Michal Marek , Nick Desaulniers , "open list:KERNEL SELFTEST FRAMEWORK" , KUnit Development , Linux Kernel Mailing List , Greg Kroah-Hartman , linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, linux-usb@vger.kernel.org, linux-hardening@vger.kernel.org, Linux Kbuild mailing list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 17, 2021 at 8:57 AM Kees Cook wrote: > > This isn't a stand-alone test object, so I'm less excited about > disabling STRUCTLEAK here. Yeah, please don't do this for things that aren't pure tests. You're now disabling security measures (even if I hate the gcc plugins and hope they will go away). Linus