From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F551C35280 for ; Sun, 10 May 2020 03:36:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4AC1520746 for ; Sun, 10 May 2020 03:36:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589081801; bh=HN1s+g6bNFKRMOSSvP0y3OkGK/+9CBHcg9pKv2Bm6EM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=fgZVwTnAZn70xaylF1DUq875Sw8rFARknqDLYf60OgxsNAgHibw88rofYP+fHwDoZ TK0ZesZg9WYjObbF4AMABTqtxKuj1VZyL/P394slx21RMOMzs2Fo04dwEnXfSiUrCx Qy+xfqhwUYwi1mBqNSzAaZEvx5c0G6fhwlvfXefY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726660AbgEJDgk (ORCPT ); Sat, 9 May 2020 23:36:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726067AbgEJDgk (ORCPT ); Sat, 9 May 2020 23:36:40 -0400 Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com [IPv6:2a00:1450:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06FE1C061A0C for ; Sat, 9 May 2020 20:36:40 -0700 (PDT) Received: by mail-lf1-x142.google.com with SMTP id r17so1524905lff.9 for ; Sat, 09 May 2020 20:36:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=C3sNE7/R3wLoLlTARZrhafNKuUEQMhRiGUVOrVB7ud4=; b=bP4cgr5RHFUE4qTztEKNwBif3xwzOOTJwgJJNzbcSVARklXOsoYWP5EhnQ6fIsYs5h YDDsUNnicR+sfKEEvmcfYEaed4zYCEOyEszhKQT6rNsOuNixbyM9LE1raanDJ8Vhr0wx pSsN64JMNxcRs2VZqlJmj0GdGcexrg2g4z9x0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=C3sNE7/R3wLoLlTARZrhafNKuUEQMhRiGUVOrVB7ud4=; b=c0BSL31RT2AzxXC9L2IaWHred24VUbHtp1tK+Xv6Qq9+46YLWn1hmbqzaYi5PHENAG skialhA3Evq75ACWCEYtn6g4nkLGAhG4Fcd/wqE9gD06U/Du+gh0bIM5PMjXqzg4c99k ++sE66IL/Cd7lCIUw7cqr7BEQGFtx1TkToHogqV6eqstKAeQUwhTHP3RXtR3ZnzO9QOD wiGpaQGhGmyV9Gt++KF8boshF146mL8rH3Ub6EcTCKSUYjIM0NoLlH98iP33VaIdOND+ 3ofSUP+CrOMif4Iwc+FTqgne6i6iexWloULEydC7iRk48q3wx8sZXMloMEMrZswOuOv1 zMmQ== X-Gm-Message-State: AOAM531e0/fUcwOovFWBLBwXFBLtCDH73rlu0kwEVcGPdDwl2Z46bFGF U2r1sFKxg65O6K1I42s43mKWNKqve00= X-Google-Smtp-Source: ABdhPJxwgJNGMzjMzThYhKk+f8SB/q0ItREKBCFHemVwM08oO7yPIH0PAN4DWnkLcDVbzpHD2fsUHQ== X-Received: by 2002:a19:700b:: with SMTP id h11mr6703302lfc.62.1589081798005; Sat, 09 May 2020 20:36:38 -0700 (PDT) Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com. [209.85.167.45]) by smtp.gmail.com with ESMTPSA id i76sm5916469lfi.83.2020.05.09.20.36.36 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 09 May 2020 20:36:37 -0700 (PDT) Received: by mail-lf1-f45.google.com with SMTP id z22so4602483lfd.0 for ; Sat, 09 May 2020 20:36:36 -0700 (PDT) X-Received: by 2002:a19:6e4e:: with SMTP id q14mr6527170lfk.192.1589081796547; Sat, 09 May 2020 20:36:36 -0700 (PDT) MIME-Version: 1.0 References: <98383cfe-ef17-45f3-a799-9eff8fc0f2fd@kernel.dk> In-Reply-To: <98383cfe-ef17-45f3-a799-9eff8fc0f2fd@kernel.dk> From: Linus Torvalds Date: Sat, 9 May 2020 20:36:20 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL v2] Block fixes for 5.7-rc5 To: Jens Axboe Cc: "linux-block@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Sat, May 9, 2020 at 6:33 PM Jens Axboe wrote: > > Let's try this again... BFQ was missing a header, I fixed that up. The fix looked trivial to me. That wasn't what worries me. Why did you send me something that was clearly NOT TESTED AT ALL. If it hadn't even gotten build-testing, what _did_ it get? The fact that it now builds doesn't make me much happier. Why should I believe that this clearly totally untested pull request is now any good? Why should I believe that your _future_ pull requests are any good, when they clearly have absolutely _zero_ testing at all? Jens, in case you didn't catch on, this is a BIG PROBLEM. Sending me completely untested crap is a bigger deal than "let's just polish the crap until it at least compiles". What have you done to make sure this doesn't happen again? Linus