From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6623FC433EF for ; Tue, 14 Sep 2021 19:05:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F81660EB6 for ; Tue, 14 Sep 2021 19:05:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232521AbhINTGu (ORCPT ); Tue, 14 Sep 2021 15:06:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229658AbhINTGq (ORCPT ); Tue, 14 Sep 2021 15:06:46 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7171CC061574 for ; Tue, 14 Sep 2021 12:05:28 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id s3so468529ljp.11 for ; Tue, 14 Sep 2021 12:05:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jZPcMq2Hb13StlpBoTh3xS6OrGfp+EgulJJy1eLr5r0=; b=XO4ua4Ix1R55uPvvcLfYeENkJdajgMzCMttxK0rirjrnB+uez/EZVDyBwrebVhLEOU uht2FvtVxKXkdSOwRaro4VB6MpfB/URjuBOVq9mpV7XPlwlk7/0O/mPYC/DlDQsDgGjO Nsig2aEerkFFdFomQhYrEgNeddfmTxML3FXVg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jZPcMq2Hb13StlpBoTh3xS6OrGfp+EgulJJy1eLr5r0=; b=hhxrG//MjMVA8p8MNPhdPNY+e6OFlkECq9OMnH2Is5sSa7wShC20/N+tDiIPAj6nH7 R+SKXQe79yVK+kak9xpu0E+FHDmpEQhi46bElvuF2eRGVzzrQma6feIbb4KfPygJLSrq 9Mrt83s7778ifcnSeppTuM/BycRGs0KnbDZIWE1sIy6O2aiP6Q4Y5Gb6VrctsjtRFcnF /PGTGNMi2VxN87VufPYMpa3fRNPX5NI8Zb/ZTK49fs7zrZKVZ7Px0/T1hqu0oIg9/7zR 3DmUoWnf2PENKf8o0+mupT/XgO6tB/6cJubRLbF9cLqVyv+TQAI6z1EhWlqKhKjAa9Mu lAXw== X-Gm-Message-State: AOAM530GPY0Mip+rcPbfdJM/YnoOckirYD786Rtop1mLqA8+qBZz+gcb 5uD/MqVuQt0dO/btTFFs0cwTrnPu4oOH8rUFYFU= X-Google-Smtp-Source: ABdhPJxz2KZNqv6aKZ4lK/5LGRglsIX3D6auDtY7f5qRvJdUgIqe8wd9nlgpvyQ0atMaWwqRBEhtag== X-Received: by 2002:a2e:1510:: with SMTP id s16mr13317708ljd.119.1631646326545; Tue, 14 Sep 2021 12:05:26 -0700 (PDT) Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com. [209.85.208.177]) by smtp.gmail.com with ESMTPSA id b14sm1419580ljr.111.2021.09.14.12.05.25 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Sep 2021 12:05:25 -0700 (PDT) Received: by mail-lj1-f177.google.com with SMTP id h1so490994ljl.9 for ; Tue, 14 Sep 2021 12:05:25 -0700 (PDT) X-Received: by 2002:a05:651c:158e:: with SMTP id h14mr13221321ljq.56.1631646325487; Tue, 14 Sep 2021 12:05:25 -0700 (PDT) MIME-Version: 1.0 References: <20210914105620.677b90e5@oasis.local.home> <20210914145953.189f15dc@oasis.local.home> In-Reply-To: <20210914145953.189f15dc@oasis.local.home> From: Linus Torvalds Date: Tue, 14 Sep 2021 12:05:09 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] tracing: Fixes to bootconfig memory management To: Steven Rostedt Cc: Mike Rapoport , Andrew Morton , LKML , Ingo Molnar , Masami Hiramatsu , Linux-MM , Vlastimil Babka Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 14, 2021 at 12:00 PM Steven Rostedt wrote: > > Note, they do fix a real bug as shown by: > > https://lore.kernel.org/all/e5c7ce5b-93f0-b305-de32-c99d0390eb28@suse.cz/ Ok, can you send me that NULL ptr check as one separate thing? > Should we hold off until mm has fixed this issue? Yeah. That would actually fix the NULL pointer issue too, since a _proper_ memblock_free() would just be a no-op for NULL. That whole "do __pa() on a random pointer to pass it to memblock_free()" is really just complete garbage in _so_ many ways. Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C41C0C433EF for ; Tue, 14 Sep 2021 19:05:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 59D8C60F6D for ; Tue, 14 Sep 2021 19:05:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 59D8C60F6D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id CA60B900002; Tue, 14 Sep 2021 15:05:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C55EF6B0072; Tue, 14 Sep 2021 15:05:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B447A900002; Tue, 14 Sep 2021 15:05:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0021.hostedemail.com [216.40.44.21]) by kanga.kvack.org (Postfix) with ESMTP id A55D76B006C for ; Tue, 14 Sep 2021 15:05:30 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 33ADA2D4D2 for ; Tue, 14 Sep 2021 19:05:30 +0000 (UTC) X-FDA: 78587107620.26.65C2216 Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by imf27.hostedemail.com (Postfix) with ESMTP id D4B13700009B for ; Tue, 14 Sep 2021 19:05:29 +0000 (UTC) Received: by mail-lj1-f170.google.com with SMTP id s12so701779ljg.0 for ; Tue, 14 Sep 2021 12:05:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jZPcMq2Hb13StlpBoTh3xS6OrGfp+EgulJJy1eLr5r0=; b=XO4ua4Ix1R55uPvvcLfYeENkJdajgMzCMttxK0rirjrnB+uez/EZVDyBwrebVhLEOU uht2FvtVxKXkdSOwRaro4VB6MpfB/URjuBOVq9mpV7XPlwlk7/0O/mPYC/DlDQsDgGjO Nsig2aEerkFFdFomQhYrEgNeddfmTxML3FXVg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jZPcMq2Hb13StlpBoTh3xS6OrGfp+EgulJJy1eLr5r0=; b=AFc6OMcHQpecEycfH1hXVywqv4FP4L9cUd/eBXc6Y3sQDO4O4bRxizKJ3Dcky77Gl5 g2kTDja22LlNy6YuDEd+8JNpbq4xofIWg1l9Eid0/Ixy7Dbt4eaYmBHJMgLtLjsR1uH2 JTWwkf09JdglEuFJxO/PGb+HVGTOz3HP6GpjOqpSe5Du1m58YqQ+gh0A2HkV29tJ+czE 7DGirQA4PQik/Axw3zu6zP1s8994VbUBKTlQo47wcGYKJ1cUAs7qOM7Fu/+M3yP7sKDD IwaPsC2vu7g+vAENJfLMyzNTwoAMugSnqeZWHBV2R4m4zqhVCcHHtNKmYDhpXJfzuJj2 y9Xg== X-Gm-Message-State: AOAM530QVNfHSz3Gf83HrPG+Kwjj3zXxx5VLU0Mke5JVtHYpyTLW2Fs7 ZgCnK0XngzCgxUOwSEq64ec3GspVBlIfMdEKLg8= X-Google-Smtp-Source: ABdhPJxLwnkHukRoCsNOiVfZqm/5Xh9GqQf19cB9P2TBNgnxc2og3f5BwBul2kQvpijbil/juWvvgQ== X-Received: by 2002:a2e:5758:: with SMTP id r24mr16845822ljd.432.1631646327479; Tue, 14 Sep 2021 12:05:27 -0700 (PDT) Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com. [209.85.208.169]) by smtp.gmail.com with ESMTPSA id a3sm1431647ljj.122.2021.09.14.12.05.25 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Sep 2021 12:05:26 -0700 (PDT) Received: by mail-lj1-f169.google.com with SMTP id s3so468434ljp.11 for ; Tue, 14 Sep 2021 12:05:25 -0700 (PDT) X-Received: by 2002:a05:651c:158e:: with SMTP id h14mr13221321ljq.56.1631646325487; Tue, 14 Sep 2021 12:05:25 -0700 (PDT) MIME-Version: 1.0 References: <20210914105620.677b90e5@oasis.local.home> <20210914145953.189f15dc@oasis.local.home> In-Reply-To: <20210914145953.189f15dc@oasis.local.home> From: Linus Torvalds Date: Tue, 14 Sep 2021 12:05:09 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] tracing: Fixes to bootconfig memory management To: Steven Rostedt Cc: Mike Rapoport , Andrew Morton , LKML , Ingo Molnar , Masami Hiramatsu , Linux-MM , Vlastimil Babka Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: D4B13700009B Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=XO4ua4Ix; dmarc=none; spf=pass (imf27.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.170 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org X-Stat-Signature: nf939a7hjcctf58o45bx5dd6bww9di1h X-HE-Tag: 1631646329-736231 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 14, 2021 at 12:00 PM Steven Rostedt wrote: > > Note, they do fix a real bug as shown by: > > https://lore.kernel.org/all/e5c7ce5b-93f0-b305-de32-c99d0390eb28@suse.cz/ Ok, can you send me that NULL ptr check as one separate thing? > Should we hold off until mm has fixed this issue? Yeah. That would actually fix the NULL pointer issue too, since a _proper_ memblock_free() would just be a no-op for NULL. That whole "do __pa() on a random pointer to pass it to memblock_free()" is really just complete garbage in _so_ many ways. Linus