From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D607AC34026 for ; Tue, 18 Feb 2020 18:49:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AD31221D56 for ; Tue, 18 Feb 2020 18:49:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582051791; bh=ABB2dablGvaPDjMOY3/xeFSCMH42Xg9ft9gGuhUQo7A=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=DVwvciH/8T/vuCN26mT5ncc8Qv+9wMFlWuXJQuscbRBZ++7ropDk6mxLTu+nrR8N8 9KvjGYFuW4BNW+Wk9hraed5J+N0jqtcvxu4WX4G9Ut1UbhizvLko5PE7+gl32bx1vs 9NSE3V2Ea99La6WJUSjFfGeqGPpwJUiEddQXpz3U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726548AbgBRStu (ORCPT ); Tue, 18 Feb 2020 13:49:50 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:34398 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726283AbgBRStu (ORCPT ); Tue, 18 Feb 2020 13:49:50 -0500 Received: by mail-lj1-f193.google.com with SMTP id x7so24202108ljc.1 for ; Tue, 18 Feb 2020 10:49:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=K/hRoOXddpf2rg3/iA7HHccAIzHUJB1ObxyUSqAalTY=; b=NZzRuV1ykVa1MAKkVAJ+ayE7uc4yeKrTUPiopFgzMVSDworqehvv6s1IVq73p/Olth xB/LLOUygDjmABRDoAr27sggaJdlNl63J92LiGLxnz84PmCA5tETqhf2S1Vm6zwMxzef 51K5GQq09q/p65UvpTOXQtxzKGwp4nzMgihRw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=K/hRoOXddpf2rg3/iA7HHccAIzHUJB1ObxyUSqAalTY=; b=mXqdSYO41WXp95tP87/gWrsKY/dxrS4UKtqLJ/fHLfedOCcsfkw7LcRRkRb/OKn30j dyd85ILsrtJ8WBX5uG6OpHiUJPGVNKE8j+C3IrPN1eeitHjGJ21OV+TL2Z8jAIRzSg+n EVeCeJCD+lSJgKYdEVdoXosVNCBD5fMIDQbVCk2iX0H6Z67FsPmzKqMn6IVbDW7pKKzp wCLvsYqgeFX6S4HAzjjRGq9hWHjWnYLOulLN9iXZ6EuYPay2Es8Z/2VZDVSXHDNLGyQ+ /Je2WzCC/NZw9LriYZxoLG+8PdMjarxoeCjwkp2kns3ylPNuLJiLEcN5/niOeKCCNzm3 k4Iw== X-Gm-Message-State: APjAAAXYVwc/zAx+DNGLM2L1wOFbyeQYaWNlDdetANr42xaefRvKHY6F gG9PbFdApW9pYBjSc8z1KxogMx2qj18= X-Google-Smtp-Source: APXvYqwXRngoRyq0/lTKFLS989+5zDvvt5iK6aiy6+ZC34wSmGAFy0OiRa1RYDsAuBaAEpm9YueEIw== X-Received: by 2002:a2e:8e2a:: with SMTP id r10mr12999821ljk.219.1582051787803; Tue, 18 Feb 2020 10:49:47 -0800 (PST) Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com. [209.85.167.41]) by smtp.gmail.com with ESMTPSA id u15sm2697831lfl.87.2020.02.18.10.49.46 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Feb 2020 10:49:47 -0800 (PST) Received: by mail-lf1-f41.google.com with SMTP id f24so15290809lfh.3 for ; Tue, 18 Feb 2020 10:49:46 -0800 (PST) X-Received: by 2002:ac2:4839:: with SMTP id 25mr10897394lft.192.1582051786457; Tue, 18 Feb 2020 10:49:46 -0800 (PST) MIME-Version: 1.0 References: <20200217222803.6723-1-idryomov@gmail.com> <202002171546.A291F23F12@keescook> In-Reply-To: From: Linus Torvalds Date: Tue, 18 Feb 2020 10:49:30 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] vsprintf: don't obfuscate NULL and error pointers To: Ilya Dryomov Cc: Kees Cook , LKML , Petr Mladek , Steven Rostedt , Randy Dunlap , Sergey Senozhatsky , "Tobin C . Harding" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 17, 2020 at 4:07 PM Ilya Dryomov wrote: > > I'm not sure what you mean by efault string. Are you referring to what > %pe is doing? If so, no -- I would keep %p and %pe separate. Right. But bringing up %pe makes me realize that we do odd things for NULL for that. We print errors in a nice legible form, but we show NULL as a zero value, I think. So maybe %pe should show NULL as "(null)"? Or even as just "0" to go with the error names that just look like the integer error syntax (eg "-EINVAL") Linus