From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E46B2C433FE for ; Tue, 14 Sep 2021 15:41:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CDE5E6044F for ; Tue, 14 Sep 2021 15:41:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234771AbhINPmx (ORCPT ); Tue, 14 Sep 2021 11:42:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231966AbhINPmw (ORCPT ); Tue, 14 Sep 2021 11:42:52 -0400 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 897E1C061574 for ; Tue, 14 Sep 2021 08:41:34 -0700 (PDT) Received: by mail-lj1-x235.google.com with SMTP id y6so24775840lje.2 for ; Tue, 14 Sep 2021 08:41:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dgZDRvewpIcHvEl+aClDgx6dxTBkhTg+5FlC2P6kQVc=; b=BpcuMcoHH1B5L3A9rysqIc0UNfq5noiLE14zKeR1TSa0gFC85lOw2Beo8dO5honWby rYyCHFnHkKNi7MCpw7JrIjMcXxBeTw1cz/rDSABmNfOTKR6Ymn6YfZNGpWuykLc9dauc iTDBkLKWwlR9RhIlCft6lceQmUvWAku/ar3t0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dgZDRvewpIcHvEl+aClDgx6dxTBkhTg+5FlC2P6kQVc=; b=Wy+d4ay4dVoQffr09pRGZ3sB/W1QA6GdMYMAruL0unEYHo96LuXXfoYk6j0Gab8Sat HflqESjlADV/iNvhpIt/woGlCZALVsvnI/6GP2QmUUsUJJXUvCdmrblJqPP6K7At1t9U FFjs8ViH62w0cb9wceZnnrZThv9ChRugMjTt87s4k4l4coFZjgxjBLxNaM37qNaPStYB HXszvKPiXek0N1a6BkdPF67ZwfHcf9Fe+3FLAQGSqTFep9MMqwQQ//jcef03p3CQytRJ rrNsNqeZ7WLhR7oEeG+JANBsrKal1BaUzNcfh1T6rgE1wB5gGDuPXrGAwdASYx3/AkUf qwRw== X-Gm-Message-State: AOAM530d3fjthqwsUcVoFy88xyffj+lZZFG42bokACT34q4FlNzYRLHO IIE+vIx/rQgNPVzQfQ0W1sXnkFENnMKC/tIlAfQ= X-Google-Smtp-Source: ABdhPJxOE9d4t4G2YyxXcbIq0vpA6tHO5ggPDX3jZSUwpsGtTe3CiUfsJ/IlIpMG/4efxByiCsWIaw== X-Received: by 2002:a2e:97cb:: with SMTP id m11mr16267031ljj.240.1631634091876; Tue, 14 Sep 2021 08:41:31 -0700 (PDT) Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com. [209.85.208.171]) by smtp.gmail.com with ESMTPSA id d7sm878420lfn.27.2021.09.14.08.41.29 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Sep 2021 08:41:30 -0700 (PDT) Received: by mail-lj1-f171.google.com with SMTP id r3so24760310ljc.4 for ; Tue, 14 Sep 2021 08:41:29 -0700 (PDT) X-Received: by 2002:a2e:a7d0:: with SMTP id x16mr15637818ljp.494.1631634089537; Tue, 14 Sep 2021 08:41:29 -0700 (PDT) MIME-Version: 1.0 References: <20210914121036.3975026-1-ardb@kernel.org> <20210914121036.3975026-2-ardb@kernel.org> In-Reply-To: <20210914121036.3975026-2-ardb@kernel.org> From: Linus Torvalds Date: Tue, 14 Sep 2021 08:41:13 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH 1/8] arm64: add CPU field to struct thread_info To: Ard Biesheuvel Cc: Linux Kernel Mailing List , Keith Packard , Russell King , Catalin Marinas , Will Deacon , Michael Ellerman , Benjamin Herrenschmidt , Christophe Leroy , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Peter Zijlstra , Kees Cook , Andy Lutomirski , Arnd Bergmann , Linux ARM , linuxppc-dev , linux-riscv , linux-s390 Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 14, 2021 at 5:10 AM Ard Biesheuvel wrote: > > The CPU field will be moved back into thread_info even when > THREAD_INFO_IN_TASK is enabled, so add it back to arm64's definition of > struct thread_info. The series looks sane to me, but it strikes me that it's inconsistent - here for arm64, you make it unconditional, but for the other architectures you end up putting it inside a #ifdef CONFIG_SMP. Was there some reason for this odd behavior? Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D3A9C433EF for ; Tue, 14 Sep 2021 15:42:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F332761056 for ; Tue, 14 Sep 2021 15:42:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F332761056 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zPHDtWBcYu40dXSz+YgR5Mm6I39iUCKzG1wNzzrxS/s=; b=L3L8THnLym3zH1 i2h7scM4MZx9ncWeDg33aZARFqBrUrKM2UWdCUVJNj7Oi+TE6GYxbR5omPMxzMLYBqx7+65PDiWqz vwdQA48qoQgbwSeUWJU2TbKNI1gsAjPWv6ExWM7yTyWZmSDoZn8m0ydHgten38leXmCi453qVDLWM BFa0lEmijZNSc+UfSF75OBwMsSAMTmHjwgWZaV6xITHsWw3WiYm4wKGsvSi9RiIB/yvaanMAgoIPJ lRnJBA8Vrr/+wa4gTIupddlfp8Enk5BDUddrCgtaY2MYdlk0fQOSYp10VTlAyGfpRxAMaV9/JD8Am vFyc/ERX+RlMG/x0ZEEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQAZJ-006FHr-U8; Tue, 14 Sep 2021 15:41:57 +0000 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQAZ6-006FFz-BO for linux-riscv@lists.infradead.org; Tue, 14 Sep 2021 15:41:45 +0000 Received: by mail-lf1-x12e.google.com with SMTP id a4so29767192lfg.8 for ; Tue, 14 Sep 2021 08:41:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dgZDRvewpIcHvEl+aClDgx6dxTBkhTg+5FlC2P6kQVc=; b=BpcuMcoHH1B5L3A9rysqIc0UNfq5noiLE14zKeR1TSa0gFC85lOw2Beo8dO5honWby rYyCHFnHkKNi7MCpw7JrIjMcXxBeTw1cz/rDSABmNfOTKR6Ymn6YfZNGpWuykLc9dauc iTDBkLKWwlR9RhIlCft6lceQmUvWAku/ar3t0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dgZDRvewpIcHvEl+aClDgx6dxTBkhTg+5FlC2P6kQVc=; b=tJar2GvSKE8S44ZlCQNVaFd8k6y52UvN0C9qc5bIvIht0u3/YFzU+Vsc1Tb8J+HCU1 HpfoHcCa43xBbiz3xRKoiqlL5E0fuR0++vSbM7qNR47XLXPEvPegkECC4kbNe+Of0IJ3 pMiTMWHQs/drydqUQgwo4cCkTFvG9GoQmz/THlOSyByQ4uR1x24S3yYE/VL/wU8wXYFk ByYA0YOWj93qrtJeb077DrisbN73E2Oz240QT4Xf58qqmfMMSzI5zZz875iBzfBmbMN9 yr46EJKL6CsThqvucrZGSLflSZwg2FOr5ZolCVnX0oMEHbYyDLPSeC9SYgUi7qld4PfX eY+w== X-Gm-Message-State: AOAM532aizEmglUhAutOJ8kEsOXvpy1oROqvXTXaYBC9Yo+kowSipyfZ BDTmD3yV7Qrh5ktnJ03WsI5uv33Rf3G8WTYf9OY= X-Google-Smtp-Source: ABdhPJyaDPqyf47Mq/Zk7md50EBm0iI+RwUPzZt6D0px2E7AXAKRcEgN4oU8m3CTwBmxT0zmpy2pzA== X-Received: by 2002:ac2:4466:: with SMTP id y6mr8949293lfl.17.1631634102292; Tue, 14 Sep 2021 08:41:42 -0700 (PDT) Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com. [209.85.167.52]) by smtp.gmail.com with ESMTPSA id c8sm1149986lfb.229.2021.09.14.08.41.40 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Sep 2021 08:41:42 -0700 (PDT) Received: by mail-lf1-f52.google.com with SMTP id i7so13600015lfr.13 for ; Tue, 14 Sep 2021 08:41:40 -0700 (PDT) X-Received: by 2002:a2e:a7d0:: with SMTP id x16mr15637818ljp.494.1631634089537; Tue, 14 Sep 2021 08:41:29 -0700 (PDT) MIME-Version: 1.0 References: <20210914121036.3975026-1-ardb@kernel.org> <20210914121036.3975026-2-ardb@kernel.org> In-Reply-To: <20210914121036.3975026-2-ardb@kernel.org> From: Linus Torvalds Date: Tue, 14 Sep 2021 08:41:13 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH 1/8] arm64: add CPU field to struct thread_info To: Ard Biesheuvel Cc: Linux Kernel Mailing List , Keith Packard , Russell King , Catalin Marinas , Will Deacon , Michael Ellerman , Benjamin Herrenschmidt , Christophe Leroy , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Peter Zijlstra , Kees Cook , Andy Lutomirski , Arnd Bergmann , Linux ARM , linuxppc-dev , linux-riscv , linux-s390 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210914_084144_429142_BE530DCA X-CRM114-Status: GOOD ( 13.22 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Tue, Sep 14, 2021 at 5:10 AM Ard Biesheuvel wrote: > > The CPU field will be moved back into thread_info even when > THREAD_INFO_IN_TASK is enabled, so add it back to arm64's definition of > struct thread_info. The series looks sane to me, but it strikes me that it's inconsistent - here for arm64, you make it unconditional, but for the other architectures you end up putting it inside a #ifdef CONFIG_SMP. Was there some reason for this odd behavior? Linus _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A56BC433F5 for ; Tue, 14 Sep 2021 15:42:28 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4479561056 for ; Tue, 14 Sep 2021 15:42:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4479561056 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4H86zj5PqWz304y for ; Wed, 15 Sep 2021 01:42:25 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linux-foundation.org header.i=@linux-foundation.org header.a=rsa-sha256 header.s=google header.b=BpcuMcoH; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linuxfoundation.org (client-ip=2a00:1450:4864:20::62e; helo=mail-ej1-x62e.google.com; envelope-from=torvalds@linuxfoundation.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linux-foundation.org header.i=@linux-foundation.org header.a=rsa-sha256 header.s=google header.b=BpcuMcoH; dkim-atps=neutral Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4H86yy4tcTz2xtY for ; Wed, 15 Sep 2021 01:41:44 +1000 (AEST) Received: by mail-ej1-x62e.google.com with SMTP id h9so29973768ejs.4 for ; Tue, 14 Sep 2021 08:41:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dgZDRvewpIcHvEl+aClDgx6dxTBkhTg+5FlC2P6kQVc=; b=BpcuMcoHH1B5L3A9rysqIc0UNfq5noiLE14zKeR1TSa0gFC85lOw2Beo8dO5honWby rYyCHFnHkKNi7MCpw7JrIjMcXxBeTw1cz/rDSABmNfOTKR6Ymn6YfZNGpWuykLc9dauc iTDBkLKWwlR9RhIlCft6lceQmUvWAku/ar3t0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dgZDRvewpIcHvEl+aClDgx6dxTBkhTg+5FlC2P6kQVc=; b=Njdrbf7Wws2K149bl/PvGOWp6+/DJNWNwPWPv5yJ+ZnNOkEPjEvWXngOt9k2QQtbUC NiOgOuvoeIrhFk4GeptUpPkJJaeib67N4/Qg0rhOaXQ532y72jVp+K0Luz+0cArIBi12 uxhW1NY/KMRFbIeRbRTx1yoU91UNDAqDRKA6P5gE6q5/dss7x8ChRI7ZDhye/KsepGIO YTf4bY7KhmzEv/PU4b+V4WdKui3+IopRZx784/zLnb26oQMmknM2nagvD6TwBhJHM69k IEBfOTQBB84m/t8JbSMe5wstHHVi5QnEkVQyS5sIf2Mj9gDxm1K5rnkviRn1AsNh+2sK G1xQ== X-Gm-Message-State: AOAM532Mn/58DVne1JGZFkIdRNnpv2rG1bgvwVp+YxvJC8TFu0Hua315 FFE2ng1YSJtI5hPgY6M7+6eP9PobscUNdkNr/zg= X-Google-Smtp-Source: ABdhPJwVfdD4m+M1wMk4bm/HHDGtbpoVYC1UCvEl5zgBULVkO95x5J4tDNLnUTGeGyvPQCcQVYr+wQ== X-Received: by 2002:a17:906:a195:: with SMTP id s21mr18902959ejy.181.1631634100303; Tue, 14 Sep 2021 08:41:40 -0700 (PDT) Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com. [209.85.218.43]) by smtp.gmail.com with ESMTPSA id gx4sm3781077ejb.116.2021.09.14.08.41.39 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Sep 2021 08:41:39 -0700 (PDT) Received: by mail-ej1-f43.google.com with SMTP id kt8so29907989ejb.13 for ; Tue, 14 Sep 2021 08:41:39 -0700 (PDT) X-Received: by 2002:a2e:a7d0:: with SMTP id x16mr15637818ljp.494.1631634089537; Tue, 14 Sep 2021 08:41:29 -0700 (PDT) MIME-Version: 1.0 References: <20210914121036.3975026-1-ardb@kernel.org> <20210914121036.3975026-2-ardb@kernel.org> In-Reply-To: <20210914121036.3975026-2-ardb@kernel.org> From: Linus Torvalds Date: Tue, 14 Sep 2021 08:41:13 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH 1/8] arm64: add CPU field to struct thread_info To: Ard Biesheuvel Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Zijlstra , Paul Mackerras , linux-riscv , Will Deacon , linux-s390 , Arnd Bergmann , Russell King , Christian Borntraeger , Ingo Molnar , Catalin Marinas , Albert Ou , Kees Cook , Vasily Gorbik , Heiko Carstens , Keith Packard , Borislav Petkov , Andy Lutomirski , Paul Walmsley , Thomas Gleixner , Linux ARM , Linux Kernel Mailing List , Palmer Dabbelt , linuxppc-dev Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Sep 14, 2021 at 5:10 AM Ard Biesheuvel wrote: > > The CPU field will be moved back into thread_info even when > THREAD_INFO_IN_TASK is enabled, so add it back to arm64's definition of > struct thread_info. The series looks sane to me, but it strikes me that it's inconsistent - here for arm64, you make it unconditional, but for the other architectures you end up putting it inside a #ifdef CONFIG_SMP. Was there some reason for this odd behavior? Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EECBDC433F5 for ; Tue, 14 Sep 2021 15:44:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A9AB76113E for ; Tue, 14 Sep 2021 15:44:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A9AB76113E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=w50VY5CpTY1qPa2epSGBSAUohEvWfQAxVhYEqQrXLkQ=; b=ZrRaO7XhW7SXj/ 2JY70eqsqPt+jeOwSecn6uH4fS2kf/1+tSdZ4UC0tAwzPINT59ArhecvIChtk8RQ4jLVVcMpIdO9D selKHE0xnH7US0VVY+vmURsERPJ5X3F/45MDkXe1t7iTL71vDOSx6H6ZWnU8uBqns/bYax/UIXg7y y8aqp6UMZwAOnsA8W+5eHnUmWBk7z0Ta6bi+I+K6qn/tWEAjHKqC+pNIhS9lxpEG8QoG2QLI6aGGL jp6BbJeM6PGFReSZ0+G+SfdBiszZjhqDjAsgd4j7oYikxswyt403r79x4Ls1+HXc0rkCoBwgiyuz0 jqzsO87kJNMCWriBZtfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQAZA-006FH1-93; Tue, 14 Sep 2021 15:41:48 +0000 Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQAZ6-006FFr-9q for linux-arm-kernel@lists.infradead.org; Tue, 14 Sep 2021 15:41:45 +0000 Received: by mail-lf1-x136.google.com with SMTP id p29so2857002lfa.11 for ; Tue, 14 Sep 2021 08:41:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dgZDRvewpIcHvEl+aClDgx6dxTBkhTg+5FlC2P6kQVc=; b=BpcuMcoHH1B5L3A9rysqIc0UNfq5noiLE14zKeR1TSa0gFC85lOw2Beo8dO5honWby rYyCHFnHkKNi7MCpw7JrIjMcXxBeTw1cz/rDSABmNfOTKR6Ymn6YfZNGpWuykLc9dauc iTDBkLKWwlR9RhIlCft6lceQmUvWAku/ar3t0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dgZDRvewpIcHvEl+aClDgx6dxTBkhTg+5FlC2P6kQVc=; b=dd30OckTExXBpMoTBdE4TjkV6U2mXxfnpjcwHVSMV4za29LWv+qUHwOUiQxehUN+Ft GxQPyFrqeuf6IGggZaobbsz/9Q+qcY3Jod+L9mif1QRJI2yXsh9wfDD8PU2dTAZ//4+1 nMybOK7Jb8ulLdwM756UXijxZV+4MnFWszMkKTufi3ybmSjNkY1R5Js1mi8qpKggd5Aw ke5K6a5vzDklarEqx1qB1KlDx47p69VVAvN9YzV3raDcOiqPVHJ1VTgYA+/zxQP4PGkz C3gtHACSCntXlmw1kGSmSmeJb55eAhqK9WM7x7zQU+nXPOIhWKgB1CvRcZIr53V/hg++ +ARQ== X-Gm-Message-State: AOAM531QjjKMA32ugj7KlLn0QipZI0Q8i5hx+ordkKJ1NvWckvafSUJ6 YFQC5ETj+PB5mFOG0wA4CTh80fLu8JCUr8C0qZw= X-Google-Smtp-Source: ABdhPJz5GnGgHwfOXT1PnUtpux5h9CgvnksKpNL3wax0jeyLnRlLNnUGG4/vaj6GVJ/Bes00iePwnw== X-Received: by 2002:ac2:5fe1:: with SMTP id s1mr13939314lfg.166.1631634102156; Tue, 14 Sep 2021 08:41:42 -0700 (PDT) Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com. [209.85.208.173]) by smtp.gmail.com with ESMTPSA id q15sm1153971lfg.277.2021.09.14.08.41.40 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Sep 2021 08:41:41 -0700 (PDT) Received: by mail-lj1-f173.google.com with SMTP id r3so24761375ljc.4 for ; Tue, 14 Sep 2021 08:41:40 -0700 (PDT) X-Received: by 2002:a2e:a7d0:: with SMTP id x16mr15637818ljp.494.1631634089537; Tue, 14 Sep 2021 08:41:29 -0700 (PDT) MIME-Version: 1.0 References: <20210914121036.3975026-1-ardb@kernel.org> <20210914121036.3975026-2-ardb@kernel.org> In-Reply-To: <20210914121036.3975026-2-ardb@kernel.org> From: Linus Torvalds Date: Tue, 14 Sep 2021 08:41:13 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH 1/8] arm64: add CPU field to struct thread_info To: Ard Biesheuvel Cc: Linux Kernel Mailing List , Keith Packard , Russell King , Catalin Marinas , Will Deacon , Michael Ellerman , Benjamin Herrenschmidt , Christophe Leroy , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Peter Zijlstra , Kees Cook , Andy Lutomirski , Arnd Bergmann , Linux ARM , linuxppc-dev , linux-riscv , linux-s390 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210914_084144_411573_E3212C43 X-CRM114-Status: GOOD ( 14.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 14, 2021 at 5:10 AM Ard Biesheuvel wrote: > > The CPU field will be moved back into thread_info even when > THREAD_INFO_IN_TASK is enabled, so add it back to arm64's definition of > struct thread_info. The series looks sane to me, but it strikes me that it's inconsistent - here for arm64, you make it unconditional, but for the other architectures you end up putting it inside a #ifdef CONFIG_SMP. Was there some reason for this odd behavior? Linus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel