From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79A39C433E0 for ; Thu, 25 Feb 2021 01:52:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 35DCD64E85 for ; Thu, 25 Feb 2021 01:52:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235210AbhBYBwr (ORCPT ); Wed, 24 Feb 2021 20:52:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235198AbhBYBwr (ORCPT ); Wed, 24 Feb 2021 20:52:47 -0500 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 169C5C061574 for ; Wed, 24 Feb 2021 17:52:07 -0800 (PST) Received: by mail-lf1-x129.google.com with SMTP id j19so6081338lfr.12 for ; Wed, 24 Feb 2021 17:52:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nuEwacw9WQYf7hqKeQHh+UiK1mAkKdfy2q7SV6e4fgo=; b=USn4m91gCrg/tHu49UfSsfjmTB5sGx2Y/Mtg72X4FUydasLo+OTlGYtBumcw24QK52 iaMJjwti2qOaGaWqVhmk1vsoV8PXgnL9GlhOEYhf9s50YfZeyNHcr7vKVxBD/iz89qtj PyQOxUTIsPB0qvjfHbOnJlGUmyDQIXUMsHtlM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nuEwacw9WQYf7hqKeQHh+UiK1mAkKdfy2q7SV6e4fgo=; b=BBZz6KozapikMUyP9NiH20Rrjndb6FIZOhSSmSE92LrYElWaDSN9W3MD9n0CXYMTbT 0v9psM9iugr/+VzZb+G4WChBmtUxGZl9ExA23v2XSx9imSyzHYrztv2GIE9Tyjk7vR4W Zill7T0DF8ZllhVUKPcm0+Jhj6I3y0PWRfTbXK/xA8osgU+7I7v12BWOuHjWpxVmboJW hHx+cD9RROI/bS7yl1GC60+DZrZiArP/FeUGcmx08ZHoztePqXkNEHiUXMBHZLh5IPbf GqxmOTdyMhR0y8ekNxc+hgit1qrImLLhqDpcM82Zv0DROlp5Iw6CypHlZPEwKlya72t6 yntQ== X-Gm-Message-State: AOAM533b+rvzwFUChPPrVL/e8K0obUb/KgSyXT1sRgKmiZYaqBwzn88t 5Hf5MiQ3ZyYY4oaMkFGI9ule3NIsUpcm7w== X-Google-Smtp-Source: ABdhPJwRbzqSq62vcxbcV8S2VPN9KgtRwtKvKc2AdvW7M2mHhmmsd/lmFDDe5s6MjRgDZ2SKcoUHmw== X-Received: by 2002:ac2:5184:: with SMTP id u4mr460764lfi.487.1614217924338; Wed, 24 Feb 2021 17:52:04 -0800 (PST) Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com. [209.85.167.45]) by smtp.gmail.com with ESMTPSA id p9sm526188ljn.16.2021.02.24.17.52.03 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Feb 2021 17:52:03 -0800 (PST) Received: by mail-lf1-f45.google.com with SMTP id u4so6173273lfs.0 for ; Wed, 24 Feb 2021 17:52:03 -0800 (PST) X-Received: by 2002:a19:8186:: with SMTP id c128mr459588lfd.377.1614217922822; Wed, 24 Feb 2021 17:52:02 -0800 (PST) MIME-Version: 1.0 References: <20210224115824.1e289a6895087f10c41dd8d6@linux-foundation.org> <20210224200055.U7Xz47kX5%akpm@linux-foundation.org> <20210224203708.4489755a@oasis.local.home> In-Reply-To: <20210224203708.4489755a@oasis.local.home> From: Linus Torvalds Date: Wed, 24 Feb 2021 17:51:46 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [patch 014/173] mm, tracing: record slab name for kmem_cache_free() To: Steven Rostedt Cc: Andrew Morton , Christoph Lameter , Joonsoo Kim , jian.w.wen@oracle.com, Linux-MM , mm-commits@vger.kernel.org, Paul McKenney , Pekka Enberg , David Rientjes Content-Type: text/plain; charset="UTF-8" Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org On Wed, Feb 24, 2021 at 5:37 PM Steven Rostedt wrote: > > Please do not apply this patch as is, it is very buggy! Sadly, it's already there and pushed out. I try to wait a few hours (sometimes overnight) with Andrew's series before pushing things out in order to catch comments like this, but this one came too late. I can obviously revert, but if the fix is the two-liner you outlined, perhaps that is better? Mind sending it as a patch (or just putting it in your tracing tree)? Or Jacob? A tested patch along the lines that Steven outlined? Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 440B4C433DB for ; Thu, 25 Feb 2021 01:52:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A38B364E7A for ; Thu, 25 Feb 2021 01:52:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A38B364E7A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D11B96B0006; Wed, 24 Feb 2021 20:52:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CC1526B006C; Wed, 24 Feb 2021 20:52:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB00D6B006E; Wed, 24 Feb 2021 20:52:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0219.hostedemail.com [216.40.44.219]) by kanga.kvack.org (Postfix) with ESMTP id A2D646B0006 for ; Wed, 24 Feb 2021 20:52:07 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 6E2AAD235 for ; Thu, 25 Feb 2021 01:52:07 +0000 (UTC) X-FDA: 77855114694.12.6C60F0E Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) by imf21.hostedemail.com (Postfix) with ESMTP id 93B67E0011E1 for ; Thu, 25 Feb 2021 01:52:03 +0000 (UTC) Received: by mail-lf1-f44.google.com with SMTP id u4so6173369lfs.0 for ; Wed, 24 Feb 2021 17:52:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nuEwacw9WQYf7hqKeQHh+UiK1mAkKdfy2q7SV6e4fgo=; b=USn4m91gCrg/tHu49UfSsfjmTB5sGx2Y/Mtg72X4FUydasLo+OTlGYtBumcw24QK52 iaMJjwti2qOaGaWqVhmk1vsoV8PXgnL9GlhOEYhf9s50YfZeyNHcr7vKVxBD/iz89qtj PyQOxUTIsPB0qvjfHbOnJlGUmyDQIXUMsHtlM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nuEwacw9WQYf7hqKeQHh+UiK1mAkKdfy2q7SV6e4fgo=; b=ZnhtE+QsfQWPSOzZX59c6hbj5IKF4m7cvo2+ZQFH+BJVU3gWbdd5nhIv/bUI4i87j0 PelB1+LYRjYmJC3DBbBh2rZ+uXA8zLhJ1jieUEK5VahKbBNKUAHebIFayDYIB1CT6SOR skVDX25DvVBgg4eCokS07JFmxuUZ6nfzMRPFtzrb76ZT1LlbrE75Vsf2ac27lFInYSNo 1Hc8fyTWtUypwprWRTN8vrb86wTtbUgG/rx+u82NRWGEQ6oFOnqYxHSMnALbawoilGkH pv6eL+Oq9i4C/5NiyfpGww9RkfAv2g6D1UfB5rD7/bPFkC+4BizABNKV7tpQJzl6my9E BkvA== X-Gm-Message-State: AOAM533SJRKpXyjsOj6QLsa5EbBtIc96U6sdjxmrp0nBMtNaY+aOsuq0 Pw0pLO6lMcPeH9K6HmmdJ37qt3oTMeCXug== X-Google-Smtp-Source: ABdhPJwZYtwp67sghu4ACdhORKAtfEmqSBZtXbSO01o/FKPE4RoubXy4dIgZBmFkT7J/DQ0zTfl4iQ== X-Received: by 2002:ac2:4857:: with SMTP id 23mr498280lfy.136.1614217924480; Wed, 24 Feb 2021 17:52:04 -0800 (PST) Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com. [209.85.167.43]) by smtp.gmail.com with ESMTPSA id o66sm828808lfa.192.2021.02.24.17.52.03 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Feb 2021 17:52:03 -0800 (PST) Received: by mail-lf1-f43.google.com with SMTP id p21so6098905lfu.11 for ; Wed, 24 Feb 2021 17:52:03 -0800 (PST) X-Received: by 2002:a19:8186:: with SMTP id c128mr459588lfd.377.1614217922822; Wed, 24 Feb 2021 17:52:02 -0800 (PST) MIME-Version: 1.0 References: <20210224115824.1e289a6895087f10c41dd8d6@linux-foundation.org> <20210224200055.U7Xz47kX5%akpm@linux-foundation.org> <20210224203708.4489755a@oasis.local.home> In-Reply-To: <20210224203708.4489755a@oasis.local.home> From: Linus Torvalds Date: Wed, 24 Feb 2021 17:51:46 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [patch 014/173] mm, tracing: record slab name for kmem_cache_free() To: Steven Rostedt Cc: Andrew Morton , Christoph Lameter , Joonsoo Kim , jian.w.wen@oracle.com, Linux-MM , mm-commits@vger.kernel.org, Paul McKenney , Pekka Enberg , David Rientjes Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: q9n1kxeu51ee4qb4n9yuz39e7e9ufbt7 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 93B67E0011E1 Received-SPF: none (linuxfoundation.org>: No applicable sender policy available) receiver=imf21; identity=mailfrom; envelope-from=""; helo=mail-lf1-f44.google.com; client-ip=209.85.167.44 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614217923-585251 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 24, 2021 at 5:37 PM Steven Rostedt wrote: > > Please do not apply this patch as is, it is very buggy! Sadly, it's already there and pushed out. I try to wait a few hours (sometimes overnight) with Andrew's series before pushing things out in order to catch comments like this, but this one came too late. I can obviously revert, but if the fix is the two-liner you outlined, perhaps that is better? Mind sending it as a patch (or just putting it in your tracing tree)? Or Jacob? A tested patch along the lines that Steven outlined? Linus