From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3081C47E48 for ; Wed, 14 Jul 2021 19:04:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D48D8613AB for ; Wed, 14 Jul 2021 19:04:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229557AbhGNTHZ (ORCPT ); Wed, 14 Jul 2021 15:07:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240060AbhGNTHW (ORCPT ); Wed, 14 Jul 2021 15:07:22 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D408C061760 for ; Wed, 14 Jul 2021 12:04:30 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id i5so5434724lfe.2 for ; Wed, 14 Jul 2021 12:04:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5qboNP9wECqxtAQPwi4Gka7E9oHhS1YQMu+Q8JxA7ak=; b=glh504o9Z7GfM84TfN6a9e1MVve+NDS52G62Hq+T8wU2hET7iB2/LaVZ85dbskzDgh yAhIlfeW60S6JOo6yc3CQ/IrfJT+6DnE98rLe7dMWar89uMeZPDVQtzoII2b3yZofc4W nDIrMzgD5EdLgxaeyj2u+vGDFkWBSBw0uXR4E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5qboNP9wECqxtAQPwi4Gka7E9oHhS1YQMu+Q8JxA7ak=; b=QTZLTCddkD6aLF0nk3H3o50Sbx293qBKiRCsr+Slpg/9r+6WU/n7x5vrNsECoHFiX2 I9IlzzUANx54NNqYiItLbJ/c46bnUYHITXtt1PiIig8rkor92aC0wMzk8c0bIsYM7w8L beXv1AxZtHOpx6CzoapLTTlXU3ekUFmkHzgPZeMKPrX/H+VOMdyL8gSfSgPEVdsP2Mrx L+Oc+Fe6t/pnIQy0gCwSQHuVgvVx/t4XVyT5Gupak3pbiuhrZRdKLanCI+7x0d/2sd6A J+IHoTAakeuQhbzRDniasB2Z2f5p6980Uw7GrpkceciCxxeKMBtn51op7qEujEjeSTGp AHDQ== X-Gm-Message-State: AOAM532Mpb/jpA3e4cUc4gms4f1xhvTtiOKx1StLHmpCxudWRaLA7qkV 7hhC/REglUMc8x6UMF2+q4hHs1Bpgx+K3gLC X-Google-Smtp-Source: ABdhPJwTWSeQs6KVFTM65LEPP5aNPHUIVpQo/8jJEDuQQwH6D00Na53KEaUm+1IGLkuqbO48YfRIFg== X-Received: by 2002:a05:6512:3a7:: with SMTP id v7mr9281882lfp.127.1626289468022; Wed, 14 Jul 2021 12:04:28 -0700 (PDT) Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com. [209.85.208.171]) by smtp.gmail.com with ESMTPSA id r11sm353449ljp.9.2021.07.14.12.04.24 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Jul 2021 12:04:24 -0700 (PDT) Received: by mail-lj1-f171.google.com with SMTP id h4so3729325ljo.6 for ; Wed, 14 Jul 2021 12:04:24 -0700 (PDT) X-Received: by 2002:a05:651c:1798:: with SMTP id bn24mr10307687ljb.335.1626289464172; Wed, 14 Jul 2021 12:04:24 -0700 (PDT) MIME-Version: 1.0 References: <20210704202756.29107-1-ojeda@kernel.org> <20210704202756.29107-3-ojeda@kernel.org> In-Reply-To: From: Linus Torvalds Date: Wed, 14 Jul 2021 12:04:08 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 02/17] kallsyms: increase maximum kernel symbol length to 512 To: Nick Desaulniers Cc: Miguel Ojeda , Greg Kroah-Hartman , rust-for-linux , Linux Kbuild mailing list , "open list:DOCUMENTATION" , Linux Kernel Mailing List , Alex Gaynor , Geoffrey Thomas , Finn Behrens , Adam Bratschi-Kaye , Wedson Almeida Filho Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: rust-for-linux@vger.kernel.org On Wed, Jul 14, 2021 at 11:20 AM Nick Desaulniers wrote: > > Do we demangle rust symbols when printing a trace from a warn/panic? > That would be nice. I think it would be pretty much required. Otherwise stack traces are going to be very very painful. In fact, I'm starting to think that Willy is right: we should use hashes for the "real" symbol name, and have demangled names for printing, and at no point would the kernel actually want or need to have the nasty mangled names. (This wouldn't be rust-specific - using hashes for module linking sounds like a good diea for C code as well, even if the de-mangled names for printing are then the regular ones) Anybody interested in looking into that? It would make this "big kernel symbols" patch immaterial. Linus