From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1456CC433EF for ; Sun, 12 Sep 2021 23:05:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E651D610A3 for ; Sun, 12 Sep 2021 23:05:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236622AbhILXGT (ORCPT ); Sun, 12 Sep 2021 19:06:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236546AbhILXGS (ORCPT ); Sun, 12 Sep 2021 19:06:18 -0400 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFCF0C061574 for ; Sun, 12 Sep 2021 16:05:03 -0700 (PDT) Received: by mail-lj1-x22b.google.com with SMTP id y6so13835318lje.2 for ; Sun, 12 Sep 2021 16:05:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=X35Fq5OT81Nr4I6Qbip78STPxqD/PDV+RfIaRcMXDmA=; b=M7RyeS9xLb3mVaGM35ZObppxdx3xXQJgghifuu8UVsRcqA3tbQu/b3NBc4q9G58Skc TooyKBQ11SGfPWSLHHrBcpkzM1JhOK+0oM7hKbEmTR97BKf+c74T2tMKjBtHYbQLqmvW URtAxnOjLh0lc9MI1zr/I99Zl6xDfwYZhCri4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=X35Fq5OT81Nr4I6Qbip78STPxqD/PDV+RfIaRcMXDmA=; b=3Y8MdHL9TFeHxlpgT/34YgG8+S6nN8NzImiOtdKHKWyWCp9kbGDOSX9CPJFk69sPCc dTFRzXb5M1lRGF1vc5bo+iGIjbfV/yUay52PRVM3n3iP34uHCxeYSNH0ROCUNsaF+rrT 6mob3gB9l3vOavZIL+yZ9vRCYdJjnmbT5GBzqf0+5Gu9hApST/GzrYgScHxzus9kN19x ELV3LbALiKWKf59ohGT8ckqVhpFJwe4QHGLQ9W0A0eV5W+PpzCI+Y4FUPqgNXJlsrm6i Z/1kuPsi9JKBRRoeZ3CDHB3OTHFaQ5uBbB3ht+UyhikcuPr8tvMapA3PxY0wwUCkT8XC iITw== X-Gm-Message-State: AOAM532TZvJLlQ22f/bDY1efb4hWAysmqB8Wbtzhml2X50sE5rzgq/OK sspv4nCU+DIArKp0PQZ26HlOueEZ4P3StPJL378= X-Google-Smtp-Source: ABdhPJyw7AsLq45Ci5RjrL49nVl7JGP9lx5RJ252zi8G5imAFtazOT/3jz3jlHa70pYSvLJJr1m4/w== X-Received: by 2002:a2e:9247:: with SMTP id v7mr7764368ljg.97.1631487901983; Sun, 12 Sep 2021 16:05:01 -0700 (PDT) Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com. [209.85.167.41]) by smtp.gmail.com with ESMTPSA id k20sm638485lfm.93.2021.09.12.16.05.01 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Sep 2021 16:05:01 -0700 (PDT) Received: by mail-lf1-f41.google.com with SMTP id l11so17059403lfe.1 for ; Sun, 12 Sep 2021 16:05:01 -0700 (PDT) X-Received: by 2002:a2e:8107:: with SMTP id d7mr8107686ljg.68.1631487533580; Sun, 12 Sep 2021 15:58:53 -0700 (PDT) MIME-Version: 1.0 References: <20210912160149.2227137-1-linux@roeck-us.net> <20210912160149.2227137-5-linux@roeck-us.net> <0f36c218-d79c-145f-3368-7456dd39a3f2@roeck-us.net> In-Reply-To: <0f36c218-d79c-145f-3368-7456dd39a3f2@roeck-us.net> From: Linus Torvalds Date: Sun, 12 Sep 2021 15:58:37 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 4/4] alpha: Use absolute_pointer for strcmp on fixed memory location To: Guenter Roeck Cc: Richard Henderson , Ivan Kokshaysky , Matt Turner , "James E . J . Bottomley" , Helge Deller , "David S . Miller" , Jakub Kicinski , alpha , Geert Uytterhoeven , Linux Kernel Mailing List , linux-parisc@vger.kernel.org, Netdev , Sparse Mailing-list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org On Sun, Sep 12, 2021 at 1:37 PM Guenter Roeck wrote: > > COMMAND_LINE is, for whatever reason, defined in > arch/alpha/include/uapi/asm/setup.h, ie in the uapi. > > Can I even touch that ? I think that's entirely a historical accident. Note how most of those #define's don't even work for user space because they use PAGE_OFFSET, which is defined in . And others depend on the kernel config system. There's a couple that do seem to be potentially for user space (MILO bootloader), and who knows just what hacks that code might have with internal knowledge of this header file. But anything I can find on the net seems to predate our move to 'uapi' headers, so I wouldn't really worry about it. So I'd suggest just moving that whole file back to , changing it as necessary, and then seeing if anybody notices. Because I suspect the answer to that is just crickets chirping.. Linus