From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5892CC3B18A for ; Wed, 12 Feb 2020 00:29:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2A4292082F for ; Wed, 12 Feb 2020 00:29:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581467344; bh=k28PC+4ttbIdCRxj3eOx/mcr/adsEt7hpbcB83PrPeA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=XQcrkc36qyciW5fghb8bY0iFq4d4WdtuJpMP+/iRSAgGc/kLNuINP3ay2x14PAgqJ 3m2mbsEiN6Kyem7rz1wOPgt1EX8MHTdsB+hdkJbKWkcWg8T6raGNSth8UQMQlMIYCX fk7rpzr1ovGQAyqlpcMoieeRG7J5DCuE6jGUfugQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728117AbgBLA3D (ORCPT ); Tue, 11 Feb 2020 19:29:03 -0500 Received: from mail-lf1-f68.google.com ([209.85.167.68]:34299 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728091AbgBLA3B (ORCPT ); Tue, 11 Feb 2020 19:29:01 -0500 Received: by mail-lf1-f68.google.com with SMTP id l18so278092lfc.1 for ; Tue, 11 Feb 2020 16:29:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=I1zwim5bENoBH/YJdV0JdFYomer3zhgdaL9VRFgFbmk=; b=a0mAJB8SfJ9gaZZHweS2NdfMYUd1WCE17SI7XP87C6+Ff2gIDBgABMTm1Kx1Nsg1HY 0ruUjl8AovwmwDeG0JrMTljpLYvq2f2NsCGILLfMorIKOj/gOtfvalctlgOMWWRjQ4hp XXLCJke+6ceL5jkjOhRCVzu1uXDQxR66FqD6c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=I1zwim5bENoBH/YJdV0JdFYomer3zhgdaL9VRFgFbmk=; b=PJe6tcu6ZfGLG8AeDiHDMQAP8qxUjHmOwOWaY1P4F0QeihNv8Ax/ZJUKogD4w3YNrT HgUXLkZhKEoxVrj95iFQBkGm0M7oGRjw0Beoq2LRVcsualOtyerROyu1pRUkkPyCLORR BZkqCs5P9fO6pyqWp6O9wDZBs9/BfpmDY8PAwuPFdn554ROLGB2gy8YgntG8ZFkA2f7Y Gu9++VAxYZFoanpR9sqeLAgKeTzSOzi9QJGNOE0kfXLzb6J2r3EoybkoTJrT5bfTgWBS YSYazJ6+BzHlplGYQhF14hXuOK8BheeImyIzijm/6lxQfuv8zuakLIVVy+Oc+fkUHn3T Y9Tg== X-Gm-Message-State: APjAAAVuFu35F24SapPPZ2w7N+fcTl22nf0miThf6TKgqi13Q/li1CbL EcnEg5HpY98W2EP2HdqpnVJVyRnfnm8= X-Google-Smtp-Source: APXvYqxGlX8Cfesxlkcv4Fc4xNmr7SHgdTao5sh+KjKmEDG8sefHr4kDho6A2h/nYvpjMdKgqGxasw== X-Received: by 2002:ac2:59dd:: with SMTP id x29mr5036715lfn.95.1581467339364; Tue, 11 Feb 2020 16:28:59 -0800 (PST) Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com. [209.85.208.178]) by smtp.gmail.com with ESMTPSA id w1sm2529009lfe.96.2020.02.11.16.28.57 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Feb 2020 16:28:57 -0800 (PST) Received: by mail-lj1-f178.google.com with SMTP id y6so271886lji.0 for ; Tue, 11 Feb 2020 16:28:57 -0800 (PST) X-Received: by 2002:a2e:88c5:: with SMTP id a5mr6018875ljk.201.1581467335909; Tue, 11 Feb 2020 16:28:55 -0800 (PST) MIME-Version: 1.0 References: <20200211175507.178100-1-hannes@cmpxchg.org> <29b6e848ff4ad69b55201751c9880921266ec7f4.camel@surriel.com> <20200211193101.GA178975@cmpxchg.org> <20200211154438.14ef129db412574c5576facf@linux-foundation.org> In-Reply-To: <20200211154438.14ef129db412574c5576facf@linux-foundation.org> From: Linus Torvalds Date: Tue, 11 Feb 2020 16:28:39 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] vfs: keep inodes with page cache off the inode shrinker LRU To: Andrew Morton Cc: Johannes Weiner , Rik van Riel , linux-fsdevel , Linux-MM , Linux Kernel Mailing List , Dave Chinner , Yafang Shao , Michal Hocko , Roman Gushchin , Al Viro , kernel-team@fb.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 11, 2020 at 3:44 PM Andrew Morton wrote: > > Testing this will be a challenge, but the issue was real - a 7GB > highmem machine isn't crazy and I expect the inode has become larger > since those days. Hmm. I would say that in the intening years a 7GB highmem machine has indeed become crazy. It used to be something we kind of supported. But we really should consider HIGHMEM to be something that is on the deprecation list. In this day and age, there is no excuse for running a 32-bit kernel with lots of physical memory. And if you really want to do that, and have some legacy hardware with a legacy use case, maybe you should be using a legacy kernel. I'd personally be perfectly happy to start removing HIGHMEM support again. Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4850AC3B188 for ; Wed, 12 Feb 2020 00:29:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EEB142082F for ; Wed, 12 Feb 2020 00:29:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="a0mAJB8S" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EEB142082F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 95F976B037D; Tue, 11 Feb 2020 19:29:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 910446B037F; Tue, 11 Feb 2020 19:29:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 82D106B0380; Tue, 11 Feb 2020 19:29:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0184.hostedemail.com [216.40.44.184]) by kanga.kvack.org (Postfix) with ESMTP id 695D86B037D for ; Tue, 11 Feb 2020 19:29:01 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 0C7614408 for ; Wed, 12 Feb 2020 00:29:01 +0000 (UTC) X-FDA: 76479590082.13.stone64_318a41b205b47 X-HE-Tag: stone64_318a41b205b47 X-Filterd-Recvd-Size: 4441 Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Wed, 12 Feb 2020 00:29:00 +0000 (UTC) Received: by mail-lf1-f65.google.com with SMTP id f24so266934lfh.3 for ; Tue, 11 Feb 2020 16:29:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=I1zwim5bENoBH/YJdV0JdFYomer3zhgdaL9VRFgFbmk=; b=a0mAJB8SfJ9gaZZHweS2NdfMYUd1WCE17SI7XP87C6+Ff2gIDBgABMTm1Kx1Nsg1HY 0ruUjl8AovwmwDeG0JrMTljpLYvq2f2NsCGILLfMorIKOj/gOtfvalctlgOMWWRjQ4hp XXLCJke+6ceL5jkjOhRCVzu1uXDQxR66FqD6c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=I1zwim5bENoBH/YJdV0JdFYomer3zhgdaL9VRFgFbmk=; b=Rb/V/AhmNWYYotCzy66Tq60c37nI5nsILpyd/KJ6ngJ0owoBr9u4ylt2pqsqJ9D3sd fRGb6GBgqBnmB0rg1GENJUEiVU79BP3rKzDADCrs9/PH1Ezpmdj7Zhfyt4+UYwVCr0F/ w0GCI71Z6fwSPjR2e0B5iZ7V3SNvdDue1ZuUVKAj3XkhDK9W1KEuVm9bEml+3OAWo2pK 0Qds3RnrnVuo8+NiRqS15rE7RGJELrb6QD0XlFOv8syY9b6fjnUZBoz26rCAxRRo5wQC RfJsZGx1NmdeTag0xUHfS7bn8qRFp/gz6F1bPRSthk/lgvoji7PfJml0asO1lc0fDiGM i70A== X-Gm-Message-State: APjAAAUCyTdxHtex4crsTIHZMn509guk+7pNUmr5Xn1yfsTFuct9L26G f5KRY0QmQBneSyT99h6hLe5Vz+lBu4U= X-Google-Smtp-Source: APXvYqzCGGPg+NMm0FGNFpaOfLFXjfylEKKxOQhBPhiMsFd7xWXbffBIOZASmnnyrbcNhRWv7WXP0A== X-Received: by 2002:ac2:46c2:: with SMTP id p2mr4939396lfo.139.1581467338589; Tue, 11 Feb 2020 16:28:58 -0800 (PST) Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com. [209.85.208.176]) by smtp.gmail.com with ESMTPSA id m21sm2562404lfb.59.2020.02.11.16.28.57 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Feb 2020 16:28:57 -0800 (PST) Received: by mail-lj1-f176.google.com with SMTP id q8so219751ljj.11 for ; Tue, 11 Feb 2020 16:28:57 -0800 (PST) X-Received: by 2002:a2e:88c5:: with SMTP id a5mr6018875ljk.201.1581467335909; Tue, 11 Feb 2020 16:28:55 -0800 (PST) MIME-Version: 1.0 References: <20200211175507.178100-1-hannes@cmpxchg.org> <29b6e848ff4ad69b55201751c9880921266ec7f4.camel@surriel.com> <20200211193101.GA178975@cmpxchg.org> <20200211154438.14ef129db412574c5576facf@linux-foundation.org> In-Reply-To: <20200211154438.14ef129db412574c5576facf@linux-foundation.org> From: Linus Torvalds Date: Tue, 11 Feb 2020 16:28:39 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] vfs: keep inodes with page cache off the inode shrinker LRU To: Andrew Morton Cc: Johannes Weiner , Rik van Riel , linux-fsdevel , Linux-MM , Linux Kernel Mailing List , Dave Chinner , Yafang Shao , Michal Hocko , Roman Gushchin , Al Viro , kernel-team@fb.com Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 11, 2020 at 3:44 PM Andrew Morton wrote: > > Testing this will be a challenge, but the issue was real - a 7GB > highmem machine isn't crazy and I expect the inode has become larger > since those days. Hmm. I would say that in the intening years a 7GB highmem machine has indeed become crazy. It used to be something we kind of supported. But we really should consider HIGHMEM to be something that is on the deprecation list. In this day and age, there is no excuse for running a 32-bit kernel with lots of physical memory. And if you really want to do that, and have some legacy hardware with a legacy use case, maybe you should be using a legacy kernel. I'd personally be perfectly happy to start removing HIGHMEM support again. Linus