From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0642DC433E0 for ; Fri, 7 Aug 2020 18:17:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D2DE222CF8 for ; Fri, 7 Aug 2020 18:17:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596824259; bh=QxKcQQUA3JkyCIgSo7byQ8XNzCl4V26ZwvlzlYAtZEc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=qxH2URI8scm1hJ4DlaFLbZD0ndkwWgsZY1p1eQDr/4N7nE2gt5ksh/uz2t1ekZKmj kipH58gEcWz4iuKWe7EHfhgRYOlao9CaZPEssPI9YuKXGn33A1XiaiqozQvTLvxQQw AXuKGEeG+/mn0QuWDD74Zbuq3iFLjq8HzDkF3KAo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726448AbgHGSRj (ORCPT ); Fri, 7 Aug 2020 14:17:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725934AbgHGSRi (ORCPT ); Fri, 7 Aug 2020 14:17:38 -0400 Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36BA7C061756 for ; Fri, 7 Aug 2020 11:17:38 -0700 (PDT) Received: by mail-lj1-x241.google.com with SMTP id z14so3196947ljm.1 for ; Fri, 07 Aug 2020 11:17:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CKMvl01L4wF4iqNu2rhFEk7yvhvWgxW9jY+i4dSP0Kw=; b=QNy++CHeaaM6WpTb5fAZTyuu42THHqM5jUd2cVss/n1PrKPIikisPKPZhqd7LZTKxg XRl8ax9NJP1HEwuU+5uYXH/UJjANG6FSmTpAGh/ApTvFbuHohZLD8NJT7jz3jNAfXMGD qaLgx9c5VgDvjeeVZmx3gDEbig9nwZY1MWC7w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CKMvl01L4wF4iqNu2rhFEk7yvhvWgxW9jY+i4dSP0Kw=; b=CKhqRlfjy6o5NSMXqZcb1uGOLJhgel4CAubZaNxDoUak1B89SQdyYqwA1/H1XOT329 LABoz/uZJV59LaUpJ7en33/Nd9RlikOJIki+kgqJW8KuVfZrrIBwswa4jYEfvnqf9lOV GMNl0QY/lIsdDE1yfmqiF9x6C4YYcmFiwNgBQQfG4GdiDXPjnLT2xYmLobvehDXRTJkD m7548GIick87v8T3Pkc5otGBcoiP9mmFUwwamdb93E+p8lLAsFObn8ctUTXkmtoKg8H+ e8IxxrQAWvJAVqZrFjX0eEtUVHTWyhzv2nKC/UiyszRoPY29Zd2XWIKX43ySCOx4ehG7 su+w== X-Gm-Message-State: AOAM530J+Qb999KR26SF1gr+/jR8PSgH5TlDe5CWY4MEEhpEcaPDuhPX UbdsDILIvk/aALc5WHv8Gny6fgHeFHx0ew== X-Google-Smtp-Source: ABdhPJz/KzsI1C1jtRgwFo+Qyyzb6Ds6m8oeLWqqVyrITpsdrQBzxX2BbBedRaTFFosI1wEE8TBIVg== X-Received: by 2002:a2e:9696:: with SMTP id q22mr6792648lji.11.1596824255571; Fri, 07 Aug 2020 11:17:35 -0700 (PDT) Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com. [209.85.208.169]) by smtp.gmail.com with ESMTPSA id a24sm2132817lji.36.2020.08.07.11.17.33 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Aug 2020 11:17:34 -0700 (PDT) Received: by mail-lj1-f169.google.com with SMTP id g6so3139680ljn.11 for ; Fri, 07 Aug 2020 11:17:33 -0700 (PDT) X-Received: by 2002:a2e:545:: with SMTP id 66mr7142832ljf.285.1596824253318; Fri, 07 Aug 2020 11:17:33 -0700 (PDT) MIME-Version: 1.0 References: <20200806231643.a2711a608dd0f18bff2caf2b@linux-foundation.org> <20200807061706.unk5_0KtC%akpm@linux-foundation.org> In-Reply-To: <20200807061706.unk5_0KtC%akpm@linux-foundation.org> From: Linus Torvalds Date: Fri, 7 Aug 2020 11:17:17 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [patch 001/163] mm/memory.c: avoid access flag update TLB flush for retried page fault To: Andrew Morton Cc: Catalin Marinas , Johannes Weiner , Hillf Danton , Hugh Dickins , Josef Bacik , "Kirill A . Shutemov" , Linux-MM , mm-commits@vger.kernel.org, stable , Will Deacon , Matthew Wilcox , Yu Xu , Yang Shi Content-Type: text/plain; charset="UTF-8" Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, Aug 6, 2020 at 11:17 PM Andrew Morton wrote: > > From: Yang Shi > Subject: mm/memory.c: avoid access flag update TLB flush for retried page fault This is not the safe version that just avoids the extra TLB flush. This is - once again - the thing that skips the whole mkdirty and page table update too. I'm not taking it this time _either_. Andrew, please flush this garbage from your system. Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39C38C433DF for ; Fri, 7 Aug 2020 18:17:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CB2C3204EA for ; Fri, 7 Aug 2020 18:17:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="QNy++CHe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB2C3204EA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 313EB8D0006; Fri, 7 Aug 2020 14:17:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 29D8E8D0005; Fri, 7 Aug 2020 14:17:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 18C088D0006; Fri, 7 Aug 2020 14:17:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0048.hostedemail.com [216.40.44.48]) by kanga.kvack.org (Postfix) with ESMTP id 03BBF8D0005 for ; Fri, 7 Aug 2020 14:17:38 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id CCA2C181AEF10 for ; Fri, 7 Aug 2020 18:17:37 +0000 (UTC) X-FDA: 77124580554.20.dad99_4303df426fc2 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id 94B9F180C07AF for ; Fri, 7 Aug 2020 18:17:37 +0000 (UTC) X-HE-Tag: dad99_4303df426fc2 X-Filterd-Recvd-Size: 4118 Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Fri, 7 Aug 2020 18:17:36 +0000 (UTC) Received: by mail-lf1-f66.google.com with SMTP id h8so1462097lfp.9 for ; Fri, 07 Aug 2020 11:17:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CKMvl01L4wF4iqNu2rhFEk7yvhvWgxW9jY+i4dSP0Kw=; b=QNy++CHeaaM6WpTb5fAZTyuu42THHqM5jUd2cVss/n1PrKPIikisPKPZhqd7LZTKxg XRl8ax9NJP1HEwuU+5uYXH/UJjANG6FSmTpAGh/ApTvFbuHohZLD8NJT7jz3jNAfXMGD qaLgx9c5VgDvjeeVZmx3gDEbig9nwZY1MWC7w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CKMvl01L4wF4iqNu2rhFEk7yvhvWgxW9jY+i4dSP0Kw=; b=IYRyZQ/z1N1wIFcJ84uXxKNxK7XCfZONXXt/aCOQEOByFFNmX8OTXtWU5JzN4UM1a2 55zPG73LvTv72qEl77/klZJDkSmT//T4huHd9fUEX8Jvhuz/gB+9hX3Ctl5u5REETgVh gWhw9M5v5qoUND52YwyJnX9LAHlebhPdzALAJlfkW6ZN0AWJEv6e0FJI6mi8prH3vqWZ 79z3OQEZ+Acl01jLx8Pb8nwk8cckkaHy5EFBlOJNou5BWScbGUBS7EuSIzLUQ3vPnN+2 bN6Gj3ZEkSD5TBgIMv4ST8nQZMPzVJDnWdKZOXH6FG7L/4DcF7/CltHt5C+iCH7lXoRv CHRw== X-Gm-Message-State: AOAM531MI858cMaxZ+4282iBFFK8wOp9Yehwa4lqG0aTCjrn4cW0FziI RHc0f2Ss7/2yfHr79XwIj8G8K3THHow= X-Google-Smtp-Source: ABdhPJxNklbAB6BA4uIMACKtd021uGv82eQ9Sj0Doe/ynZDxSqPcmSDSDJdK/L498/1dJO79MbINog== X-Received: by 2002:ac2:5c50:: with SMTP id s16mr6974462lfp.93.1596824254659; Fri, 07 Aug 2020 11:17:34 -0700 (PDT) Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com. [209.85.208.170]) by smtp.gmail.com with ESMTPSA id 132sm4566598lfo.16.2020.08.07.11.17.33 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Aug 2020 11:17:34 -0700 (PDT) Received: by mail-lj1-f170.google.com with SMTP id v4so3189811ljd.0 for ; Fri, 07 Aug 2020 11:17:33 -0700 (PDT) X-Received: by 2002:a2e:545:: with SMTP id 66mr7142832ljf.285.1596824253318; Fri, 07 Aug 2020 11:17:33 -0700 (PDT) MIME-Version: 1.0 References: <20200806231643.a2711a608dd0f18bff2caf2b@linux-foundation.org> <20200807061706.unk5_0KtC%akpm@linux-foundation.org> In-Reply-To: <20200807061706.unk5_0KtC%akpm@linux-foundation.org> From: Linus Torvalds Date: Fri, 7 Aug 2020 11:17:17 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [patch 001/163] mm/memory.c: avoid access flag update TLB flush for retried page fault To: Andrew Morton Cc: Catalin Marinas , Johannes Weiner , Hillf Danton , Hugh Dickins , Josef Bacik , "Kirill A . Shutemov" , Linux-MM , mm-commits@vger.kernel.org, stable , Will Deacon , Matthew Wilcox , Yu Xu , Yang Shi Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 94B9F180C07AF X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 6, 2020 at 11:17 PM Andrew Morton wrote: > > From: Yang Shi > Subject: mm/memory.c: avoid access flag update TLB flush for retried page fault This is not the safe version that just avoids the extra TLB flush. This is - once again - the thing that skips the whole mkdirty and page table update too. I'm not taking it this time _either_. Andrew, please flush this garbage from your system. Linus