From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C53E8C433DF for ; Wed, 12 Aug 2020 17:54:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6C78E2078B for ; Wed, 12 Aug 2020 17:54:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="GrbvKI9z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C78E2078B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9F5578D001E; Wed, 12 Aug 2020 13:54:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A6D58D0002; Wed, 12 Aug 2020 13:54:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 894258D001E; Wed, 12 Aug 2020 13:54:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0142.hostedemail.com [216.40.44.142]) by kanga.kvack.org (Postfix) with ESMTP id 707278D0002 for ; Wed, 12 Aug 2020 13:54:29 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 0996C181AEF0B for ; Wed, 12 Aug 2020 17:54:29 +0000 (UTC) X-FDA: 77142666258.11.club92_220465526fed Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id C81B8180F8B80 for ; Wed, 12 Aug 2020 17:54:28 +0000 (UTC) X-HE-Tag: club92_220465526fed X-Filterd-Recvd-Size: 3940 Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Wed, 12 Aug 2020 17:54:28 +0000 (UTC) Received: by mail-lf1-f66.google.com with SMTP id j22so1639155lfm.2 for ; Wed, 12 Aug 2020 10:54:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LmS6cdCNZQDhrBamGIqGiAnGkZ9MwTYUTqViUre813E=; b=GrbvKI9z8dfHXoKC/jDcBaTW7e7BgeNmMAUY1NLX3JYdaEaIFPkzFz1KbkRshONbtm t0z/L5tWGgLyoGp7iV5sScuE56Wobnai1v/pA3XVE7xXKVqv/VDCxmJwXEq3BGmoyOas SbtD88TkO/w74Cp0cDof/gBmS5RC7VP76rKIk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LmS6cdCNZQDhrBamGIqGiAnGkZ9MwTYUTqViUre813E=; b=Zbap57YiI2cRsOk7yApu4Mkss2wXwBYpAlOnzife40MJMP0d0ipyAKjgDvklhnScbG sXc9Mv9b1xN0eaVa3kXh/UbWesfN9Wze8fVXwm/S0cBtXZ1oJ7aZFAtZ3sd253lQHqu1 CLqQ81AXb6RESqOJ5V5msKAaezb04u3Ti6xAmAvnsR+FcIIx01hwnFulrkHvYEkPdqjz syLi6PvAnY0ofR0JB8gYlceC0Pwn3ra5d2TQQc1+qxgriBeX1I1KSzMVwc2J2lKH9x8n gUcuZilpdysxZktSFIT71dbteXiwX6UKp5RbIs4GREQHK5QV0yW7ZKDxjMDifXHGykIP 0LwA== X-Gm-Message-State: AOAM5302zt/v1PDUGrxwItmLEpjBOLe/vYdIULVjf6f00tATMhEOY/vc rp8PAIbPHn9pRF5+znzbyVm895V+emw= X-Google-Smtp-Source: ABdhPJzXBEkW3785YMZ5z/NLnO1PIivPhhmuVzqOXayYdTi3PnnEpet7yOA3aHeqxzZ3OglV4qxgrg== X-Received: by 2002:a05:6512:3e8:: with SMTP id n8mr275505lfq.210.1597254866154; Wed, 12 Aug 2020 10:54:26 -0700 (PDT) Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com. [209.85.167.51]) by smtp.gmail.com with ESMTPSA id y16sm575036ljg.21.2020.08.12.10.54.24 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Aug 2020 10:54:24 -0700 (PDT) Received: by mail-lf1-f51.google.com with SMTP id h8so1620034lfp.9 for ; Wed, 12 Aug 2020 10:54:24 -0700 (PDT) X-Received: by 2002:a05:6512:3b7:: with SMTP id v23mr292943lfp.10.1597254863910; Wed, 12 Aug 2020 10:54:23 -0700 (PDT) MIME-Version: 1.0 References: <20200811182949.e12ae9a472e3b5e27e16ad6c@linux-foundation.org> <20200812013500.TPqi6kXv2%akpm@linux-foundation.org> In-Reply-To: <20200812013500.TPqi6kXv2%akpm@linux-foundation.org> From: Linus Torvalds Date: Wed, 12 Aug 2020 10:54:08 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [patch 090/165] lz4: fix kernel decompression speed To: Andrew Morton Cc: 4sschmid@informatik.uni-hamburg.de, Gao Xiang , Greg Kroah-Hartman , Linux-MM , Ingo Molnar , mm-commits@vger.kernel.org, Arvind Sankar , terrelln@fb.com, yann.collet.73@gmail.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: C81B8180F8B80 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 11, 2020 at 6:35 PM Andrew Morton wrote: > > From: Nick Terrell > Subject: lz4: fix kernel decompression speed > > This patch replaces all memcpy() calls with LZ4_memcpy() which calls > __builtin_memcpy() so the compiler can inline it. Wasn't this LZ4_memcpy() wrapper made unnecessary by just making memcpy() work properly on its own? So I'm dropping this patch. If it turns out that I mis-remembered (or mis-understood), please re-send. Nick? Linus