From: Linus Torvalds <torvalds@linux-foundation.org>
To: Jakub Kicinski <kuba@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Pablo Neira Ayuso <pablo@netfilter.org>
Cc: David Miller <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] Networking for 5.17
Date: Mon, 10 Jan 2022 19:42:47 -0800 [thread overview]
Message-ID: <CAHk-=wiTN_hOyQ1_3DPgYJ_oBhwN+e29jrsj8qjqKsodRZ6r1Q@mail.gmail.com> (raw)
In-Reply-To: <CAHk-=wg-pW=bRuRUvhGmm0DgqZ45A0KaH85V5KkVoxGKX170Xg@mail.gmail.com>
On Mon, Jan 10, 2022 at 7:31 PM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> Merged. But I now note that this actually triggers an error when
> building with clang:
>
> net/netfilter/nf_tables_api.c:8278:4: error: variable 'data_size' is
> uninitialized when used here [-Werror,-Wuninitialized]
> data_size += sizeof(*prule) + rule->dlen;
> ^~~~~~~~~
>
> and I think clang is entirely right.
I pushed out my trivial one-liner fix for this as commit 63045bfd3c8d
("netfilter: nf_tables: don't use 'data_size' uninitialized"). The
build error kept my clang builds from working, so waiting for any
alternate fix wasn't going to happen.
Linus
next prev parent reply other threads:[~2022-01-11 3:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 2:52 [GIT PULL] Networking for 5.17 Jakub Kicinski
2022-01-11 3:20 ` pr-tracker-bot
2022-01-11 3:31 ` Linus Torvalds
2022-01-11 3:42 ` Linus Torvalds [this message]
2022-01-11 4:56 ` Jakub Kicinski
2022-01-11 5:02 ` Linus Torvalds
2022-01-11 16:01 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wiTN_hOyQ1_3DPgYJ_oBhwN+e29jrsj8qjqKsodRZ6r1Q@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.