From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 188C2C433E0 for ; Mon, 28 Dec 2020 01:55:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E1567225A9 for ; Mon, 28 Dec 2020 01:55:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726400AbgL1Bzf (ORCPT ); Sun, 27 Dec 2020 20:55:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726226AbgL1Bzd (ORCPT ); Sun, 27 Dec 2020 20:55:33 -0500 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7103C061794 for ; Sun, 27 Dec 2020 17:54:52 -0800 (PST) Received: by mail-lf1-x131.google.com with SMTP id m25so20792928lfc.11 for ; Sun, 27 Dec 2020 17:54:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=H1lRjsgoyhilZK+oNXD2wNhl23j+kp8k6kqf/g6+eOY=; b=OyMg5oCZz79wox7nowQJIpdsLexJGQfx63D+5ySlWUwH7Pkiy7xy3Ex+2Qfr54Fxrw B7ogNZi6NjP16Ujs2kphKgiS6jqmv7MeAksxip495bhvgr0ezvW2GQyMYjVPM+qXVDKa n/JWSzvL+cU9vv3gN1T5F4fiA8fvrEUnaM8vg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=H1lRjsgoyhilZK+oNXD2wNhl23j+kp8k6kqf/g6+eOY=; b=KHWS7oqWoC4Qlcvmhy+0J7YcZGUCiLehWuB5PeIyxy0cIt/WYPC4v21UVO0VtH2Bdy bbxHv9l/nO+x/Xdtr7L97Yo+U8KklSWCeN70uQj9w8tVTGGu2HE7rg4OlO0j8VRpoOSq gZCaof1czwGonlIgy2r0cHe1qr/Lzx/42n3CqyIhrg9b+qyt+52RiuCQvHGjH8VKX/6V R44vi6/blbmitsU8UD3NKWsuIpTJb7S7tnQ8rH1xwDzfthJmC9iw8Muatpq4G2RUP039 cdZJfWD8wQAb9zO+GVrNRT3UlOnq9jmFCcFZpv0wv/eGpZzU02jORVSBzP2xqcog+lY7 VT0w== X-Gm-Message-State: AOAM531eTv6gOjxNtiik3Uz7GYqjuTI5kpIrJeXLOdkhotizlEZjCEPQ AKSw6UD9EzigT5MwiwylD8bThQaDfg6tUw== X-Google-Smtp-Source: ABdhPJx8oQo/ZVm9RxDbX2TIHvsVYkIXwEq5nRaPEEE0oXmFEJD5CQGWYLXGgKsf1GMwprh8A3ZtKA== X-Received: by 2002:a2e:58f:: with SMTP id 137mr20290705ljf.469.1609120490748; Sun, 27 Dec 2020 17:54:50 -0800 (PST) Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com. [209.85.167.44]) by smtp.gmail.com with ESMTPSA id r16sm6306937ljk.93.2020.12.27.17.54.48 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Dec 2020 17:54:49 -0800 (PST) Received: by mail-lf1-f44.google.com with SMTP id b26so20827085lff.9 for ; Sun, 27 Dec 2020 17:54:48 -0800 (PST) X-Received: by 2002:a05:6512:3048:: with SMTP id b8mr18913675lfb.421.1609120488177; Sun, 27 Dec 2020 17:54:48 -0800 (PST) MIME-Version: 1.0 References: <20201225113157.e7hmluffh56fszfc@box> <20201226204335.dikqkrkezqet6oqf@box> <20201226224016.dxjmordcfj75xgte@box> <20201227234853.5mjyxcybucts3kbq@box> In-Reply-To: <20201227234853.5mjyxcybucts3kbq@box> From: Linus Torvalds Date: Sun, 27 Dec 2020 17:54:32 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] mm: Allow architectures to request 'old' entries when prefaulting To: "Kirill A. Shutemov" Cc: Hugh Dickins , Matthew Wilcox , "Kirill A. Shutemov" , Will Deacon , Linux Kernel Mailing List , Linux-MM , Linux ARM , Catalin Marinas , Jan Kara , Minchan Kim , Andrew Morton , Vinayak Menon , Android Kernel Team Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 27, 2020 at 3:48 PM Kirill A. Shutemov wrote: > > I did what Hugh proposed and it got clear to my eyes. It gets somewhat > large, but take a look. Ok, it's not that much bigger, and the end result is certainly much clearer wrt locking. So that last version of yours with the fix for the uninitialized 'ret' variable looks good to me. Of course, I've said that before, and have been wrong. So ... Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0A9BC433DB for ; Mon, 28 Dec 2020 01:54:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 60BA7225A9 for ; Mon, 28 Dec 2020 01:54:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 60BA7225A9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 865146B0108; Sun, 27 Dec 2020 20:54:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8153B6B0109; Sun, 27 Dec 2020 20:54:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 72AA88D0003; Sun, 27 Dec 2020 20:54:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0144.hostedemail.com [216.40.44.144]) by kanga.kvack.org (Postfix) with ESMTP id 5ED9A6B0108 for ; Sun, 27 Dec 2020 20:54:53 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 22F5B34A3 for ; Mon, 28 Dec 2020 01:54:53 +0000 (UTC) X-FDA: 77641022466.26.watch20_600caa627490 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id 03D941804B656 for ; Mon, 28 Dec 2020 01:54:52 +0000 (UTC) X-HE-Tag: watch20_600caa627490 X-Filterd-Recvd-Size: 4590 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Mon, 28 Dec 2020 01:54:52 +0000 (UTC) Received: by mail-lf1-f48.google.com with SMTP id m25so20792925lfc.11 for ; Sun, 27 Dec 2020 17:54:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=H1lRjsgoyhilZK+oNXD2wNhl23j+kp8k6kqf/g6+eOY=; b=OyMg5oCZz79wox7nowQJIpdsLexJGQfx63D+5ySlWUwH7Pkiy7xy3Ex+2Qfr54Fxrw B7ogNZi6NjP16Ujs2kphKgiS6jqmv7MeAksxip495bhvgr0ezvW2GQyMYjVPM+qXVDKa n/JWSzvL+cU9vv3gN1T5F4fiA8fvrEUnaM8vg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=H1lRjsgoyhilZK+oNXD2wNhl23j+kp8k6kqf/g6+eOY=; b=fPm+iJv7+sxJExBl2C9V3CK3VuXJQr+eQbV4TJLYUSU+AoV+ZCSR+t6othJmNXTiiS Llh4AF6J/ENdUY6zXzui/UJJ2tfiWMFxS1dEyWnntwyJL6TTpYYXdO6sgimyM6G7L/w6 QirJp7t/AX/+5DXRfs5ndw0pr9RpEnUEjn2EYU3ng4RKRS+JAH+n7K54txyN8s06TXuG 4kr+ITS90GT8aMzEVQR8XSyhuMzEjO5VdDdscL6AvlZAaxYKIu0iY/KP800YIFiaHGJG 9lEtY/tMUCNmjP4szQrbGKJA2vx3ijqEDOTVSWcdUveHa4em4VwoOVouOYk+FUyj81Mo VpBA== X-Gm-Message-State: AOAM532IgCgwOpwYLmgACvuziepXl5PwrKe46UdRm+X5ghgCwmSmZ1Cx 2/sOaiBRNArxn6mU/KEk1ZkumK6TNuRyyg== X-Google-Smtp-Source: ABdhPJwRYYn/33bWc+9HOYE7qQQ6YMjRTShA07+1NQNoxcef6lWgsQlvdtDDwjIPVlHcKQaGzI4dsw== X-Received: by 2002:a2e:8599:: with SMTP id b25mr20162084lji.334.1609120490676; Sun, 27 Dec 2020 17:54:50 -0800 (PST) Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com. [209.85.167.46]) by smtp.gmail.com with ESMTPSA id d10sm5191011lfj.281.2020.12.27.17.54.48 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Dec 2020 17:54:49 -0800 (PST) Received: by mail-lf1-f46.google.com with SMTP id h22so20917802lfu.2 for ; Sun, 27 Dec 2020 17:54:48 -0800 (PST) X-Received: by 2002:a05:6512:3048:: with SMTP id b8mr18913675lfb.421.1609120488177; Sun, 27 Dec 2020 17:54:48 -0800 (PST) MIME-Version: 1.0 References: <20201225113157.e7hmluffh56fszfc@box> <20201226204335.dikqkrkezqet6oqf@box> <20201226224016.dxjmordcfj75xgte@box> <20201227234853.5mjyxcybucts3kbq@box> In-Reply-To: <20201227234853.5mjyxcybucts3kbq@box> From: Linus Torvalds Date: Sun, 27 Dec 2020 17:54:32 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] mm: Allow architectures to request 'old' entries when prefaulting To: "Kirill A. Shutemov" Cc: Hugh Dickins , Matthew Wilcox , "Kirill A. Shutemov" , Will Deacon , Linux Kernel Mailing List , Linux-MM , Linux ARM , Catalin Marinas , Jan Kara , Minchan Kim , Andrew Morton , Vinayak Menon , Android Kernel Team Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Dec 27, 2020 at 3:48 PM Kirill A. Shutemov wrote: > > I did what Hugh proposed and it got clear to my eyes. It gets somewhat > large, but take a look. Ok, it's not that much bigger, and the end result is certainly much clearer wrt locking. So that last version of yours with the fix for the uninitialized 'ret' variable looks good to me. Of course, I've said that before, and have been wrong. So ... Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA959C433E0 for ; Mon, 28 Dec 2020 01:57:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3DC07225A9 for ; Mon, 28 Dec 2020 01:57:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3DC07225A9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JTvyDmYPqgpBQ5c8B6Y5PmW3osGMRbO2f/fUu6mF3C8=; b=KDMpwarM/CZS1+X7ZQDP258jm RCK+8awj3ajJyiAjkDPbylN2A5V0W4m2Fdx3usi03+qajI1gMqv7LYtY3TFYhgVYzAJfxztKn6kEC BUm6Nhk9SQTTAK41vufmXu0OwbPXs65shWR1NMwzC2N3arIPMack66RaS9Vb1SYijqOZ22D2fumg1 8BKvLFZeZzlcXYpj2IuHpHDuaAyEvHi2YwCQCw4qhRL7WRUtzWSizpMIgEjzurCU+AYeZDwSjRMtb HU/0e+aRlsBhhZ5fmOKj2j3cUjRTpQBc9tYP8EuXP+mMdA3M2CSc8JHOn3zjSg8mqu18S6mOn8EKG q2JNZAY2g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kthkM-0002hN-IV; Mon, 28 Dec 2020 01:54:54 +0000 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kthkK-0002gl-73 for linux-arm-kernel@lists.infradead.org; Mon, 28 Dec 2020 01:54:53 +0000 Received: by mail-lf1-x129.google.com with SMTP id b26so20827223lff.9 for ; Sun, 27 Dec 2020 17:54:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=H1lRjsgoyhilZK+oNXD2wNhl23j+kp8k6kqf/g6+eOY=; b=OyMg5oCZz79wox7nowQJIpdsLexJGQfx63D+5ySlWUwH7Pkiy7xy3Ex+2Qfr54Fxrw B7ogNZi6NjP16Ujs2kphKgiS6jqmv7MeAksxip495bhvgr0ezvW2GQyMYjVPM+qXVDKa n/JWSzvL+cU9vv3gN1T5F4fiA8fvrEUnaM8vg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=H1lRjsgoyhilZK+oNXD2wNhl23j+kp8k6kqf/g6+eOY=; b=RydZnUDak6Q89RuXYBzy11mJBzAiYqdasNP37Q7YPDPJEfWX2KSQU0fU6/AkwZWWrS dCVPVpCtqHJm8A7AEVZ+6SXRSVtVeb0oC86HQT0LY6MEXN3aYX8EReGSjfi558DYoe1Q xLxSA6lUtmStiuxzkIhve5i8wZcA8faU6QDt2uvyLiaoKP4k0XCamvxFK7wv96kf/kFz qmla2A243THteQY+CMN1LXWhmtCAkQx5TfjOF3qrRya1QyCMkNscrdWrY5sUMa2paM6S hgGt+88ZI3oa22sFviVfIQqq/imcF8nffnyQgUgtOK8k1T8zqADQKsdw2Ul5cwGBL0Mo FeJQ== X-Gm-Message-State: AOAM532/yjYFSXRRie45XsQuXcRaROJ3L46tX1/sNfFYLXFAh4lw5FlS F688nQClCCxsVqJpyTHGBiIwtjyOy2TbZA== X-Google-Smtp-Source: ABdhPJzneeQjOjsQn+oXxnarw7l/QSEaE4qc0vtIpSl9k7poQrARJ25xDjFw0hcsDMJEMG00skr5cw== X-Received: by 2002:ac2:52b8:: with SMTP id r24mr19199735lfm.219.1609120490462; Sun, 27 Dec 2020 17:54:50 -0800 (PST) Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com. [209.85.167.41]) by smtp.gmail.com with ESMTPSA id l19sm6277696ljj.87.2020.12.27.17.54.48 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Dec 2020 17:54:49 -0800 (PST) Received: by mail-lf1-f41.google.com with SMTP id o13so20879503lfr.3 for ; Sun, 27 Dec 2020 17:54:48 -0800 (PST) X-Received: by 2002:a05:6512:3048:: with SMTP id b8mr18913675lfb.421.1609120488177; Sun, 27 Dec 2020 17:54:48 -0800 (PST) MIME-Version: 1.0 References: <20201225113157.e7hmluffh56fszfc@box> <20201226204335.dikqkrkezqet6oqf@box> <20201226224016.dxjmordcfj75xgte@box> <20201227234853.5mjyxcybucts3kbq@box> In-Reply-To: <20201227234853.5mjyxcybucts3kbq@box> From: Linus Torvalds Date: Sun, 27 Dec 2020 17:54:32 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] mm: Allow architectures to request 'old' entries when prefaulting To: "Kirill A. Shutemov" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201227_205452_427810_F30BAE62 X-CRM114-Status: GOOD ( 11.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Android Kernel Team , Jan Kara , Minchan Kim , Catalin Marinas , Hugh Dickins , Linux Kernel Mailing List , Matthew Wilcox , Linux-MM , Vinayak Menon , Linux ARM , Andrew Morton , Will Deacon , "Kirill A. Shutemov" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Dec 27, 2020 at 3:48 PM Kirill A. Shutemov wrote: > > I did what Hugh proposed and it got clear to my eyes. It gets somewhat > large, but take a look. Ok, it's not that much bigger, and the end result is certainly much clearer wrt locking. So that last version of yours with the fix for the uninitialized 'ret' variable looks good to me. Of course, I've said that before, and have been wrong. So ... Linus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel