From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4725CC433F5 for ; Sat, 28 May 2022 18:09:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239335AbiE1SJL (ORCPT ); Sat, 28 May 2022 14:09:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236088AbiE1SJJ (ORCPT ); Sat, 28 May 2022 14:09:09 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F743DF1B for ; Sat, 28 May 2022 11:09:08 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id m20so13983173ejj.10 for ; Sat, 28 May 2022 11:09:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iGqp3sqIQ6D1oqU2b3UQ+JQ14av/DX22LG0p5NM1mUo=; b=Px8PhLWYRiqNg8y87VlDUDsLJH2RoVnLN8Jl2LVu1LymXQyB5v2VGxblVmbq7n6ao8 VU3hqglYO5WBsoT19tAqis2S52THyYxULaMlPuhCVc+o+wPTrAjTjNWJDkwjJ3dtGVFj 8QZXFAV7pfp7xwqlA1vAGNq2rUWHaa1b3lzak= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iGqp3sqIQ6D1oqU2b3UQ+JQ14av/DX22LG0p5NM1mUo=; b=dgmGnvXp8UKEUqFgvXP9OLpaFTiv9KySwhe+IQydHT7qClowgumW8tSGgZxZeIDw58 eQSRk7XFn6+1ltWXHxgjWy8pPD28WHanObi+85yxsTaw3WfsFAc0Zow5Rw2BF+HTNboZ I0lB4UeazDkiSOoieTxbYT98wXWMxaYqRWPpRGn3sV2anNoNZjImGdLFsYU9rvvD6l7f v8gq7G2pLeiLjQNCZpI0fPspNZKMcNlSyb0onT82+vljoazsLPSptLtaeM3qG2XS0ZdB 2RgF0E/bz4N0RXQEjZHe3eMfZN5G+SQy+IqzSSrLXPLQWDsBzQ+0yzN6dJsp/FDmcOJG v+0A== X-Gm-Message-State: AOAM5338XyabSYcJPYYEwlj/otcWAjgmeC1pfZ0b188nsAL6Whqih3jr 7FP6FfU/0Q3BFVDmgyqlMt0u3qoRCLhZPVbg X-Google-Smtp-Source: ABdhPJzeIkUdjftI/xLAEArhN6iWXE8iqufD24H+DW7vCtRBC6Im/7Ijuv83TeX8apYnYYuHTOouPg== X-Received: by 2002:a17:907:a426:b0:6ff:6c9f:7a3a with SMTP id sg38-20020a170907a42600b006ff6c9f7a3amr69120ejc.316.1653761346692; Sat, 28 May 2022 11:09:06 -0700 (PDT) Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com. [209.85.221.42]) by smtp.gmail.com with ESMTPSA id q9-20020a50cc89000000b0042ac2705444sm3809080edi.58.2022.05.28.11.09.05 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 28 May 2022 11:09:05 -0700 (PDT) Received: by mail-wr1-f42.google.com with SMTP id u3so9714289wrg.3 for ; Sat, 28 May 2022 11:09:05 -0700 (PDT) X-Received: by 2002:a05:6000:16c4:b0:20f:cd5d:4797 with SMTP id h4-20020a05600016c400b0020fcd5d4797mr28588153wrf.193.1653761344659; Sat, 28 May 2022 11:09:04 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Linus Torvalds Date: Sat, 28 May 2022 11:08:48 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: mainline build failure due to f1e4c916f97f ("drm/edid: add EDID block count and size helpers") To: Sudip Mukherjee , Russell King , Arnd Bergmann , Viresh Kumar , Shiraz Hashim Cc: Jani Nikula , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel , Linux Kernel Mailing List , Linux ARM , SoC Team Content-Type: multipart/mixed; boundary="0000000000007e28af05e01651d2" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --0000000000007e28af05e01651d2 Content-Type: text/plain; charset="UTF-8" On Sat, May 28, 2022 at 10:40 AM Linus Torvalds wrote: > > So digging a bit deeper - since I have am arm compiler after all - I > note that 'sizeof(detailed_timings)' is 88. Hmm. sizeof() both detailed_timings[0].data.other_data.data.range.formula.gtf2 and detailed_timings[0].data.other_data.data.range.formula.cvt is 7. But the *union* of those things is detailed_timings[0].data.other_data.data.range.formula and its size is 8 (despite having an alignment of just 1). The attached patch would seem to fix it for me. Not very much tested, and I have no idea what it is that triggers this only on spear3xx_defconfig. Some ARM ABI issue that is triggered by some very particular ARM compiler flag enabled by that config? Adding some ARM (and SPEAR, and SoC) people in case they have any idea. This smells like a compiler bug triggered by "there's a 16-bit member field in that gtf2 structure, and despite it being packed and aligned to 1, we somehow still align the size to 2". I dunno. But marking those unions packed too doesn't seem wrong, and does seem to fix it. Linus --0000000000007e28af05e01651d2 Content-Type: text/x-patch; charset="US-ASCII"; name="patch.diff" Content-Disposition: attachment; filename="patch.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l3q6oh0p0 IGluY2x1ZGUvZHJtL2RybV9lZGlkLmggfCA2ICsrKy0tLQogMSBmaWxlIGNoYW5nZWQsIDMgaW5z ZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9pbmNsdWRlL2RybS9kcm1f ZWRpZC5oIGIvaW5jbHVkZS9kcm0vZHJtX2VkaWQuaAppbmRleCBjMzIwNGE1OGZiMDkuLmIyNzU2 NzUzMzcwYiAxMDA2NDQKLS0tIGEvaW5jbHVkZS9kcm0vZHJtX2VkaWQuaAorKysgYi9pbmNsdWRl L2RybS9kcm1fZWRpZC5oCkBAIC0xMjEsNyArMTIxLDcgQEAgc3RydWN0IGRldGFpbGVkX2RhdGFf bW9uaXRvcl9yYW5nZSB7CiAJCQl1OCBzdXBwb3J0ZWRfc2NhbGluZ3M7CiAJCQl1OCBwcmVmZXJy ZWRfcmVmcmVzaDsKIAkJfSBfX2F0dHJpYnV0ZV9fKChwYWNrZWQpKSBjdnQ7Ci0JfSBmb3JtdWxh OworCX0gX19hdHRyaWJ1dGVfXygocGFja2VkKSkgZm9ybXVsYTsKIH0gX19hdHRyaWJ1dGVfXygo cGFja2VkKSk7CiAKIHN0cnVjdCBkZXRhaWxlZF9kYXRhX3dwaW5kZXggewpAQCAtMTU0LDcgKzE1 NCw3IEBAIHN0cnVjdCBkZXRhaWxlZF9ub25fcGl4ZWwgewogCQlzdHJ1Y3QgZGV0YWlsZWRfZGF0 YV93cGluZGV4IGNvbG9yOwogCQlzdHJ1Y3Qgc3RkX3RpbWluZyB0aW1pbmdzWzZdOwogCQlzdHJ1 Y3QgY3Z0X3RpbWluZyBjdnRbNF07Ci0JfSBkYXRhOworCX0gX19hdHRyaWJ1dGVfXygocGFja2Vk KSkgZGF0YTsKIH0gX19hdHRyaWJ1dGVfXygocGFja2VkKSk7CiAKICNkZWZpbmUgRURJRF9ERVRB SUxfRVNUX1RJTUlOR1MgMHhmNwpAQCAtMTcyLDcgKzE3Miw3IEBAIHN0cnVjdCBkZXRhaWxlZF90 aW1pbmcgewogCXVuaW9uIHsKIAkJc3RydWN0IGRldGFpbGVkX3BpeGVsX3RpbWluZyBwaXhlbF9k YXRhOwogCQlzdHJ1Y3QgZGV0YWlsZWRfbm9uX3BpeGVsIG90aGVyX2RhdGE7Ci0JfSBkYXRhOwor CX0gX19hdHRyaWJ1dGVfXygocGFja2VkKSkgZGF0YTsKIH0gX19hdHRyaWJ1dGVfXygocGFja2Vk KSk7CiAKICNkZWZpbmUgRFJNX0VESURfSU5QVVRfU0VSUkFUSU9OX1ZTWU5DICgxIDw8IDApCg== --0000000000007e28af05e01651d2-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B73DC433EF for ; Sat, 28 May 2022 18:09:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3B29410E79D; Sat, 28 May 2022 18:09:11 +0000 (UTC) Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 93C9B10E79D for ; Sat, 28 May 2022 18:09:09 +0000 (UTC) Received: by mail-ej1-x62c.google.com with SMTP id f21so13979530ejh.11 for ; Sat, 28 May 2022 11:09:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iGqp3sqIQ6D1oqU2b3UQ+JQ14av/DX22LG0p5NM1mUo=; b=Px8PhLWYRiqNg8y87VlDUDsLJH2RoVnLN8Jl2LVu1LymXQyB5v2VGxblVmbq7n6ao8 VU3hqglYO5WBsoT19tAqis2S52THyYxULaMlPuhCVc+o+wPTrAjTjNWJDkwjJ3dtGVFj 8QZXFAV7pfp7xwqlA1vAGNq2rUWHaa1b3lzak= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iGqp3sqIQ6D1oqU2b3UQ+JQ14av/DX22LG0p5NM1mUo=; b=6Hx3JuKIZPb1Ml3WQa4t5vCi5RZ7s3/yz7pdFcSCw9zK28LsQ225/Je2xpfpcIuwpk Qvop84dn4DidO9mdFnYKGYxjA/MnwwzieuIV9idS3cFHmslbEFcPgc8ilU5G7e+9Y4hV 4BcJTucygn0eUhcVGsKXsHn3m43rbSWdHRu3L5/MJhXX6/19I+3X+g9g0SdI6tKU3BgZ dDm23e6GmN0rpAFgwUqMbjDfKma/qUecbNxRzCT+OCLvhOfL+RYEEkijlBrcqTGvqME5 fu/640dTey99xKshVoILU6B0qWmu1SZAWNTEtNig4fPrQD3AM+EsQhf/eqU9AOZLpIZr g/mw== X-Gm-Message-State: AOAM532cLtI3oVZ//+rxJvhv1TefRhHL4OF3nGdaClKsaf5ysODBseFM rznLDCbinE87gTfLLSqMUrcdIomES9yTfkqN X-Google-Smtp-Source: ABdhPJzgV68iCjipRfb9cTBuczhfoWvmfxyqJsynjP1RVJRs75BLXl7OEqYx4WD55VS5rjvUtLTegA== X-Received: by 2002:a17:907:8a1c:b0:6fe:e53b:22ca with SMTP id sc28-20020a1709078a1c00b006fee53b22camr27864738ejc.407.1653761347720; Sat, 28 May 2022 11:09:07 -0700 (PDT) Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com. [209.85.221.45]) by smtp.gmail.com with ESMTPSA id bo17-20020a170906d05100b006fe98fb9523sm2538345ejb.129.2022.05.28.11.09.05 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 28 May 2022 11:09:05 -0700 (PDT) Received: by mail-wr1-f45.google.com with SMTP id p10so9695043wrg.12 for ; Sat, 28 May 2022 11:09:05 -0700 (PDT) X-Received: by 2002:a05:6000:16c4:b0:20f:cd5d:4797 with SMTP id h4-20020a05600016c400b0020fcd5d4797mr28588153wrf.193.1653761344659; Sat, 28 May 2022 11:09:04 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Linus Torvalds Date: Sat, 28 May 2022 11:08:48 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: mainline build failure due to f1e4c916f97f ("drm/edid: add EDID block count and size helpers") To: Sudip Mukherjee , Russell King , Arnd Bergmann , Viresh Kumar , Shiraz Hashim Content-Type: multipart/mixed; boundary="0000000000007e28af05e01651d2" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux ARM , Jani Nikula , Linux Kernel Mailing List , David Airlie , SoC Team , dri-devel , Thomas Zimmermann Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --0000000000007e28af05e01651d2 Content-Type: text/plain; charset="UTF-8" On Sat, May 28, 2022 at 10:40 AM Linus Torvalds wrote: > > So digging a bit deeper - since I have am arm compiler after all - I > note that 'sizeof(detailed_timings)' is 88. Hmm. sizeof() both detailed_timings[0].data.other_data.data.range.formula.gtf2 and detailed_timings[0].data.other_data.data.range.formula.cvt is 7. But the *union* of those things is detailed_timings[0].data.other_data.data.range.formula and its size is 8 (despite having an alignment of just 1). The attached patch would seem to fix it for me. Not very much tested, and I have no idea what it is that triggers this only on spear3xx_defconfig. Some ARM ABI issue that is triggered by some very particular ARM compiler flag enabled by that config? Adding some ARM (and SPEAR, and SoC) people in case they have any idea. This smells like a compiler bug triggered by "there's a 16-bit member field in that gtf2 structure, and despite it being packed and aligned to 1, we somehow still align the size to 2". I dunno. But marking those unions packed too doesn't seem wrong, and does seem to fix it. Linus --0000000000007e28af05e01651d2 Content-Type: text/x-patch; charset="US-ASCII"; name="patch.diff" Content-Disposition: attachment; filename="patch.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l3q6oh0p0 IGluY2x1ZGUvZHJtL2RybV9lZGlkLmggfCA2ICsrKy0tLQogMSBmaWxlIGNoYW5nZWQsIDMgaW5z ZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9pbmNsdWRlL2RybS9kcm1f ZWRpZC5oIGIvaW5jbHVkZS9kcm0vZHJtX2VkaWQuaAppbmRleCBjMzIwNGE1OGZiMDkuLmIyNzU2 NzUzMzcwYiAxMDA2NDQKLS0tIGEvaW5jbHVkZS9kcm0vZHJtX2VkaWQuaAorKysgYi9pbmNsdWRl L2RybS9kcm1fZWRpZC5oCkBAIC0xMjEsNyArMTIxLDcgQEAgc3RydWN0IGRldGFpbGVkX2RhdGFf bW9uaXRvcl9yYW5nZSB7CiAJCQl1OCBzdXBwb3J0ZWRfc2NhbGluZ3M7CiAJCQl1OCBwcmVmZXJy ZWRfcmVmcmVzaDsKIAkJfSBfX2F0dHJpYnV0ZV9fKChwYWNrZWQpKSBjdnQ7Ci0JfSBmb3JtdWxh OworCX0gX19hdHRyaWJ1dGVfXygocGFja2VkKSkgZm9ybXVsYTsKIH0gX19hdHRyaWJ1dGVfXygo cGFja2VkKSk7CiAKIHN0cnVjdCBkZXRhaWxlZF9kYXRhX3dwaW5kZXggewpAQCAtMTU0LDcgKzE1 NCw3IEBAIHN0cnVjdCBkZXRhaWxlZF9ub25fcGl4ZWwgewogCQlzdHJ1Y3QgZGV0YWlsZWRfZGF0 YV93cGluZGV4IGNvbG9yOwogCQlzdHJ1Y3Qgc3RkX3RpbWluZyB0aW1pbmdzWzZdOwogCQlzdHJ1 Y3QgY3Z0X3RpbWluZyBjdnRbNF07Ci0JfSBkYXRhOworCX0gX19hdHRyaWJ1dGVfXygocGFja2Vk KSkgZGF0YTsKIH0gX19hdHRyaWJ1dGVfXygocGFja2VkKSk7CiAKICNkZWZpbmUgRURJRF9ERVRB SUxfRVNUX1RJTUlOR1MgMHhmNwpAQCAtMTcyLDcgKzE3Miw3IEBAIHN0cnVjdCBkZXRhaWxlZF90 aW1pbmcgewogCXVuaW9uIHsKIAkJc3RydWN0IGRldGFpbGVkX3BpeGVsX3RpbWluZyBwaXhlbF9k YXRhOwogCQlzdHJ1Y3QgZGV0YWlsZWRfbm9uX3BpeGVsIG90aGVyX2RhdGE7Ci0JfSBkYXRhOwor CX0gX19hdHRyaWJ1dGVfXygocGFja2VkKSkgZGF0YTsKIH0gX19hdHRyaWJ1dGVfXygocGFja2Vk KSk7CiAKICNkZWZpbmUgRFJNX0VESURfSU5QVVRfU0VSUkFUSU9OX1ZTWU5DICgxIDw8IDApCg== --0000000000007e28af05e01651d2-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78C80C433F5 for ; Sat, 28 May 2022 18:18:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:Cc:To:Subject: Message-ID:Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=L492xrUCyvORoqF4x7Y8VXTAv6wgf80D3oPxKpNaNF8=; b=mC4/i9PNfFImto3CGRuS49dcC0 UuMu4T9RXb6DV5hG+uOSx+0evT2q+7iC651+Cgm8Be/KPdL9Uye2I888njfHwKEI9RpdI8tGsyrQ4 qzUJan7iwF6dkJZ+zoHbDiZn+aCnexPrCTAtZfAjwtEilteOATmWkcPgDKULftOzTuZc1aurgxqqU ffS8UvDiXlJV30SGjnRZJq8CUp2M2bZbI31qNCxZvqbwFtENvEdz7G+sLZdYNYp1d2CK+9pbKA2t7 GLswsfj31/rA4qc5nqIO8PlZO7ysjbkHG2fx0n8jLsUASFbbTy2fFsu3Xa9lN7IBdYyF3Q23PYoBs 1840+miQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nv0zA-002Wcq-9o; Sat, 28 May 2022 18:16:24 +0000 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nv0z7-002Wc4-EG for linux-arm-kernel@lists.infradead.org; Sat, 28 May 2022 18:16:22 +0000 Received: by mail-ej1-x62a.google.com with SMTP id n10so14111376ejk.5 for ; Sat, 28 May 2022 11:16:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iGqp3sqIQ6D1oqU2b3UQ+JQ14av/DX22LG0p5NM1mUo=; b=Px8PhLWYRiqNg8y87VlDUDsLJH2RoVnLN8Jl2LVu1LymXQyB5v2VGxblVmbq7n6ao8 VU3hqglYO5WBsoT19tAqis2S52THyYxULaMlPuhCVc+o+wPTrAjTjNWJDkwjJ3dtGVFj 8QZXFAV7pfp7xwqlA1vAGNq2rUWHaa1b3lzak= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iGqp3sqIQ6D1oqU2b3UQ+JQ14av/DX22LG0p5NM1mUo=; b=AMRO8i76KLVmdSL2fdnmgDuo9ehleDhH30kj18DD+ivn8YIXcs7qqcUHO9NEpti0Yz 68MTbfhs+BZrrZg0sxnQbQwv+8meMo/0O/SooleD49K+WPFyNdbwHmz32fVU8ogc2NEa 9CmHjC8tLVeOIewyfTpmZ7L1Cpi4E+6j07HPREiYZ8HCwtIxGsvUryuvqWdMy31JE8QW DIYtG1izIscCWltNn5NtIAKqi+YyJCOxNMETCQnpu69fX36q4yZalHpbEyLLVl+XngS9 zhFhzHdxjgPGbxHSCsT5ec9iAHGMdKEqHmVa6fHH8DA3bvs8Qviu+GK219DRLNmzTOza aIaQ== X-Gm-Message-State: AOAM531EHZJ7o4Iag1wM3ACOVPfSWMu/aa/Xingwtr37RtJwQ8xOl/Pj 75i45FQnChrc119treBxTATcDfrYp030ew1AxLs= X-Google-Smtp-Source: ABdhPJxNOS7TWl/IZPiC/SS9/auX5WMEupFsXtpvmP/w75xIk2XLzIDEa+IXdTYDmisiZL/89kn/Dw== X-Received: by 2002:a17:907:98c4:b0:6fe:a1e6:eae5 with SMTP id kd4-20020a17090798c400b006fea1e6eae5mr38631472ejc.309.1653761778702; Sat, 28 May 2022 11:16:18 -0700 (PDT) Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com. [209.85.218.47]) by smtp.gmail.com with ESMTPSA id qq21-20020a17090720d500b006fea2035036sm2624947ejb.86.2022.05.28.11.16.18 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 28 May 2022 11:16:18 -0700 (PDT) Received: by mail-ej1-f47.google.com with SMTP id wh22so14113834ejb.7 for ; Sat, 28 May 2022 11:16:18 -0700 (PDT) X-Received: by 2002:a05:6000:16c4:b0:20f:cd5d:4797 with SMTP id h4-20020a05600016c400b0020fcd5d4797mr28588153wrf.193.1653761344659; Sat, 28 May 2022 11:09:04 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Linus Torvalds Date: Sat, 28 May 2022 11:08:48 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: mainline build failure due to f1e4c916f97f ("drm/edid: add EDID block count and size helpers") To: Sudip Mukherjee , Russell King , Arnd Bergmann , Viresh Kumar , Shiraz Hashim Cc: Jani Nikula , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel , Linux Kernel Mailing List , Linux ARM , SoC Team Content-Type: multipart/mixed; boundary="0000000000007e28af05e01651d2" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220528_111621_521861_0027896C X-CRM114-Status: GOOD ( 21.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --0000000000007e28af05e01651d2 Content-Type: text/plain; charset="UTF-8" On Sat, May 28, 2022 at 10:40 AM Linus Torvalds wrote: > > So digging a bit deeper - since I have am arm compiler after all - I > note that 'sizeof(detailed_timings)' is 88. Hmm. sizeof() both detailed_timings[0].data.other_data.data.range.formula.gtf2 and detailed_timings[0].data.other_data.data.range.formula.cvt is 7. But the *union* of those things is detailed_timings[0].data.other_data.data.range.formula and its size is 8 (despite having an alignment of just 1). The attached patch would seem to fix it for me. Not very much tested, and I have no idea what it is that triggers this only on spear3xx_defconfig. Some ARM ABI issue that is triggered by some very particular ARM compiler flag enabled by that config? Adding some ARM (and SPEAR, and SoC) people in case they have any idea. This smells like a compiler bug triggered by "there's a 16-bit member field in that gtf2 structure, and despite it being packed and aligned to 1, we somehow still align the size to 2". I dunno. But marking those unions packed too doesn't seem wrong, and does seem to fix it. Linus --0000000000007e28af05e01651d2 Content-Type: text/x-patch; charset="US-ASCII"; name="patch.diff" Content-Disposition: attachment; filename="patch.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l3q6oh0p0 IGluY2x1ZGUvZHJtL2RybV9lZGlkLmggfCA2ICsrKy0tLQogMSBmaWxlIGNoYW5nZWQsIDMgaW5z ZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9pbmNsdWRlL2RybS9kcm1f ZWRpZC5oIGIvaW5jbHVkZS9kcm0vZHJtX2VkaWQuaAppbmRleCBjMzIwNGE1OGZiMDkuLmIyNzU2 NzUzMzcwYiAxMDA2NDQKLS0tIGEvaW5jbHVkZS9kcm0vZHJtX2VkaWQuaAorKysgYi9pbmNsdWRl L2RybS9kcm1fZWRpZC5oCkBAIC0xMjEsNyArMTIxLDcgQEAgc3RydWN0IGRldGFpbGVkX2RhdGFf bW9uaXRvcl9yYW5nZSB7CiAJCQl1OCBzdXBwb3J0ZWRfc2NhbGluZ3M7CiAJCQl1OCBwcmVmZXJy ZWRfcmVmcmVzaDsKIAkJfSBfX2F0dHJpYnV0ZV9fKChwYWNrZWQpKSBjdnQ7Ci0JfSBmb3JtdWxh OworCX0gX19hdHRyaWJ1dGVfXygocGFja2VkKSkgZm9ybXVsYTsKIH0gX19hdHRyaWJ1dGVfXygo cGFja2VkKSk7CiAKIHN0cnVjdCBkZXRhaWxlZF9kYXRhX3dwaW5kZXggewpAQCAtMTU0LDcgKzE1 NCw3IEBAIHN0cnVjdCBkZXRhaWxlZF9ub25fcGl4ZWwgewogCQlzdHJ1Y3QgZGV0YWlsZWRfZGF0 YV93cGluZGV4IGNvbG9yOwogCQlzdHJ1Y3Qgc3RkX3RpbWluZyB0aW1pbmdzWzZdOwogCQlzdHJ1 Y3QgY3Z0X3RpbWluZyBjdnRbNF07Ci0JfSBkYXRhOworCX0gX19hdHRyaWJ1dGVfXygocGFja2Vk KSkgZGF0YTsKIH0gX19hdHRyaWJ1dGVfXygocGFja2VkKSk7CiAKICNkZWZpbmUgRURJRF9ERVRB SUxfRVNUX1RJTUlOR1MgMHhmNwpAQCAtMTcyLDcgKzE3Miw3IEBAIHN0cnVjdCBkZXRhaWxlZF90 aW1pbmcgewogCXVuaW9uIHsKIAkJc3RydWN0IGRldGFpbGVkX3BpeGVsX3RpbWluZyBwaXhlbF9k YXRhOwogCQlzdHJ1Y3QgZGV0YWlsZWRfbm9uX3BpeGVsIG90aGVyX2RhdGE7Ci0JfSBkYXRhOwor CX0gX19hdHRyaWJ1dGVfXygocGFja2VkKSkgZGF0YTsKIH0gX19hdHRyaWJ1dGVfXygocGFja2Vk KSk7CiAKICNkZWZpbmUgRFJNX0VESURfSU5QVVRfU0VSUkFUSU9OX1ZTWU5DICgxIDw8IDApCg== --0000000000007e28af05e01651d2 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --0000000000007e28af05e01651d2--