From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D40A2C433DB for ; Thu, 28 Jan 2021 17:18:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7E71664E0E for ; Thu, 28 Jan 2021 17:18:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233067AbhA1RRp (ORCPT ); Thu, 28 Jan 2021 12:17:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232644AbhA1RPC (ORCPT ); Thu, 28 Jan 2021 12:15:02 -0500 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96831C061756 for ; Thu, 28 Jan 2021 09:14:46 -0800 (PST) Received: by mail-lj1-x230.google.com with SMTP id s18so7249987ljg.7 for ; Thu, 28 Jan 2021 09:14:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1jP5+AXxY87glZREeLAva697y16ZgEKsRQdrGKC7/24=; b=IzlIONI5ZD7sazxanJ7imKPu5j46GJZbzYiCdDH44cawOwKT7+MdIqBtfRSeHC0Fl7 DJFru1FDRkDE+8ZsWTttKWAENGh8/+SsHsS0NvWQh4RJyEoPcVosX0NBSaWBdfe9HCUK eY+J5EOAv1KdST2NPvSmgzXDmoCaJiw45vbYM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1jP5+AXxY87glZREeLAva697y16ZgEKsRQdrGKC7/24=; b=LWqWS2XQmfHIX/Rr7H3yJuIsOMQ2EiikgZr1GJpGbSdQyEKossZMOf1AT/sz14S8f7 RyPqMq9uwH2uxjY4/Ox5/7KRGhxRoYHzA/ovbCgZ68lZMdfNYNhv4F5Y+2Mx/69zpLq+ LLvy4EcRK+HePftSO4hg7R7JA5Cke0EYJlPa6TebpgT7VdFQ4nViQxlj94eGgsXfTQ3B gJHH7dwPJdru6bwzGcUikG8pZfqC/gx2UmSv8tuCWX7FS3pTD9TW53WbcfrxOHwBzFyP WpRlsNho3twThrMJtot2dVbdQqi+HOhGkG3Gp8FMN+2k24GExM2lQwjwXBkLwVzR2gRt 2SkA== X-Gm-Message-State: AOAM532PeogbVlmHI6Bq60ZHAd0LNmueKkKnpc2U0/7/P9rHXITp/C2+ jUAjMQOPAXZTAcCPv0BoTNL/d5q7HBJ6IQ== X-Google-Smtp-Source: ABdhPJxbQlWNAi+QWTYUk71Qty21N+0zaLP12cljFk6h6LXHCwNF/pkkfSudR6PsmvZELn1GHrihyA== X-Received: by 2002:a2e:b4c9:: with SMTP id r9mr162655ljm.100.1611854084661; Thu, 28 Jan 2021 09:14:44 -0800 (PST) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com. [209.85.167.53]) by smtp.gmail.com with ESMTPSA id e7sm2204378ljo.74.2021.01.28.09.14.43 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Jan 2021 09:14:43 -0800 (PST) Received: by mail-lf1-f53.google.com with SMTP id u25so8596696lfc.2 for ; Thu, 28 Jan 2021 09:14:43 -0800 (PST) X-Received: by 2002:a19:c14c:: with SMTP id r73mr34684lff.201.1611854082655; Thu, 28 Jan 2021 09:14:42 -0800 (PST) MIME-Version: 1.0 References: <20210127235347.1402-1-will@kernel.org> In-Reply-To: <20210127235347.1402-1-will@kernel.org> From: Linus Torvalds Date: Thu, 28 Jan 2021 09:14:24 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 0/6] tlb: Fix (soft-)dirty bit management & clean up API To: Will Deacon Cc: Linux Kernel Mailing List , Android Kernel Team , Linux-MM , Yu Zhao , Minchan Kim , Peter Zijlstra , Thomas Gleixner , Vlastimil Babka , Mohamed Alzayat , "Aneesh Kumar K.V" , Nadav Amit , Andrea Arcangeli Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 27, 2021 at 3:54 PM Will Deacon wrote: > > The objective is to fix the lacklustre TLB invalidation on the clear_refs > path and then augment the mmu_gather API to make it more difficult to > abuse. The series continues to look good to me. I don't love our "tlb_flush_pending" hackery, but it is what it is, and at least this series cleans up the proper flushing interfaces. Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28C0CC433DB for ; Thu, 28 Jan 2021 17:14:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7AF2264E21 for ; Thu, 28 Jan 2021 17:14:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7AF2264E21 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 97EE16B0005; Thu, 28 Jan 2021 12:14:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 92EFF6B0070; Thu, 28 Jan 2021 12:14:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CFA76B0072; Thu, 28 Jan 2021 12:14:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0196.hostedemail.com [216.40.44.196]) by kanga.kvack.org (Postfix) with ESMTP id 64FD26B0005 for ; Thu, 28 Jan 2021 12:14:46 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 288E71F08 for ; Thu, 28 Jan 2021 17:14:46 +0000 (UTC) X-FDA: 77755833372.25.coal30_5705297275a1 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id EF8921804E3C4 for ; Thu, 28 Jan 2021 17:14:45 +0000 (UTC) X-HE-Tag: coal30_5705297275a1 X-Filterd-Recvd-Size: 3930 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Thu, 28 Jan 2021 17:14:45 +0000 (UTC) Received: by mail-lf1-f46.google.com with SMTP id q8so8576773lfm.10 for ; Thu, 28 Jan 2021 09:14:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1jP5+AXxY87glZREeLAva697y16ZgEKsRQdrGKC7/24=; b=IzlIONI5ZD7sazxanJ7imKPu5j46GJZbzYiCdDH44cawOwKT7+MdIqBtfRSeHC0Fl7 DJFru1FDRkDE+8ZsWTttKWAENGh8/+SsHsS0NvWQh4RJyEoPcVosX0NBSaWBdfe9HCUK eY+J5EOAv1KdST2NPvSmgzXDmoCaJiw45vbYM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1jP5+AXxY87glZREeLAva697y16ZgEKsRQdrGKC7/24=; b=tnRHOTXK9B2lW8jfgLdfTl2gOEXQKilJDjTfzmwVypySUdKvIQHq2zG/+in9K9BfPh 7fgvodEKaVekSIEphKUD8Y1VAg0flNR7ak2+XvPn+bU2nW2pBf4bE2SceCKqo5/IlxVx z5IFpUKDZq/e+NGkZBToQbUslCJQ+LR61FKlv7ufRuZ3XVT9w37ohjSO0nJi8g5O4AfN 8+g63gRux+HoazVHQmIWOIHG2wuB1yVn7dbW+mUs2I2eBex+Vve/xzryT8+8k2qGzV91 HquqQR4rNEDhqhv9m9Pb7q7RwWbGqv/PnQnCYh1F7vLLHMqww5FQTG4I5T/ENaXt3syy 2aQA== X-Gm-Message-State: AOAM530KxiubJbjhtcCG5gaX3RJMfvNsFQjd6pPplj00l2pPkg+r7lDR 4hFjdORcZqITDyimnxSX2qHuY3bnneygiQ== X-Google-Smtp-Source: ABdhPJzcxLW/azhzyhEPz8cyNdmuMZLaVxKt73RLtMBsFUUkldp/GdhflFUifVSkGiBgOjlrrjVtfw== X-Received: by 2002:a19:834a:: with SMTP id f71mr34368lfd.247.1611854083869; Thu, 28 Jan 2021 09:14:43 -0800 (PST) Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com. [209.85.167.45]) by smtp.gmail.com with ESMTPSA id u13sm2174987ljk.16.2021.01.28.09.14.43 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Jan 2021 09:14:43 -0800 (PST) Received: by mail-lf1-f45.google.com with SMTP id i187so8607691lfd.4 for ; Thu, 28 Jan 2021 09:14:43 -0800 (PST) X-Received: by 2002:a19:c14c:: with SMTP id r73mr34684lff.201.1611854082655; Thu, 28 Jan 2021 09:14:42 -0800 (PST) MIME-Version: 1.0 References: <20210127235347.1402-1-will@kernel.org> In-Reply-To: <20210127235347.1402-1-will@kernel.org> From: Linus Torvalds Date: Thu, 28 Jan 2021 09:14:24 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 0/6] tlb: Fix (soft-)dirty bit management & clean up API To: Will Deacon Cc: Linux Kernel Mailing List , Android Kernel Team , Linux-MM , Yu Zhao , Minchan Kim , Peter Zijlstra , Thomas Gleixner , Vlastimil Babka , Mohamed Alzayat , "Aneesh Kumar K.V" , Nadav Amit , Andrea Arcangeli Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 27, 2021 at 3:54 PM Will Deacon wrote: > > The objective is to fix the lacklustre TLB invalidation on the clear_refs > path and then augment the mmu_gather API to make it more difficult to > abuse. The series continues to look good to me. I don't love our "tlb_flush_pending" hackery, but it is what it is, and at least this series cleans up the proper flushing interfaces. Linus