From: Linus Torvalds <torvalds@linux-foundation.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: dan.carpenter@oracle.com, adilger.kernel@dilger.ca,
yamada.masahiro@socionext.com, michal.lkml@markovi.net,
rostedt@goodmis.org, mchehab+samsung@kernel.org, olof@lxom.net,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
David Miller <davem@davemloft.net>,
Kees Cook <keescook@chromium.org>,
tglx@linutronix.de, Ingo Molnar <mingo@kernel.org>,
paullawrence@google.com, sandipan@linux.vnet.ibm.com,
andreyknvl@google.com, David Woodhouse <dwmw2@infradead.org>,
will.deacon@arm.com, Philippe Ombredanne <pombredanne@nexb.com>,
paul.burton@mips.com, rientjes@google.com, w@1wt.eu,
msebor@gmail.com, sparse@chrisli.org,
Jonathan Corbet <corbet@lwn.net>, "Theodore Ts'o" <tytso@mit.edu>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
joe@perches.com, Arnd Bergmann <arnd@arndb.de>,
asmadeus@codewreck.org, stefan@agner.ch,
luc.vanoostenryck@gmail.com,
Nick Desaulniers <ndesaulniers@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Greg KH <gregkh@linuxfoundation.org>,
linux-doc@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-sparse@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [GIT PULL] Compiler Attributes for v4.20-rc1
Date: Thu, 1 Nov 2018 18:46:17 -0700 [thread overview]
Message-ID: <CAHk-=widcG7zGELniGoqjPyBZAHehA_Gyi2n1aRO94G7SBzwNQ@mail.gmail.com> (raw)
In-Reply-To: <CAHk-=whpBiV5sVTvPsWOVx5WYOouxbNG1fWeCdpK4oFiaH0Zqg@mail.gmail.com>
On Thu, Nov 1, 2018 at 10:06 AM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> The logic for using __no_sanitize_address *used* to be
>
> #if GCC_VERSION >= 40902
Ok, looking around, I think this has less to do with the attribute
being recognized, and simply just being because KASAN itself wants
gcc-4.9.2.
I'm actually not seeing that KASAN dependency in the Kconfig scripts
(and it probably _should_ be now that we can just add compiler version
dependencies there), but that explains why the gcc version check is
different from "gcc supports the attribute".
Anyway, I decided to do the merge by just getting rid of the
GCC_VERSION check around __no_sanitize_address_or_inline entirely. If
you enable KASAN, then a function with that marking just won't be
marked inline.
End result: pulled. I'm as confused as you are as to why
__no_sanitize_address_or_inline is in the gcc header, but I guess it
ends up being the same issue: KASAN depends on gcc even if that
dependency doesn't seem to be spelled out in lib/Kconfig.kasan.
So I _think_ the KASAN config should have a
depends on CC_IS_GCC && GCC_VERSION >= 40902
on it, but maybe there is something I'm missing.
But from a pull standpoint, I don't want to mess with those
(unrelated) issues, so I just kept the merge resolution as simple and
straightforward as possible.
Miguel, please do double-check the merge (it's not pushed out yet, I'm
doing the usual build tests etc first).
Linus
next prev parent reply other threads:[~2018-11-02 10:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-22 10:59 [GIT PULL] Compiler Attributes for v4.20-rc1 Miguel Ojeda
2018-10-22 10:59 ` Miguel Ojeda
2018-11-01 17:06 ` Linus Torvalds
2018-11-01 20:15 ` Miguel Ojeda
2018-11-02 1:46 ` Linus Torvalds [this message]
2018-11-02 10:13 ` Miguel Ojeda
2018-11-02 13:17 ` Andrey Ryabinin
2018-11-02 16:11 ` Linus Torvalds
2018-11-02 16:59 ` Andrey Ryabinin
2018-11-02 9:44 ` Andrey Ryabinin
2018-11-02 16:09 ` Linus Torvalds
2018-11-05 6:02 ` Martin Schwidefsky
2018-11-05 13:15 ` Martin Schwidefsky
2018-11-05 13:15 ` Martin Schwidefsky
2018-11-05 14:31 ` Steven Rostedt
2018-11-05 16:14 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=widcG7zGELniGoqjPyBZAHehA_Gyi2n1aRO94G7SBzwNQ@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=arnd@arndb.de \
--cc=aryabinin@virtuozzo.com \
--cc=asmadeus@codewreck.org \
--cc=corbet@lwn.net \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=dwmw2@infradead.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=konstantin@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=luc.vanoostenryck@gmail.com \
--cc=mchehab+samsung@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=mingo@kernel.org \
--cc=msebor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=olof@lxom.net \
--cc=paul.burton@mips.com \
--cc=paullawrence@google.com \
--cc=pombredanne@nexb.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=sandipan@linux.vnet.ibm.com \
--cc=sparse@chrisli.org \
--cc=stefan@agner.ch \
--cc=tglx@linutronix.de \
--cc=tytso@mit.edu \
--cc=w@1wt.eu \
--cc=will.deacon@arm.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.