From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79CE0C433F5 for ; Wed, 15 Sep 2021 01:14:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 60F2A60F23 for ; Wed, 15 Sep 2021 01:14:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231919AbhIOBP3 (ORCPT ); Tue, 14 Sep 2021 21:15:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230053AbhIOBP2 (ORCPT ); Tue, 14 Sep 2021 21:15:28 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25C37C061574 for ; Tue, 14 Sep 2021 18:14:10 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id i25so2476625lfg.6 for ; Tue, 14 Sep 2021 18:14:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YA7y9iBKi4yP4Rc/YesTbY6E2GjKmwv9lciu9v4UGxI=; b=UJuU81i1X1Vwx6sKy1nzNsRQdWA6iHFqLZo4hx/3uL/+A4fAVnd7gPryxK5koHCLvr b1PsJbA+x/bBSxtxnMa4xe7D9L7nw2ZXezaqqJHBcwaLE5s5u3GuZq5GJHv2nwdfasHF lIgFDigAQjL6M1oRTS8liK5ZTYXkIKCvimlK8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YA7y9iBKi4yP4Rc/YesTbY6E2GjKmwv9lciu9v4UGxI=; b=OoOkhaArHuHmYYbLAx1WBG+kXDqkigUOgNL/d7cCweNaR+TXHrTFNjqoF5onTDrANT GDl3ZPTIH8PS0Ejps0dBnhVn8vQN9BzoNuG+XEzNZRjgmFhxRnb08kYLLUxwCjSAG3WY hkJ+uzYsdYgfdtYN7rAGIoRC3srCMKobfiQ3zybhfqwtZru1f4RaSW04gNYqVUjk31W8 HKBzBmvUPrnwxB1ZzYCcs+kQBbwg0VmA+rjl9v0UQv1znQuxcwurR+cb2HxEqCmNTFHB w3AZfU8xGdBW/jhiMiPJlF8DX2FPaB1M3POhXWE8MA3IZCokk404+u6/vsHRKaulup9H 7bYg== X-Gm-Message-State: AOAM533lMtFxOFmOp50Ljm6MGImoR8O0rI5RI/CDBBBEL3D1AuGOb9dZ rARwditzM4NJ9RXfROM4acRBCc27zrBGsewOFd4= X-Google-Smtp-Source: ABdhPJwQv9zRn1kdSyp4qlizMvSjgMRaql3tv5EHmOZoGTnTSNi9nYuMu9Hoetp673VUEShm0tf11g== X-Received: by 2002:ac2:4ecf:: with SMTP id p15mr15081391lfr.2.1631668447723; Tue, 14 Sep 2021 18:14:07 -0700 (PDT) Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com. [209.85.208.180]) by smtp.gmail.com with ESMTPSA id v4sm1516760ljn.88.2021.09.14.18.14.07 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Sep 2021 18:14:07 -0700 (PDT) Received: by mail-lj1-f180.google.com with SMTP id j12so2050898ljg.10 for ; Tue, 14 Sep 2021 18:14:07 -0700 (PDT) X-Received: by 2002:a2e:8185:: with SMTP id e5mr17384664ljg.31.1631668446766; Tue, 14 Sep 2021 18:14:06 -0700 (PDT) MIME-Version: 1.0 References: <163166717752.510331.12843735095061762373.stgit@devnote2> <163166721027.510331.6820619440348067061.stgit@devnote2> In-Reply-To: <163166721027.510331.6820619440348067061.stgit@devnote2> From: Linus Torvalds Date: Tue, 14 Sep 2021 18:13:51 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 4/5] bootconfig: Free copied bootconfig data after boot To: Masami Hiramatsu Cc: Steven Rostedt , Mike Rapoport , Andrew Morton , LKML , Ingo Molnar , Linux-MM , Vlastimil Babka Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 14, 2021 at 5:53 PM Masami Hiramatsu wrote: > > Free copied bootconfig data after booting kernel because that > data will not be used anymore. Don't do this. You have already passed in that 'copy' to the xbc code, and xbc_destroy_all() should just free it. Don't add new pointless variables to keep track of state that somebody else already keeps track of. Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FF72C433EF for ; Wed, 15 Sep 2021 01:14:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 207E461209 for ; Wed, 15 Sep 2021 01:14:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 207E461209 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id B289D6B0071; Tue, 14 Sep 2021 21:14:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ADA0E6B0072; Tue, 14 Sep 2021 21:14:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A02A900002; Tue, 14 Sep 2021 21:14:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0049.hostedemail.com [216.40.44.49]) by kanga.kvack.org (Postfix) with ESMTP id 8CC5F6B0071 for ; Tue, 14 Sep 2021 21:14:10 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 5268F1825AE07 for ; Wed, 15 Sep 2021 01:14:10 +0000 (UTC) X-FDA: 78588036660.06.8741FB7 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by imf11.hostedemail.com (Postfix) with ESMTP id 1D87FF000200 for ; Wed, 15 Sep 2021 01:14:09 +0000 (UTC) Received: by mail-lj1-f178.google.com with SMTP id j12so2051039ljg.10 for ; Tue, 14 Sep 2021 18:14:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YA7y9iBKi4yP4Rc/YesTbY6E2GjKmwv9lciu9v4UGxI=; b=UJuU81i1X1Vwx6sKy1nzNsRQdWA6iHFqLZo4hx/3uL/+A4fAVnd7gPryxK5koHCLvr b1PsJbA+x/bBSxtxnMa4xe7D9L7nw2ZXezaqqJHBcwaLE5s5u3GuZq5GJHv2nwdfasHF lIgFDigAQjL6M1oRTS8liK5ZTYXkIKCvimlK8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YA7y9iBKi4yP4Rc/YesTbY6E2GjKmwv9lciu9v4UGxI=; b=pT6HjhmQMJH7zG09hn2BuGUMMOCoCPbReTEMuQQmp8BmxBx/E0GNFIEJ+jrObL64EQ 2ue62SxoRbEoRKxa5tt09k4hcPNfy3r5xb49qT/IGsObYEZk2rQ7SPHYP86m8hJQntfX vlOMa3HeGUYPLsduC5+NN8BfUp5+M8V6nRjczdx3ikF1o9/f/e0o34+78DfOCLNebA3o QJPvT+MbS5836ewkJdsIcE9SstwAwdr6uschbUX6jxMe+TUxvyf57gcdSsuQ8liyItsQ oHK3LLZgfeYbuYkBYDp5aDGoBR7i92SAXAmqIQ5ifH2QV2m+b51+obH3RMj4uWiaioBa vpNA== X-Gm-Message-State: AOAM532Z+d4K5rBO7bCNxHnPSBxoU1m5BarMUoYjsgmw2T/lnkyZd4x/ 1g7KfFBPntMS0vn1zOmfKVNFyFwyUElPKLtU0Yg= X-Google-Smtp-Source: ABdhPJxisfvBONevtcNaedhByCGfa5b/KFWZiyuiGoOk/cY8yY4g65a29zYI/OUy4BJWu0FSxA6UXA== X-Received: by 2002:a2e:7503:: with SMTP id q3mr17783654ljc.48.1631668448155; Tue, 14 Sep 2021 18:14:08 -0700 (PDT) Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com. [209.85.208.173]) by smtp.gmail.com with ESMTPSA id c22sm1252335lfm.113.2021.09.14.18.14.06 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Sep 2021 18:14:07 -0700 (PDT) Received: by mail-lj1-f173.google.com with SMTP id w4so2013145ljh.13 for ; Tue, 14 Sep 2021 18:14:06 -0700 (PDT) X-Received: by 2002:a2e:8185:: with SMTP id e5mr17384664ljg.31.1631668446766; Tue, 14 Sep 2021 18:14:06 -0700 (PDT) MIME-Version: 1.0 References: <163166717752.510331.12843735095061762373.stgit@devnote2> <163166721027.510331.6820619440348067061.stgit@devnote2> In-Reply-To: <163166721027.510331.6820619440348067061.stgit@devnote2> From: Linus Torvalds Date: Tue, 14 Sep 2021 18:13:51 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 4/5] bootconfig: Free copied bootconfig data after boot To: Masami Hiramatsu Cc: Steven Rostedt , Mike Rapoport , Andrew Morton , LKML , Ingo Molnar , Linux-MM , Vlastimil Babka Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 1D87FF000200 X-Stat-Signature: 8e68ew839whx6fkntuhruo9b4wromayj Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=UJuU81i1; spf=pass (imf11.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.178 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none X-HE-Tag: 1631668449-254359 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 14, 2021 at 5:53 PM Masami Hiramatsu wrote: > > Free copied bootconfig data after booting kernel because that > data will not be used anymore. Don't do this. You have already passed in that 'copy' to the xbc code, and xbc_destroy_all() should just free it. Don't add new pointless variables to keep track of state that somebody else already keeps track of. Linus