From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1141BC433B4 for ; Fri, 14 May 2021 19:23:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA06961454 for ; Fri, 14 May 2021 19:23:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230141AbhENTYX (ORCPT ); Fri, 14 May 2021 15:24:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232260AbhENTYW (ORCPT ); Fri, 14 May 2021 15:24:22 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEABCC061574 for ; Fri, 14 May 2021 12:23:10 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id c20so276942ejm.3 for ; Fri, 14 May 2021 12:23:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=l72hh61/tsn5KiliU7+ZN3a6OPF8Vv4B7h1Pke4bt3c=; b=aWXI51EnV/k9pge5GKaDOkkJQD5K/MYP7A5XMnLlSW2Sy2l/sTiI3B9cP8d8ZTB5m2 R3v2CKeD8i8Tb7rfnKNvLFWu6ekM3Dp1YyH8ufyfZgWCClPGJSZE/oeAn63KZeLaEQ45 fGizC1SmBVw+3SgkMIXS5j/6qsc7gTws56N4g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l72hh61/tsn5KiliU7+ZN3a6OPF8Vv4B7h1Pke4bt3c=; b=I2mO1DVqt28ZFpdFUKEAH+k7yUCZspaA1nFSMeA8QHBDm7c3og+r0hgaIIdwnz8K8/ BRxHI4qz7j5eKjDKZuANFN0ZO4HtAP/d02jJdGOssYU8H5q4q7szjivT74iGs938+0t/ JkIaLwGuDgb9puN44fpYzUPR1STehstDnFKUYtRvYAEvbQb3jcdEWAIZiBiyPkwA+XcN ouIEiTAtQ8luB3SiEmQQJM8q1YBAj6s0IN8S0dCGqL+E/mFS03wjm+xMD0jB0hJZksf6 r0FYRMd0TzMdDXFRvSdX0GBVdgjGbwZFunuwLfhlZoXFyPam9sPoAIMgGA5p9NazuNex 0QMQ== X-Gm-Message-State: AOAM532+tfBWLPci0gpxRe3VKofQhJ5psJxZ3eIiKjszT1O009chMOCo Eks4svyHdD7+4D4LvuTMcIzxsezP0gS3YxWS4n4= X-Google-Smtp-Source: ABdhPJxATDBjkm/A/CPdiiYvj8IfFpYxx+iugphXX7+ViJ9nXgl8tv3WN64oo60NQ9AZ1Y0cQ7SwwA== X-Received: by 2002:a17:906:38c5:: with SMTP id r5mr47963221ejd.230.1621020189440; Fri, 14 May 2021 12:23:09 -0700 (PDT) Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com. [209.85.221.44]) by smtp.gmail.com with ESMTPSA id ju17sm4156227ejc.72.2021.05.14.12.23.08 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 May 2021 12:23:08 -0700 (PDT) Received: by mail-wr1-f44.google.com with SMTP id m9so295058wrx.3 for ; Fri, 14 May 2021 12:23:08 -0700 (PDT) X-Received: by 2002:a05:651c:33a:: with SMTP id b26mr40099556ljp.220.1621020178319; Fri, 14 May 2021 12:22:58 -0700 (PDT) MIME-Version: 1.0 References: <20210514100106.3404011-1-arnd@kernel.org> <2408c893-4ae7-4f53-f58c-497c91f5b034@synopsys.com> In-Reply-To: <2408c893-4ae7-4f53-f58c-497c91f5b034@synopsys.com> From: Linus Torvalds Date: Fri, 14 May 2021 12:22:42 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 00/13] Unify asm/unaligned.h around struct helper To: Vineet Gupta Cc: Arnd Bergmann , linux-arch , Arnd Bergmann , Amitkumar Karwar , Benjamin Herrenschmidt , Borislav Petkov , Eric Dumazet , Florian Fainelli , Ganapathi Bhat , Geert Uytterhoeven , "H. Peter Anvin" , Ingo Molnar , Jakub Kicinski , James Morris , Jens Axboe , John Johansen , Jonas Bonn , Kalle Valo , Michael Ellerman , Paul Mackerras , Rich Felker , "Richard Russon (FlatCap)" , Russell King , "Serge E. Hallyn" , Sharvari Harisangam , Stafford Horne , Stefan Kristiansson , Thomas Gleixner , Vladimir Oltean , Xinming Hu , Yoshinori Sato , "the arch/x86 maintainers" , Linux Kernel Mailing List , Linux ARM , linux-m68k , Linux Crypto Mailing List , "openrisc@lists.librecores.org" , linuxppc-dev , Linux-sh list , linux-sparc , "linux-ntfs-dev@lists.sourceforge.net" , linux-block , linux-wireless , Netdev , LSM List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org On Fri, May 14, 2021 at 11:52 AM Vineet Gupta wrote: > > Wasn't the new zlib code slated for 5.14. I don't see it in your master yet You're right, I never actually committed it, since it was specific to ARC and -O3 and I wasn't entirely happy with the amount of testing it got (with Heiko pointing out that the s390 stuff needed more fixes for the change). So in fact it's not even queued up for 5.14 due to this all, I just dropped it. > > and the biggy > > case didn't even use "get_unaligned()"). > > Indeed this series is sort of orthogonal to that bug, but IMO that bug > still exists in 5.13 for -O3 build, granted that is not enabled for !ARC. Right, the zlib bug is still there. But Arnd's series wouldn't even fix it: right now inffast has its own - ugly and slow - special 2-byte-only version of "get_unaligned()", called "get_unaligned16()". And because it's ugly and slow, it's not actually used for CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS. Vineet - maybe the fix is to not take my patch to update to a newer zlib, but to just fix inffast to use the proper get_unaligned(). Then Arnd's series _would_ actually fix all this.. Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD7D2C433B4 for ; Fri, 14 May 2021 19:29:04 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A9CC6145E for ; Fri, 14 May 2021 19:29:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A9CC6145E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Fhdqy3pHSz3bsH for ; Sat, 15 May 2021 05:29:02 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linux-foundation.org header.i=@linux-foundation.org header.a=rsa-sha256 header.s=google header.b=aWXI51En; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linuxfoundation.org (client-ip=2a00:1450:4864:20::22c; helo=mail-lj1-x22c.google.com; envelope-from=torvalds@linuxfoundation.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linux-foundation.org header.i=@linux-foundation.org header.a=rsa-sha256 header.s=google header.b=aWXI51En; dkim-atps=neutral Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4FhdqP4ykgz2yY7 for ; Sat, 15 May 2021 05:28:31 +1000 (AEST) Received: by mail-lj1-x22c.google.com with SMTP id s25so14432706ljo.11 for ; Fri, 14 May 2021 12:28:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=l72hh61/tsn5KiliU7+ZN3a6OPF8Vv4B7h1Pke4bt3c=; b=aWXI51EnV/k9pge5GKaDOkkJQD5K/MYP7A5XMnLlSW2Sy2l/sTiI3B9cP8d8ZTB5m2 R3v2CKeD8i8Tb7rfnKNvLFWu6ekM3Dp1YyH8ufyfZgWCClPGJSZE/oeAn63KZeLaEQ45 fGizC1SmBVw+3SgkMIXS5j/6qsc7gTws56N4g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l72hh61/tsn5KiliU7+ZN3a6OPF8Vv4B7h1Pke4bt3c=; b=PsMPGDuc1Rg05mCWTkMLKg2KkOhxzzyLrRUSrNw5EmBtdo6C+XCHWcHkY9zOEvKI7U vgiVrUWg4+Y/0dkWQBw1uKvftUnFMTLjEIvsIZNODJUkCBSeypYTrdy5/LmWlBiD1PPh dvYYuGTfKJwrcBLUI0a1B7phfEhPiN6tSvDpGbv2tZOlNhtcyfjdP5FVmxSuiNauCLVc XyW9ibhzoMEhkXM6+6CE+P+n28wg129zWtoQKw/wewHesAS4LK9pXYHUyZ/Bdnw4aNva K0nFTAhX1Xs7h6U3zgRSytBBdfIGNHAu6XswgLhF+tFnDSZgp6/2AKX0HLVLhboF3Zuy 4wgg== X-Gm-Message-State: AOAM531ZjJrUsuWK4zifIZybNFeSb9qoK+sTIZ/wg7LMvQUgUPH5dDSM U39vggc9KpTAe5Pfz6H5znQJQDzPUED6QQeDiRQ= X-Google-Smtp-Source: ABdhPJwVNknN0hgn4WXncRXX6pVmXIMV/7YWxVYFPTvlMIg76P8p/kVSqEXijeJvBGPjx7bcLqc0Bw== X-Received: by 2002:a2e:9c06:: with SMTP id s6mr38899931lji.508.1621020502561; Fri, 14 May 2021 12:28:22 -0700 (PDT) Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com. [209.85.208.171]) by smtp.gmail.com with ESMTPSA id z11sm909522lfr.73.2021.05.14.12.28.22 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 May 2021 12:28:22 -0700 (PDT) Received: by mail-lj1-f171.google.com with SMTP id e11so25566788ljn.13 for ; Fri, 14 May 2021 12:28:22 -0700 (PDT) X-Received: by 2002:a05:651c:33a:: with SMTP id b26mr40099556ljp.220.1621020178319; Fri, 14 May 2021 12:22:58 -0700 (PDT) MIME-Version: 1.0 References: <20210514100106.3404011-1-arnd@kernel.org> <2408c893-4ae7-4f53-f58c-497c91f5b034@synopsys.com> In-Reply-To: <2408c893-4ae7-4f53-f58c-497c91f5b034@synopsys.com> From: Linus Torvalds Date: Fri, 14 May 2021 12:22:42 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 00/13] Unify asm/unaligned.h around struct helper To: Vineet Gupta Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , Linux-sh list , "Richard Russon \(FlatCap\)" , Amitkumar Karwar , Russell King , Eric Dumazet , Paul Mackerras , "H. Peter Anvin" , linux-sparc , Thomas Gleixner , linux-arch , Florian Fainelli , Yoshinori Sato , the arch/x86 maintainers , James Morris , Ingo Molnar , Geert Uytterhoeven , Linux ARM , Jakub Kicinski , "Serge E. Hallyn" , Jonas Bonn , Arnd Bergmann , Ganapathi Bhat , Stefan Kristiansson , linux-block , linux-m68k , "openrisc@lists.librecores.org" , Borislav Petkov , Stafford Horne , Kalle Valo , Jens Axboe , Arnd Bergmann , John Johansen , Xinming Hu , Netdev , linux-wireless , Linux Kernel Mailing List , Vladimir Oltean , "linux-ntfs-dev@lists.sourceforge.net" , LSM List , Linux Crypto Mailing List , linuxppc-dev , Sharvari Harisangam Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, May 14, 2021 at 11:52 AM Vineet Gupta wrote: > > Wasn't the new zlib code slated for 5.14. I don't see it in your master yet You're right, I never actually committed it, since it was specific to ARC and -O3 and I wasn't entirely happy with the amount of testing it got (with Heiko pointing out that the s390 stuff needed more fixes for the change). So in fact it's not even queued up for 5.14 due to this all, I just dropped it. > > and the biggy > > case didn't even use "get_unaligned()"). > > Indeed this series is sort of orthogonal to that bug, but IMO that bug > still exists in 5.13 for -O3 build, granted that is not enabled for !ARC. Right, the zlib bug is still there. But Arnd's series wouldn't even fix it: right now inffast has its own - ugly and slow - special 2-byte-only version of "get_unaligned()", called "get_unaligned16()". And because it's ugly and slow, it's not actually used for CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS. Vineet - maybe the fix is to not take my patch to update to a newer zlib, but to just fix inffast to use the proper get_unaligned(). Then Arnd's series _would_ actually fix all this.. Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78C3DC433B4 for ; Fri, 14 May 2021 19:25:32 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F36BB61454 for ; Fri, 14 May 2021 19:25:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F36BB61454 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lMhvc8VockSK++L+ikVODshVKnaFI47QmmTsQZ3Cuv8=; b=HRlHa3eztAkuSH2jzfqEBPo4H haxE8ppGUMqY4LKb4PHAI/pL5WFCb1TzkAQjQCGfSWGHVfO2St63TLFBVRhc/rtdVobnHNhJlsqv+ SbJiMeuKxJ1szwHQUwyJbX5lx2wMrrievLQ7phrqia/BA0ex+sXcUabArA3BIUqLq3pDSgUdjphBC jW1e25cF7Rgv8cXFCqren/uKnF6L2G3kxaVXGfZY3XNwjrAa49ML6eDKVm9vtUBzj0bJ3klLG6to0 MpDdHasrL6zOSNaM/xcVkOi10u22+AkKkgrZgyWQbhYwaj6oFfoN+G6LDG77coB5tRG8vkjBjzAN7 Cv5tUUc+g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lhdP5-008n4f-8s; Fri, 14 May 2021 19:23:19 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lhdP1-008n4D-2g for linux-arm-kernel@desiato.infradead.org; Fri, 14 May 2021 19:23:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=l72hh61/tsn5KiliU7+ZN3a6OPF8Vv4B7h1Pke4bt3c=; b=DaUTspMmDP8hfEegaqZY5t9TMi 4SXfX30PMXYKknqbLQdYSDbhIX4fwOotSraIvISb0cwx3tQIizf+2mw2UNm/I8hLDxg1CZEG2qpf0 +H5UjHyyJnBi7c3B0pJhvsjqJqmauZ8L19nLj6HaQi9wXK0qArJjm9Wd52oC8d8YsyCExlfnnhdkn J2zQZ1DnRIAcWbpxuEAE+zsFifUSDhuyNFmC797tNB7oEtTqLTq9moAlY2TcMyfy7JPOlvSSMAvc4 0Siu9Yrvub5eszbREMA8EgyIvWTJgCDP3UxffOkRpL/dIfWnwNA0NjNQ/aka02J82xuZAcAETzW4K y5w7TQEw==; Received: from mail-lj1-x22a.google.com ([2a00:1450:4864:20::22a]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lhdOy-00CCZk-8y for linux-arm-kernel@lists.infradead.org; Fri, 14 May 2021 19:23:13 +0000 Received: by mail-lj1-x22a.google.com with SMTP id e11so25551393ljn.13 for ; Fri, 14 May 2021 12:23:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=l72hh61/tsn5KiliU7+ZN3a6OPF8Vv4B7h1Pke4bt3c=; b=aWXI51EnV/k9pge5GKaDOkkJQD5K/MYP7A5XMnLlSW2Sy2l/sTiI3B9cP8d8ZTB5m2 R3v2CKeD8i8Tb7rfnKNvLFWu6ekM3Dp1YyH8ufyfZgWCClPGJSZE/oeAn63KZeLaEQ45 fGizC1SmBVw+3SgkMIXS5j/6qsc7gTws56N4g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l72hh61/tsn5KiliU7+ZN3a6OPF8Vv4B7h1Pke4bt3c=; b=Oc9NI3bzmG6EN4MiEoeBd2d2vT+7preAMyLb1gpHSmEFILQcK4FIpdiYsXLVO1wxr9 VXZL+BKY3oWd7R1OB9zKv7uRxfK13y4xUw5hXMNvMAEFLKWIF3knY35S3/PVSSLxN0AL Zrzg8XtB6qQ6P6AaZjoubb9Zft4TMHa1zpDu0bnmjPzerj55kh+gBoeQz4mkG20p3BXo 1SeVxBSmSBjX6ZvNI/4fauXhKObCbuOIxlbeBY9xTkZl5H7MuBPhZpaFk4FxBQhrWkzJ Dq67QlN5zVrAZd76nVKGDODqmkm1bYyoq323umd4z8qfxeYRU+kzuSoSfbkFCscKtEW7 gWPA== X-Gm-Message-State: AOAM533aqp9Z8q74qvFTsR2H1LhwFAdxjLBkpSWbigk9RhAj6qj1QvJw 2Y8El61F3EEFJ/4lSNImtS/Mh4YiZyU1HS7GDrc= X-Google-Smtp-Source: ABdhPJxBfggJpmNKxob8O5Z4sU2CutZzKLN3jBjDWt2tBi/4ChS7YzVJJIrEXEcue3iuhQ3V18fXiQ== X-Received: by 2002:a2e:9b97:: with SMTP id z23mr38451909lji.359.1621020190310; Fri, 14 May 2021 12:23:10 -0700 (PDT) Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com. [209.85.208.172]) by smtp.gmail.com with ESMTPSA id m4sm1351740ljc.20.2021.05.14.12.23.08 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 May 2021 12:23:09 -0700 (PDT) Received: by mail-lj1-f172.google.com with SMTP id y9so39086810ljn.6 for ; Fri, 14 May 2021 12:23:08 -0700 (PDT) X-Received: by 2002:a05:651c:33a:: with SMTP id b26mr40099556ljp.220.1621020178319; Fri, 14 May 2021 12:22:58 -0700 (PDT) MIME-Version: 1.0 References: <20210514100106.3404011-1-arnd@kernel.org> <2408c893-4ae7-4f53-f58c-497c91f5b034@synopsys.com> In-Reply-To: <2408c893-4ae7-4f53-f58c-497c91f5b034@synopsys.com> From: Linus Torvalds Date: Fri, 14 May 2021 12:22:42 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 00/13] Unify asm/unaligned.h around struct helper To: Vineet Gupta Cc: Arnd Bergmann , linux-arch , Arnd Bergmann , Amitkumar Karwar , Benjamin Herrenschmidt , Borislav Petkov , Eric Dumazet , Florian Fainelli , Ganapathi Bhat , Geert Uytterhoeven , "H. Peter Anvin" , Ingo Molnar , Jakub Kicinski , James Morris , Jens Axboe , John Johansen , Jonas Bonn , Kalle Valo , Michael Ellerman , Paul Mackerras , Rich Felker , "Richard Russon (FlatCap)" , Russell King , "Serge E. Hallyn" , Sharvari Harisangam , Stafford Horne , Stefan Kristiansson , Thomas Gleixner , Vladimir Oltean , Xinming Hu , Yoshinori Sato , "the arch/x86 maintainers" , Linux Kernel Mailing List , Linux ARM , linux-m68k , Linux Crypto Mailing List , "openrisc@lists.librecores.org" , linuxppc-dev , Linux-sh list , linux-sparc , "linux-ntfs-dev@lists.sourceforge.net" , linux-block , linux-wireless , Netdev , LSM List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210514_122312_332718_4FB9B9BC X-CRM114-Status: GOOD ( 17.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 14, 2021 at 11:52 AM Vineet Gupta wrote: > > Wasn't the new zlib code slated for 5.14. I don't see it in your master yet You're right, I never actually committed it, since it was specific to ARC and -O3 and I wasn't entirely happy with the amount of testing it got (with Heiko pointing out that the s390 stuff needed more fixes for the change). So in fact it's not even queued up for 5.14 due to this all, I just dropped it. > > and the biggy > > case didn't even use "get_unaligned()"). > > Indeed this series is sort of orthogonal to that bug, but IMO that bug > still exists in 5.13 for -O3 build, granted that is not enabled for !ARC. Right, the zlib bug is still there. But Arnd's series wouldn't even fix it: right now inffast has its own - ugly and slow - special 2-byte-only version of "get_unaligned()", called "get_unaligned16()". And because it's ugly and slow, it's not actually used for CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS. Vineet - maybe the fix is to not take my patch to update to a newer zlib, but to just fix inffast to use the proper get_unaligned(). Then Arnd's series _would_ actually fix all this.. Linus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Date: Fri, 14 May 2021 12:22:42 -0700 Subject: [OpenRISC] [PATCH v2 00/13] Unify asm/unaligned.h around struct helper In-Reply-To: <2408c893-4ae7-4f53-f58c-497c91f5b034@synopsys.com> References: <20210514100106.3404011-1-arnd@kernel.org> <2408c893-4ae7-4f53-f58c-497c91f5b034@synopsys.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: openrisc@lists.librecores.org On Fri, May 14, 2021 at 11:52 AM Vineet Gupta wrote: > > Wasn't the new zlib code slated for 5.14. I don't see it in your master yet You're right, I never actually committed it, since it was specific to ARC and -O3 and I wasn't entirely happy with the amount of testing it got (with Heiko pointing out that the s390 stuff needed more fixes for the change). So in fact it's not even queued up for 5.14 due to this all, I just dropped it. > > and the biggy > > case didn't even use "get_unaligned()"). > > Indeed this series is sort of orthogonal to that bug, but IMO that bug > still exists in 5.13 for -O3 build, granted that is not enabled for !ARC. Right, the zlib bug is still there. But Arnd's series wouldn't even fix it: right now inffast has its own - ugly and slow - special 2-byte-only version of "get_unaligned()", called "get_unaligned16()". And because it's ugly and slow, it's not actually used for CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS. Vineet - maybe the fix is to not take my patch to update to a newer zlib, but to just fix inffast to use the proper get_unaligned(). Then Arnd's series _would_ actually fix all this.. Linus