From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC964C433EF for ; Mon, 4 Jul 2022 20:51:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232389AbiGDUvw (ORCPT ); Mon, 4 Jul 2022 16:51:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233573AbiGDUvs (ORCPT ); Mon, 4 Jul 2022 16:51:48 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D46B76371 for ; Mon, 4 Jul 2022 13:51:46 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id h23so18383902ejj.12 for ; Mon, 04 Jul 2022 13:51:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=D+7oxHi4Udb60oAybVQkpA6ge9KpdkDRHq2SyT5frGM=; b=WC8Na+ue7lqvNzcIq0d+w4TYUijqbI+F8XNMIDa46PZ8jUKAKSXH250R7Z1JnCea/0 dN2Yngk7PGEZtY/pHthqQmcylYXw5XH9Y6By6BDUbTg0gRZli/Lf9QMiBR2msDqWBWIe 3EDQ3hn2ffEhmMkzBdbguSGtcze3oKMYFRvO4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=D+7oxHi4Udb60oAybVQkpA6ge9KpdkDRHq2SyT5frGM=; b=4YpM7pe41G8opdg/TZwEuCX328TVx8cTFDcuLCtGSXnNBZFQ9e1qB45pITHN74uYR2 2nG+NPPuPGyzlZf8S2WsfZHwAsRodwDapYOgFc38K4xGjwiVm2vgsjREi7VrkbVdUKnb odqEEvGJ/V3IiNHQjkoQqUfas5Rr777wEOLGKFISekBDeRV0wP6ji2qNEkNF+ZuqgSd7 olwltkKwM+kZO6p0Aac54x2aukvyPKTXnL786J2xWku0HM2mSYeuzAExgC6md1awlBKl /g3s0RG93HTeliyn/qncxebIJUTdOkTlyAs9Fv8Hq3bOuCQ/pUENGR9AVD4PzePeTq7O 79Yw== X-Gm-Message-State: AJIora+I5S5eY6YF0iCNqYOGES2nWMvgQbh+KBnXCRfOEu6T9jv2LXJj W052HXoyxBuB7ZEeGwY68Fev2WeH7aPtxwyEOO4= X-Google-Smtp-Source: AGRyM1vFG5fMJX4K0sl6gqjvu8Z/h43c9a8rHXvYyu4MXEVn5YQnaOz5sx35H/Izk9K87zcI9WExlQ== X-Received: by 2002:a17:907:6d05:b0:726:a670:253 with SMTP id sa5-20020a1709076d0500b00726a6700253mr31367973ejc.23.1656967905255; Mon, 04 Jul 2022 13:51:45 -0700 (PDT) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com. [209.85.128.46]) by smtp.gmail.com with ESMTPSA id s27-20020a170906355b00b00702d8b37a03sm14730955eja.17.2022.07.04.13.51.43 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Jul 2022 13:51:44 -0700 (PDT) Received: by mail-wm1-f46.google.com with SMTP id t17-20020a1c7711000000b003a0434b0af7so6277844wmi.0 for ; Mon, 04 Jul 2022 13:51:43 -0700 (PDT) X-Received: by 2002:a05:600c:354e:b0:3a1:9ddf:468d with SMTP id i14-20020a05600c354e00b003a19ddf468dmr9623331wmq.145.1656967892746; Mon, 04 Jul 2022 13:51:32 -0700 (PDT) MIME-Version: 1.0 References: <20220701142310.2188015-1-glider@google.com> <20220701142310.2188015-44-glider@google.com> In-Reply-To: From: Linus Torvalds Date: Mon, 4 Jul 2022 13:51:16 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 43/45] namei: initialize parameters passed to step_into() To: Al Viro Cc: Alexander Potapenko , Alexei Starovoitov , Andrew Morton , Andrey Konovalov , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Christoph Hellwig , Christoph Lameter , David Rientjes , Dmitry Vyukov , Eric Dumazet , Greg Kroah-Hartman , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , Jens Axboe , Joonsoo Kim , Kees Cook , Marco Elver , Mark Rutland , Matthew Wilcox , "Michael S. Tsirkin" , Pekka Enberg , Peter Zijlstra , Petr Mladek , Steven Rostedt , Thomas Gleixner , Vasily Gorbik , Vegard Nossum , Vlastimil Babka , kasan-dev , Linux-MM , linux-arch , Linux Kernel Mailing List , Evgenii Stepanov , Nathan Chancellor , Nick Desaulniers , Segher Boessenkool , Vitaly Buka , linux-toolchains Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 4, 2022 at 1:46 PM Al Viro wrote: > > Why is that a problem? It could have been moved to another parent, > but so it could after we'd crossed to the mounted and we wouldn't have > noticed (or cared). Yeah, see my other email. I agree that it might be a "we don't actually care" situation, where all we care about that the name was valid at one point (when we picked up that sequence point). So maybe we don't care about closing it. But even if so, I think it might warrant a comment, because I still feel like we're basically "throwing away" our previous sequence point information without ever checking it. Maybe all we ever care about is basically "this sequence point protects the dentry inode pointer for the next lookup", and when it comes to mount points that ends up being immaterial. Linus