From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17CC0C433B4 for ; Fri, 14 May 2021 19:14:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E36CB6144B for ; Fri, 14 May 2021 19:14:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233428AbhENTPk (ORCPT ); Fri, 14 May 2021 15:15:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233067AbhENTPf (ORCPT ); Fri, 14 May 2021 15:15:35 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEE31C061756 for ; Fri, 14 May 2021 12:14:22 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id 131so13658298ljj.3 for ; Fri, 14 May 2021 12:14:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WHGE/SI1tO0CAdU9DspiMRu/IcggidAjeljmucgj+1U=; b=FHhNFP0HjOwmcUgJGOwZ/2fTGf6YloAj1IJt9cgCeCY5gct1ms0aePvfJ+p26Am9aT BgrkbekSovaMhMO5v4pdqS8eAlzBpMJLm9klgoPAMR35d4hkcz4CXmBtjJs+Fzkwi9i+ rg2vQHNDh6q1olgYalhfdAxn+xT9pYxV7ONgY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WHGE/SI1tO0CAdU9DspiMRu/IcggidAjeljmucgj+1U=; b=qQ2ljUWMKtYZMfcqTVaW9Flje5dHW+9fbPWCIdzHBYUFWT9U90nia5KYpPe4wNOUVj IRtBNCRS0wa9Uq4uog4q+D/lGtghxDfmNz3yyG6O84U0jzF+tDGmn6paB5NN1gL86FRF WmbFyePy82tDtUuBhVnNZBfbs7G5eEiA2rxcSWwPLUJJ5W0uJEvCPrk2sP41ViFc4yOB 0j7yEqSUV8lT/AXhu2EYBqXTzpQwA4l9+kdA71DSEwfRRPuDBTWx1o3xLVBcaKO+X6Vu +veen+sYkbxjYZOnyxhuM0RKYlLY92uFjd8Fx+AtkY5BRM0j5DcwvSE1kwxQ8lT0Dq5o FTBg== X-Gm-Message-State: AOAM5329TCs8HEeu69/kxivGv37Z732h/Kj9RRXM4DuEKHJUAgcHWiC6 wPPswBMZoDVS3IL3lLtk3wD3b1eX/Z3yLb5zrPE= X-Google-Smtp-Source: ABdhPJyf5NXvLu+cMdaz3vNntREFXdrB2A6zFq67poKkWXkqnZ0NkEVmW5+cnFZ/qWeOOQgYs8pLag== X-Received: by 2002:a2e:300f:: with SMTP id w15mr39508898ljw.162.1621019661131; Fri, 14 May 2021 12:14:21 -0700 (PDT) Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com. [209.85.208.175]) by smtp.gmail.com with ESMTPSA id f36sm899005lfv.248.2021.05.14.12.14.18 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 May 2021 12:14:19 -0700 (PDT) Received: by mail-lj1-f175.google.com with SMTP id w4so39080540ljw.9 for ; Fri, 14 May 2021 12:14:18 -0700 (PDT) X-Received: by 2002:a2e:22c4:: with SMTP id i187mr38227020lji.465.1621019658636; Fri, 14 May 2021 12:14:18 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Linus Torvalds Date: Fri, 14 May 2021 12:14:02 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] siginfo: ABI fixes for v5.13-rc2 To: "Eric W. Biederman" Cc: Arnd Bergmann , Florian Weimer , "David S. Miller" , Peter Zijlstra , Ingo Molnar , Thomas Gleixner , Peter Collingbourne , Dmitry Vyukov , Alexander Potapenko , sparclinux , linux-arch , Linux Kernel Mailing List , Linux API , kasan-dev , Marco Elver Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 13, 2021 at 9:55 PM Eric W. Biederman wrote: > > Please pull the for-v5.13-rc2 branch from the git tree: I really don't like this tree. The immediate cause for "no" is the silly #if IS_ENABLED(CONFIG_SPARC) and #if IS_ENABLED(CONFIG_ALPHA) code in kernel/signal.c. It has absolutely zero business being there, when those architectures have a perfectly fine arch/*/kernel/signal.c file where that code would make much more sense *WITHOUT* any odd preprocessor games. But there are other oddities too, like the new send_sig_fault_trapno(SIGFPE, si_code, (void __user *) regs->pc, 0, current); in the alpha code, which fundamentally seems bogus: using send_sig_fault_trapno() with a '0' for trapno seems entirely incorrect, since the *ONLY* point of that function is to set si_trapno to something non-zero. So it would seem that a plain send_sig_fault() without that 0 would be the right thing to do. This also mixes in a lot of other stuff than just the fixes. Which would have been ok during the merge window, but I'm definitely not happy about it now. Linus