From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51C4CC004C9 for ; Tue, 7 May 2019 16:51:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 23FD1205ED for ; Tue, 7 May 2019 16:51:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557247873; bh=GI2fY+pt9dQWs4C8MjePe2IQHiA+OLGeLUvd4saOJCo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=TP1fSUFL0oQQWOGSWKssxX65oHX7xGaXEb/xUpjSMgGoYE/iYxHQTxOHMpXJobzwi hVHXjNF5uTYY6siEBORzckShPRCl469Vb9h9blYtmOCv2ioGfR3bD49dA80Qb5qGUd i1RlVe7qPG36955bL3pYFm1scdqqK3A7aEEzOLYg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727150AbfEGQvM (ORCPT ); Tue, 7 May 2019 12:51:12 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:37032 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726527AbfEGQvL (ORCPT ); Tue, 7 May 2019 12:51:11 -0400 Received: by mail-lj1-f194.google.com with SMTP id 132so7227535ljj.4 for ; Tue, 07 May 2019 09:51:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JvOdwodHOTVYJ7+EHobDSJoXyA/2IRefA+hgBIaO+dI=; b=TR/Xs+H41+MJkfZoDS3QvaRnKQ/g/aV8B8CcLFu7NSmvalIZMpHgldvoVhvFAQWvJv 6nl9q4q1e1O09qZYjSX8DYPCKpQIHf0ugzOG6HjVOxJ3jM8B5tGB1rixMuYMwT8a5WVn OXpYD75kQFmL1W4AwtTiKcN+UF6bsE/Un6etg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JvOdwodHOTVYJ7+EHobDSJoXyA/2IRefA+hgBIaO+dI=; b=pVT+ZIunWFCUQCjWcGm+4zoNTuh5dVCVdVMG7PEuPTV8F6QrE49o1QVlzqA+6prO3B x5kMhRvfn9bjIpy5kXxTMoo5a/Di5cZxgscO3I3+lgGYgoFWDpKHzXX8qF0wdVoD10f1 LQ+lHxnalghS1VxiT1+uq6OOrIu6QQHzBdkbGJiItberC3nw+wvTuwmELnXBu7oh11oS aUauX+a6HxZvESP1xmap1MRGZ6+BgkmlmmX9QXZY8qXpRlZWWVD4Q3fQFCOgz+UgVQ1L Xksey52qjJs/STx6c4tElX6xN7hlMrMCxP75qYT8A3DlOe8UeujP4tLP6LH7J+3YjwBz w1Jg== X-Gm-Message-State: APjAAAWI3XEvw/XSxLZtP+RdUYXSD4VnNdtMQiJP1NRXEt6rpP2DTEp3 hnR5X1acdYedwj1FksmgpNYstfI1RbY= X-Google-Smtp-Source: APXvYqxJynm+grIKFTAef7gamu27mn8Td8vxIkFOWKydGrFwBoLc3u6S83geiXESKZNcNK6mtuX+3Q== X-Received: by 2002:a2e:93c7:: with SMTP id p7mr18380788ljh.32.1557247868770; Tue, 07 May 2019 09:51:08 -0700 (PDT) Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com. [209.85.208.171]) by smtp.gmail.com with ESMTPSA id k11sm3104339ljk.92.2019.05.07.09.51.07 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 May 2019 09:51:07 -0700 (PDT) Received: by mail-lj1-f171.google.com with SMTP id m20so5745359lji.2 for ; Tue, 07 May 2019 09:51:07 -0700 (PDT) X-Received: by 2002:a2e:801a:: with SMTP id j26mr8701955ljg.2.1557247866889; Tue, 07 May 2019 09:51:06 -0700 (PDT) MIME-Version: 1.0 References: <20190507053826.31622-1-sashal@kernel.org> <20190507053826.31622-62-sashal@kernel.org> In-Reply-To: From: Linus Torvalds Date: Tue, 7 May 2019 09:50:50 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH AUTOSEL 4.14 62/95] mm, memory_hotplug: initialize struct pages for the full memory section To: Alexander Duyck Cc: Sasha Levin , LKML , stable , Mikhail Zaslonko , Gerald Schaefer , Michal Hocko , Michal Hocko , Mikhail Gavrilov , Dave Hansen , Alexander Duyck , Pasha Tatashin , Martin Schwidefsky , Heiko Carstens , Andrew Morton , Sasha Levin , linux-mm Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 7, 2019 at 9:31 AM Alexander Duyck wrote: > > Wasn't this patch reverted in Linus's tree for causing a regression on > some platforms? If so I'm not sure we should pull this in as a > candidate for stable should we, or am I missing something? Good catch. It was reverted in commit 4aa9fc2a435a ("Revert "mm, memory_hotplug: initialize struct pages for the full memory section""). We ended up with efad4e475c31 ("mm, memory_hotplug: is_mem_section_removable do not pass the end of a zone") instead (and possibly others - this was just from looking for commit messages that mentioned that reverted commit). Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A67BC04AAD for ; Tue, 7 May 2019 16:59:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D6A6020656 for ; Tue, 7 May 2019 16:59:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="TR/Xs+H4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D6A6020656 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 78F496B0005; Tue, 7 May 2019 12:59:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 719AC6B000A; Tue, 7 May 2019 12:59:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5939B6B000C; Tue, 7 May 2019 12:59:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by kanga.kvack.org (Postfix) with ESMTP id E5B0D6B0005 for ; Tue, 7 May 2019 12:59:07 -0400 (EDT) Received: by mail-lj1-f200.google.com with SMTP id u14so2967988ljk.11 for ; Tue, 07 May 2019 09:59:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:mime-version:references :in-reply-to:from:date:message-id:subject:to:cc; bh=JvOdwodHOTVYJ7+EHobDSJoXyA/2IRefA+hgBIaO+dI=; b=UTg+m+2bkGYm8g+d9v5GRHUvQVOhDk4CzyyYx3w2gc/n93kC4mw9trAQqzJSrc0sfB NzwEnEwDTB5eguPm29pmAlRwq8yvvjLue0BkLilLGseve3z8rhgdmXMkaLPmQZLhodn4 xE4ag1gUh9MJTVXcDzRZe+wEoJSjedsj1vwg9pXLg90KPhjyEx33v77AJb/ZzAUmd4A/ rYdLa33DbpZ8Iy+0MHRyLcBJh/xioP2StJHk61c/9DLG4UuA8ZPs8kWGhz0FVHK+q43a sZrw3cv2u9iUG2w7EZEydokvqXuD8DkMox+i7169YOLGaoAXYv8u56AQsgP7CaiD8AIM rV0Q== X-Gm-Message-State: APjAAAWJwjJZWy1St17TJphHwbZJkHdQ5mCAIW9SbxrTpQXXm+aKJEvP Wh93G63BgX+oFE0Cn+6X34c6vkoidaWB4LXpO0p17LHWlZ4uCFZ2Nm22+IJ0HbXv+swD53GSgfI WWsBnMVkZ6o3ON+txw/6EdCMuTAZ8zRgYc3EJLoN9kt0YOrMF0DW5outpLkijtZ9zeg== X-Received: by 2002:a2e:9252:: with SMTP id v18mr8895400ljg.119.1557248347087; Tue, 07 May 2019 09:59:07 -0700 (PDT) X-Received: by 2002:a2e:9252:: with SMTP id v18mr8895368ljg.119.1557248346413; Tue, 07 May 2019 09:59:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557248346; cv=none; d=google.com; s=arc-20160816; b=XsUz/7K9LFpzCYpgfx2GcExg5YKilODIIlulXNTxSRgMN7LumJb7i38hWcbmqELhhl hiMB5bAHoF9BlspmM0gW0kmQA3eilZGy6fcQ7JUvTgWJ2iE8X3d7+ndHwn8BvQLX0Z4L WALcO8HPQWDTon7na31OfX+xXk0bYU+o/o5sRPeKQKsUjdBxqSHtQ4KBriplICOPzj0R r2afXaqplNchMD39D9tN9b1gmdiLSLdx0AtJvHbm69ns5MdALSK+58To7qN3JDSpPGVK Gh3aLPwIm4+mT6koJyYwdAzLIrw1zOPLWQdbmkBC36I/8rZlVJLJ8jzf+QPKHFL+oQ2i MvZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=JvOdwodHOTVYJ7+EHobDSJoXyA/2IRefA+hgBIaO+dI=; b=TU+k7a5Dkocym8ArhMSYl13QSKq8JpOhKaYxDNN95Fx7VEX1m6tel9ZPNNxaugAxz0 1DwdWfEPrsbWU6wwuuTk48IhwERESHqFugbTzONfdBS9DA2EqKq/Pdq9t4peDZ//3zis 4seI0yJMmtaeW3ivUOJtnIO7D9KiYokXyThGwQIjWNHfKIu4urGgA5jflBfPB+3OYaX5 vwwvI/WEbMBGEsZL0FasXfQFj/Tnb50qXL8MBVuyEZMZi1DIcyprbudLUd6UOpoCiuM+ 9zUOronL2BGsN77dWD5zcbwSe41XtBCCor2r/QgguYgHqJMIhYJhZEhC+iTmTrOVeFtx uu2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b="TR/Xs+H4"; spf=pass (google.com: domain of torvalds@linuxfoundation.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id t6sor7584271ljj.15.2019.05.07.09.59.06 for (Google Transport Security); Tue, 07 May 2019 09:59:06 -0700 (PDT) Received-SPF: pass (google.com: domain of torvalds@linuxfoundation.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b="TR/Xs+H4"; spf=pass (google.com: domain of torvalds@linuxfoundation.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JvOdwodHOTVYJ7+EHobDSJoXyA/2IRefA+hgBIaO+dI=; b=TR/Xs+H41+MJkfZoDS3QvaRnKQ/g/aV8B8CcLFu7NSmvalIZMpHgldvoVhvFAQWvJv 6nl9q4q1e1O09qZYjSX8DYPCKpQIHf0ugzOG6HjVOxJ3jM8B5tGB1rixMuYMwT8a5WVn OXpYD75kQFmL1W4AwtTiKcN+UF6bsE/Un6etg= X-Google-Smtp-Source: APXvYqwoDnpercsvpo8N+z2TWjEv2xnD16Frw62znMYs5XfsMewP7Ga7AQu6eCSLgbOQ0T5SwTphXQ== X-Received: by 2002:a2e:c41:: with SMTP id o1mr14175061ljd.23.1557248345578; Tue, 07 May 2019 09:59:05 -0700 (PDT) Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com. [209.85.208.178]) by smtp.gmail.com with ESMTPSA id r9sm158474ljb.79.2019.05.07.09.59.05 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 May 2019 09:59:05 -0700 (PDT) Received: by mail-lj1-f178.google.com with SMTP id d15so14984523ljc.7 for ; Tue, 07 May 2019 09:59:05 -0700 (PDT) X-Received: by 2002:a2e:801a:: with SMTP id j26mr8701955ljg.2.1557247866889; Tue, 07 May 2019 09:51:06 -0700 (PDT) MIME-Version: 1.0 References: <20190507053826.31622-1-sashal@kernel.org> <20190507053826.31622-62-sashal@kernel.org> In-Reply-To: From: Linus Torvalds Date: Tue, 7 May 2019 09:50:50 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH AUTOSEL 4.14 62/95] mm, memory_hotplug: initialize struct pages for the full memory section To: Alexander Duyck Cc: Sasha Levin , LKML , stable , Mikhail Zaslonko , Gerald Schaefer , Michal Hocko , Michal Hocko , Mikhail Gavrilov , Dave Hansen , Alexander Duyck , Pasha Tatashin , Martin Schwidefsky , Heiko Carstens , Andrew Morton , Sasha Levin , linux-mm Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 7, 2019 at 9:31 AM Alexander Duyck wrote: > > Wasn't this patch reverted in Linus's tree for causing a regression on > some platforms? If so I'm not sure we should pull this in as a > candidate for stable should we, or am I missing something? Good catch. It was reverted in commit 4aa9fc2a435a ("Revert "mm, memory_hotplug: initialize struct pages for the full memory section""). We ended up with efad4e475c31 ("mm, memory_hotplug: is_mem_section_removable do not pass the end of a zone") instead (and possibly others - this was just from looking for commit messages that mentioned that reverted commit). Linus