From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7187BC47092 for ; Wed, 2 Jun 2021 00:16:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 59282613BD for ; Wed, 2 Jun 2021 00:16:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229629AbhFBASM (ORCPT ); Tue, 1 Jun 2021 20:18:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229586AbhFBASK (ORCPT ); Tue, 1 Jun 2021 20:18:10 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52B60C061574 for ; Tue, 1 Jun 2021 17:16:27 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id f11so514048lfq.4 for ; Tue, 01 Jun 2021 17:16:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=78E6NeFKcH8MSEsBcY8Ia9gaTJw+NSrBe9gb2Q2dGXU=; b=KgV8JLk9OZeIr9xXubuaCOwIYB48/EcV0RA9tYYQILr3jxIqTQpsPYOs+sD4eJmsxk lk8YcXMZHBMNQrsqe7Bk4oH5L6NBC/0E8b5MToiLw6umt6moJbtqlrVAik3SlkR/4SLt bIqUM9GxeyML5v81eUzQTXLO/OWJA6oy7bzSA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=78E6NeFKcH8MSEsBcY8Ia9gaTJw+NSrBe9gb2Q2dGXU=; b=swdiHPXY6+5QEVJEZjJFpUqBZ2a2f3+5DdFN8CRRgsTqkqbqlPHeJ/0i/lj0O1uizm /lhjXW9Uw74rnxLehLu7/tCnqMY2hzjDkMDp5W0ZCrrkvlPzugkn38Tb+bPX8gAZ0bXL jytN/sMYEKlU2qrAc/MQP4nyz6pYXgVITJTAnEY56Y/ttfWvuX3hyBlRCG21YeCS/OF/ 9L5Up7QC3yIF1HelxddL2iUNzzLzcv16RtcBEZyVCMYgzDudeuYU8ZtibpQR+ygRdAm1 fdifofCTfpEtmagOykjFpwjloVfxiEVXTTpR5ynqLsORtyYOEy8IZcSpuuYwVPCUCtqB Ew3Q== X-Gm-Message-State: AOAM5334jvpET2Yw4YrRO0+Hc+wsLHDjXPOYpyfCFdiW+XfvhwCgc99+ q6Pp+Ervnp+hM3fPGKkdQg4ky0AWZIFMsZMSp0g= X-Google-Smtp-Source: ABdhPJxgXaD9f9GVWgpVUgf7y9aBRgwJQxMxGRe/Q7Ix7GycyAipQPhJodTnHyImoV6MaDsNrl/m4g== X-Received: by 2002:ac2:554d:: with SMTP id l13mr16138678lfk.228.1622592985495; Tue, 01 Jun 2021 17:16:25 -0700 (PDT) Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com. [209.85.208.173]) by smtp.gmail.com with ESMTPSA id n15sm1821220lft.169.2021.06.01.17.16.24 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jun 2021 17:16:24 -0700 (PDT) Received: by mail-lj1-f173.google.com with SMTP id 131so306552ljj.3 for ; Tue, 01 Jun 2021 17:16:24 -0700 (PDT) X-Received: by 2002:a05:651c:1311:: with SMTP id u17mr22578068lja.48.1622592983882; Tue, 01 Jun 2021 17:16:23 -0700 (PDT) MIME-Version: 1.0 References: <1622589753-9206-1-git-send-email-mlin@kernel.org> <1622589753-9206-3-git-send-email-mlin@kernel.org> In-Reply-To: <1622589753-9206-3-git-send-email-mlin@kernel.org> From: Linus Torvalds Date: Tue, 1 Jun 2021 14:16:08 -1000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/2] mm: adds NOSIGBUS extension for out-of-band shmem read To: Ming Lin Cc: Hugh Dickins , Simon Ser , Linux-MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This series passes my "looks fine, is simple and straightforward" test. One nit: On Tue, Jun 1, 2021 at 1:22 PM Ming Lin wrote: > > + error = vm_insert_page(vma, (unsigned long)vmf->address, > + ZERO_PAGE(0)); On architectures where this matters - bad virtual caches - it would be better to use ZERO_PAGE(vmf->address). It doesn't make a difference on any sane architecture, but it's the RightThing(tm) to do. Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 617ECC4708F for ; Wed, 2 Jun 2021 00:16:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CD5AE613B4 for ; Wed, 2 Jun 2021 00:16:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD5AE613B4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 63B4A6B006C; Tue, 1 Jun 2021 20:16:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5EB5B6B006E; Tue, 1 Jun 2021 20:16:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 465286B0070; Tue, 1 Jun 2021 20:16:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0002.hostedemail.com [216.40.44.2]) by kanga.kvack.org (Postfix) with ESMTP id 1646D6B006C for ; Tue, 1 Jun 2021 20:16:29 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 9A88A8249980 for ; Wed, 2 Jun 2021 00:16:28 +0000 (UTC) X-FDA: 78206867256.11.1816060 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by imf04.hostedemail.com (Postfix) with ESMTP id 61E9E42F for ; Wed, 2 Jun 2021 00:16:21 +0000 (UTC) Received: by mail-lf1-f53.google.com with SMTP id w33so494821lfu.7 for ; Tue, 01 Jun 2021 17:16:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=78E6NeFKcH8MSEsBcY8Ia9gaTJw+NSrBe9gb2Q2dGXU=; b=KgV8JLk9OZeIr9xXubuaCOwIYB48/EcV0RA9tYYQILr3jxIqTQpsPYOs+sD4eJmsxk lk8YcXMZHBMNQrsqe7Bk4oH5L6NBC/0E8b5MToiLw6umt6moJbtqlrVAik3SlkR/4SLt bIqUM9GxeyML5v81eUzQTXLO/OWJA6oy7bzSA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=78E6NeFKcH8MSEsBcY8Ia9gaTJw+NSrBe9gb2Q2dGXU=; b=QQrc9jzZZ6AuQWE6cQ6sYpn1GWeb8SVG1Cc69nerIC1aGxs9dZN77z1hlwclxb8NXe dFuaeyDUXNiTxFwl2Ob6mkb8LnJ9bTehuZShR78rs8LYxwjDGXQsPqsFePJP2sD875DY +TAbdOEIaGXhkNR3ZDQQk27FHi0UAGQh+bFg1MBRRrZfMfKxnkzfCHQhVZOUgPL8+wYY tT6DwRB/3wtp6C1lSgkui7PkrvBITdo1BE4+UyjUew+LQw0xYZVCzjjV8f6vlYIQ4UIu IJ9gjmDjBDsmMEVUmfSm6gQSWxDMv/KQDvCoxBljl89EnxqDgvMUPODkuddDiJ20oN1k 9prA== X-Gm-Message-State: AOAM532O0sX1M+Dh8cFp2NugmB8MurvWWSGzS3RXVphMqFqxe0wve6ry nGR1KDjOhX+amtpVq88xaNwDtO2i1asjVWwKZ7M= X-Google-Smtp-Source: ABdhPJxehOed7/VjdztNgcZJyNAj2ibpVFqzb/G1Lr1PvqUWGjBUISimzmtJvoy7Axn1KFB5bRlpaw== X-Received: by 2002:a05:6512:cc:: with SMTP id c12mr20567224lfp.155.1622592985165; Tue, 01 Jun 2021 17:16:25 -0700 (PDT) Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com. [209.85.208.176]) by smtp.gmail.com with ESMTPSA id d27sm1822166lfn.149.2021.06.01.17.16.24 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jun 2021 17:16:24 -0700 (PDT) Received: by mail-lj1-f176.google.com with SMTP id c11so291043ljd.6 for ; Tue, 01 Jun 2021 17:16:24 -0700 (PDT) X-Received: by 2002:a05:651c:1311:: with SMTP id u17mr22578068lja.48.1622592983882; Tue, 01 Jun 2021 17:16:23 -0700 (PDT) MIME-Version: 1.0 References: <1622589753-9206-1-git-send-email-mlin@kernel.org> <1622589753-9206-3-git-send-email-mlin@kernel.org> In-Reply-To: <1622589753-9206-3-git-send-email-mlin@kernel.org> From: Linus Torvalds Date: Tue, 1 Jun 2021 14:16:08 -1000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/2] mm: adds NOSIGBUS extension for out-of-band shmem read To: Ming Lin Cc: Hugh Dickins , Simon Ser , Linux-MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=KgV8JLk9; spf=pass (imf04.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.167.53 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 61E9E42F X-Stat-Signature: 4tymim4w7szbpkkst8uaunjxcxrdk8aj X-HE-Tag: 1622592981-748645 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This series passes my "looks fine, is simple and straightforward" test. One nit: On Tue, Jun 1, 2021 at 1:22 PM Ming Lin wrote: > > + error = vm_insert_page(vma, (unsigned long)vmf->address, > + ZERO_PAGE(0)); On architectures where this matters - bad virtual caches - it would be better to use ZERO_PAGE(vmf->address). It doesn't make a difference on any sane architecture, but it's the RightThing(tm) to do. Linus