From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB2CEC432BE for ; Tue, 24 Aug 2021 18:26:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C651F61371 for ; Tue, 24 Aug 2021 18:26:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233401AbhHXS1f (ORCPT ); Tue, 24 Aug 2021 14:27:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231220AbhHXS1d (ORCPT ); Tue, 24 Aug 2021 14:27:33 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22A31C061757 for ; Tue, 24 Aug 2021 11:26:49 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id r9so47475305lfn.3 for ; Tue, 24 Aug 2021 11:26:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Qmh74cK/fKKYlnQIEMxmE3fRPyy9EeyGsyNOi20k3fE=; b=AuYIqRWW5Gcs2BY+Yzc+3uSi8UFsEH0E9t26aJ0dmGyJqmYDtfj6HiP8QlQBFwPNaD 8C1tCdCACpYUF2UhKt+/W9chQfUpM2uKiQRD9nWlXkiuv5+1R5nSpj0kK4XsZMzHJqSg QKeP+49MEEsVl8cQ/juKRhOBxK3gTxq/V0btY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Qmh74cK/fKKYlnQIEMxmE3fRPyy9EeyGsyNOi20k3fE=; b=QWLN1j+wBsah1EmlNuf2KMsGpqtpQfT4baAUw8au6D45t9AIaBjZ9AeYX4afmG32Jg nUYbJ9RMWRqmjqko9DUdQ/dRcm67gC5ViFzPtMuE2Lzl9vB31s7TRvaur4bwHAuIjORp hR/niH1EgzBS5HyKaHRdi6k5TCJV8qB9v3m/LBXCqLlJ04cI2ZaPZnckmk9MI6D1xExu JK/35fGzlkFLTcTw6kW27w1KZQDGEM/DK76ud2YbbVIx+LFZXaNBzPIaXLDK+nvvAAIX TWXU9sjnDR8kc1qgKXGhV3JDnd94R/jrojHzX+GNEYECMUAJF1amH1KKHXP5KdgEqjHY qKVQ== X-Gm-Message-State: AOAM533wK1sBIOy/2C43y040JWl/baCDuEqEiXG3WLn7Knp8uZLNvs6B eC0Ag21w8dQzpW74SkL/JdCnrNHOJI3qy79+ X-Google-Smtp-Source: ABdhPJyIY35FbEaMiAa4LgFFqmav8iynor7XCcVUn4+mp9qbFF7tuuev/d3YTIursq0jmU4FSi8ZXQ== X-Received: by 2002:a19:c207:: with SMTP id l7mr16000730lfc.604.1629829607418; Tue, 24 Aug 2021 11:26:47 -0700 (PDT) Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com. [209.85.167.42]) by smtp.gmail.com with ESMTPSA id o6sm1820670lfu.98.2021.08.24.11.26.46 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Aug 2021 11:26:46 -0700 (PDT) Received: by mail-lf1-f42.google.com with SMTP id y34so47382579lfa.8 for ; Tue, 24 Aug 2021 11:26:46 -0700 (PDT) X-Received: by 2002:a05:6512:104b:: with SMTP id c11mr25943148lfb.201.1629829606492; Tue, 24 Aug 2021 11:26:46 -0700 (PDT) MIME-Version: 1.0 References: <1957060.1629820467@warthog.procyon.org.uk> In-Reply-To: From: Linus Torvalds Date: Tue, 24 Aug 2021 11:26:30 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] Memory folios for v5.15 To: Matthew Wilcox Cc: David Howells , Johannes Weiner , Linux-MM , linux-fsdevel , Linux Kernel Mailing List , Andrew Morton Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 24, 2021 at 11:17 AM Matthew Wilcox wrote: > > If the only thing standing between this patch and the merge is > s/folio/ream/g, I really don't think that helps. All the book-binding analogies are only confusing. If anything, I'd make things more explicit. Stupid and straightforward. Maybe just "struct head_page" or something like that. Name it by what it *is*, not by analogies. None of this cute/clever stuff. I think making it obvious and descriptive would be the much better approach, not some clever "book binders call a collection of pages XYZ". Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9645C4320A for ; Tue, 24 Aug 2021 18:26:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5414D613AD for ; Tue, 24 Aug 2021 18:26:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5414D613AD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id B24036B006C; Tue, 24 Aug 2021 14:26:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AAC1F8D0001; Tue, 24 Aug 2021 14:26:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94D0C6B0072; Tue, 24 Aug 2021 14:26:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0041.hostedemail.com [216.40.44.41]) by kanga.kvack.org (Postfix) with ESMTP id 7A88E6B006C for ; Tue, 24 Aug 2021 14:26:50 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 1209F1822D2AD for ; Tue, 24 Aug 2021 18:26:50 +0000 (UTC) X-FDA: 78510805380.01.7EF4942 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by imf13.hostedemail.com (Postfix) with ESMTP id C5B7110170C7 for ; Tue, 24 Aug 2021 18:26:49 +0000 (UTC) Received: by mail-lj1-f178.google.com with SMTP id s12so14041333ljg.0 for ; Tue, 24 Aug 2021 11:26:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Qmh74cK/fKKYlnQIEMxmE3fRPyy9EeyGsyNOi20k3fE=; b=AuYIqRWW5Gcs2BY+Yzc+3uSi8UFsEH0E9t26aJ0dmGyJqmYDtfj6HiP8QlQBFwPNaD 8C1tCdCACpYUF2UhKt+/W9chQfUpM2uKiQRD9nWlXkiuv5+1R5nSpj0kK4XsZMzHJqSg QKeP+49MEEsVl8cQ/juKRhOBxK3gTxq/V0btY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Qmh74cK/fKKYlnQIEMxmE3fRPyy9EeyGsyNOi20k3fE=; b=KuwpGIvC5rY8bSIh3D+2AdiBkPI5jz7ITT/DGcYnpNGzllUMdc5T+2aRTzcCheFIcC DfW2P+hJfJb2dzJ7gM1Ep+MDKqY3zXKAr+H/dEKx0nMp0B0J2yPAU+DOyGJF9Z9C/wYI BOw6gfk3PtPDz1Oz7otGgD1GLDS6A3kQbZVDh761rpPw8Z3pSjcWTNuITgn+UBnvLG3d PL+eHzSi4NkjpYPf2rnv0gjFeEwMPEZ0vUCmcn3BIUCBnYTAKJeZF6Szl0iObkpASqR6 J44IOqZt+eS8Ma/sJMk2ZWrnghLamMREMzgBA7BFssPjp1konXWPlvZTRiVU6fiMv9Vi yy0A== X-Gm-Message-State: AOAM532HmipRUgHbPIIMLWrhgkchH1849RXrV+WOzNur/TwGzLqBh1pX 6GBfr6XoZC20vp4xBMwl6KKUC2eqOK1KIAut X-Google-Smtp-Source: ABdhPJx7ANSclb2Y83qZviTHL1Ko0gZsBSdlomSBay0YCLg3IyMFWK0c8H1YPCPNnzrOx0vHVF2cDA== X-Received: by 2002:a2e:b7c8:: with SMTP id p8mr5194296ljo.32.1629829607977; Tue, 24 Aug 2021 11:26:47 -0700 (PDT) Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com. [209.85.167.50]) by smtp.gmail.com with ESMTPSA id m10sm1983835ljq.126.2021.08.24.11.26.46 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Aug 2021 11:26:47 -0700 (PDT) Received: by mail-lf1-f50.google.com with SMTP id i9so47391999lfg.10 for ; Tue, 24 Aug 2021 11:26:46 -0700 (PDT) X-Received: by 2002:a05:6512:104b:: with SMTP id c11mr25943148lfb.201.1629829606492; Tue, 24 Aug 2021 11:26:46 -0700 (PDT) MIME-Version: 1.0 References: <1957060.1629820467@warthog.procyon.org.uk> In-Reply-To: From: Linus Torvalds Date: Tue, 24 Aug 2021 11:26:30 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] Memory folios for v5.15 To: Matthew Wilcox Cc: David Howells , Johannes Weiner , Linux-MM , linux-fsdevel , Linux Kernel Mailing List , Andrew Morton Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=AuYIqRWW; spf=pass (imf13.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.178 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none X-Stat-Signature: fi6j9h4i63uiqoqpe1nwukwoccyjjr4j X-Rspamd-Queue-Id: C5B7110170C7 X-Rspamd-Server: rspam04 X-HE-Tag: 1629829609-349072 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 24, 2021 at 11:17 AM Matthew Wilcox wrote: > > If the only thing standing between this patch and the merge is > s/folio/ream/g, I really don't think that helps. All the book-binding analogies are only confusing. If anything, I'd make things more explicit. Stupid and straightforward. Maybe just "struct head_page" or something like that. Name it by what it *is*, not by analogies. None of this cute/clever stuff. I think making it obvious and descriptive would be the much better approach, not some clever "book binders call a collection of pages XYZ". Linus