From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71C53C433EF for ; Tue, 14 Sep 2021 20:48:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5A3E660F6F for ; Tue, 14 Sep 2021 20:48:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234643AbhINUt5 (ORCPT ); Tue, 14 Sep 2021 16:49:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234710AbhINUtx (ORCPT ); Tue, 14 Sep 2021 16:49:53 -0400 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3AF3CC061762 for ; Tue, 14 Sep 2021 13:48:35 -0700 (PDT) Received: by mail-lj1-x234.google.com with SMTP id p15so1109058ljn.3 for ; Tue, 14 Sep 2021 13:48:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0tzy5HhmdLCwbO3fFudYbI0KSBkL7KVwEu0UdmJ0Ygw=; b=XII/PyFYNJd9fcTfzjp8XzgGS94O/8zoi8sxLS1Q42YB1xBdgzGXT06zapqTx5n1Xo GONaGnMkVnx+vbpHjtcyEdqfbjQH0TUU+xVzULZKM7V4WuNyidewwKWl3iVik5363uMg 7qLMGQvrTMnNivZs1x2bRWqbcPWDPl9pcnslQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0tzy5HhmdLCwbO3fFudYbI0KSBkL7KVwEu0UdmJ0Ygw=; b=P8/sRdNkfIp/V8anAKDHCSm9txn/2dkPniVOfht3S6ASJOoMStLl6jfvcNN66kImi6 KhkkPminTViDv1lMYC3Sxi58HBkmIA7yItY1f9OqVWWsNCnWx9zrfR5kqC+qVwojhfQK UuDZxN7oE3yIAi+KxOpp1wBQvMU2nvbp6s0CZ9KRFZsqFscU3iBPt9uirwulhpLP3xRk jU9SiCzb0ToCx5HTyrVUbT3qsk7IxwQ7HFwUhQHptWArVxuNKgtefIWece/s1iN3sIvI sut89Hw7bclCGfmRqM8468GH7d04LQxeB9cSj2WCthGUdjBdVt/aYJi+VWdmk29pkA1U +wKA== X-Gm-Message-State: AOAM532l2yUYWHfmHI5VrXqQEH0Tz2ip/yLh7CJfeo8v51kGFwBd/QDH ZVax/pwero4PXb0jGQ1XfMpon87od4qR0QB1Dik= X-Google-Smtp-Source: ABdhPJxxY2NFP88fH2RMYcmrablfXfUeQcIpZ9m6VimldOlrqw09qzLZ7mruuMjQfUkwHqibWQO+Gw== X-Received: by 2002:a2e:4a19:: with SMTP id x25mr17062675lja.235.1631652513026; Tue, 14 Sep 2021 13:48:33 -0700 (PDT) Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com. [209.85.208.169]) by smtp.gmail.com with ESMTPSA id q189sm1410170ljb.68.2021.09.14.13.48.32 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Sep 2021 13:48:32 -0700 (PDT) Received: by mail-lj1-f169.google.com with SMTP id r3so1106912ljc.4 for ; Tue, 14 Sep 2021 13:48:32 -0700 (PDT) X-Received: by 2002:a2e:1542:: with SMTP id 2mr17497299ljv.249.1631652511805; Tue, 14 Sep 2021 13:48:31 -0700 (PDT) MIME-Version: 1.0 References: <20210914105620.677b90e5@oasis.local.home> <20210914145953.189f15dc@oasis.local.home> In-Reply-To: From: Linus Torvalds Date: Tue, 14 Sep 2021 13:48:15 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] tracing: Fixes to bootconfig memory management To: Steven Rostedt Cc: Mike Rapoport , Andrew Morton , LKML , Ingo Molnar , Masami Hiramatsu , Linux-MM , Vlastimil Babka Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 14, 2021 at 12:38 PM Linus Torvalds wrote: > > So I'll do a minimal conversion that adds "memblock_free_ptr()" and > hope that people start using that. And then we can later try to move > "memblock_free()" to a name that isn't so misleading. Commit 77e02cf57b6c ("memblock: introduce saner 'memblock_free_ptr()' interface") should hopefully fix that panic that Vlastimil saw, and the kernel test robot report as well. And it should make it easy to cleanly fix that 'copy' leak too. Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34474C433EF for ; Tue, 14 Sep 2021 20:48:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BB55860F6F for ; Tue, 14 Sep 2021 20:48:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BB55860F6F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id C9E5F6B006C; Tue, 14 Sep 2021 16:48:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C4E756B0072; Tue, 14 Sep 2021 16:48:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B3F806B0073; Tue, 14 Sep 2021 16:48:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0183.hostedemail.com [216.40.44.183]) by kanga.kvack.org (Postfix) with ESMTP id A14326B006C for ; Tue, 14 Sep 2021 16:48:35 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 5788D18126E6D for ; Tue, 14 Sep 2021 20:48:35 +0000 (UTC) X-FDA: 78587367390.20.CE0EAFA Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) by imf12.hostedemail.com (Postfix) with ESMTP id 0DBD110000AC for ; Tue, 14 Sep 2021 20:48:34 +0000 (UTC) Received: by mail-lj1-f182.google.com with SMTP id y6so1129679lje.2 for ; Tue, 14 Sep 2021 13:48:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0tzy5HhmdLCwbO3fFudYbI0KSBkL7KVwEu0UdmJ0Ygw=; b=XII/PyFYNJd9fcTfzjp8XzgGS94O/8zoi8sxLS1Q42YB1xBdgzGXT06zapqTx5n1Xo GONaGnMkVnx+vbpHjtcyEdqfbjQH0TUU+xVzULZKM7V4WuNyidewwKWl3iVik5363uMg 7qLMGQvrTMnNivZs1x2bRWqbcPWDPl9pcnslQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0tzy5HhmdLCwbO3fFudYbI0KSBkL7KVwEu0UdmJ0Ygw=; b=tP3938sPx/l2ifKh6P0zIOPJAw4veukN7L8ycNhgJVK9Z9mR1GEIkUbWyUJkyjERcK QbJ+o3oIxWO5PKIs19B7CDZbQ08Tw0xPyxNmbrCApr6xAJW7l7DamPqOituuX/HDF84E jWz8/trAGvrPIjyjoJI5Ir4GKrEjwnk9hRPIpu3wTUrpDwWkGz7cMsj10jrT9ffyjC4p 7a6PDpc5Lc23Ui6k8DlwSWgFiSOABYgV9uJADQXypYLv0fnVSKMc0lOG5qcpgue+OSKS nKKmdn8Mmo1y/+WyaWB2dxJHweUOClZWy/8goJLNZPlPb9ibJOfUk5ab7RuemlT4UYSk xegg== X-Gm-Message-State: AOAM532TapkYy5k1u1FLmtW5MUrL5Y/LJZlEuZiPQswTKirAi/zdad1i 48XGBsu77LggRaHyVBjKaIxV1NhWLQHW9OvhFq4= X-Google-Smtp-Source: ABdhPJyKt1I3SReUG+wVvVCJtnCQtLr+6PRZW9ACFl1WY33hwD3yDffaxwenROI/w96lI0j9TcGLAQ== X-Received: by 2002:a2e:9a97:: with SMTP id p23mr17067440lji.222.1631652512886; Tue, 14 Sep 2021 13:48:32 -0700 (PDT) Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com. [209.85.208.180]) by smtp.gmail.com with ESMTPSA id h4sm1212210lft.184.2021.09.14.13.48.32 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Sep 2021 13:48:32 -0700 (PDT) Received: by mail-lj1-f180.google.com with SMTP id w4so952332ljh.13 for ; Tue, 14 Sep 2021 13:48:32 -0700 (PDT) X-Received: by 2002:a2e:1542:: with SMTP id 2mr17497299ljv.249.1631652511805; Tue, 14 Sep 2021 13:48:31 -0700 (PDT) MIME-Version: 1.0 References: <20210914105620.677b90e5@oasis.local.home> <20210914145953.189f15dc@oasis.local.home> In-Reply-To: From: Linus Torvalds Date: Tue, 14 Sep 2021 13:48:15 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] tracing: Fixes to bootconfig memory management To: Steven Rostedt Cc: Mike Rapoport , Andrew Morton , LKML , Ingo Molnar , Masami Hiramatsu , Linux-MM , Vlastimil Babka Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b="XII/PyFY"; spf=pass (imf12.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.182 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 0DBD110000AC X-Stat-Signature: c9iob93ahpsrdtxqtp51cmddepwhacwf X-HE-Tag: 1631652514-653341 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 14, 2021 at 12:38 PM Linus Torvalds wrote: > > So I'll do a minimal conversion that adds "memblock_free_ptr()" and > hope that people start using that. And then we can later try to move > "memblock_free()" to a name that isn't so misleading. Commit 77e02cf57b6c ("memblock: introduce saner 'memblock_free_ptr()' interface") should hopefully fix that panic that Vlastimil saw, and the kernel test robot report as well. And it should make it easy to cleanly fix that 'copy' leak too. Linus