From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92F53C433F5 for ; Sun, 27 Mar 2022 22:32:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236941AbiC0Wdu (ORCPT ); Sun, 27 Mar 2022 18:33:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232147AbiC0Wdr (ORCPT ); Sun, 27 Mar 2022 18:33:47 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB20949C99 for ; Sun, 27 Mar 2022 15:32:07 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id h7so21829161lfl.2 for ; Sun, 27 Mar 2022 15:32:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yhspFAC09wnm+6Eh2TE7utcbggJMlqMOLI9aX60zVD8=; b=K7BQ2fnrxBITIiKXXqYXNEq1mjbFT/RDmtdUZ9GXVaKpGUTN+WKtKNSkpKXwCrAMJy 78dGOmuOG6vNftRvFPk4qDr4TxLtFm+TI/tQHnTeYhC9GLGkhiiFgovdb3NR/8RzMXdX Nl283+wES+W+ntTy8aPqUED24Da2xl0PWQET8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yhspFAC09wnm+6Eh2TE7utcbggJMlqMOLI9aX60zVD8=; b=XV4GXm8wfLJH4l3gsnD2t5dA55Xb+Q+kd9krLTn5ib0RTusL/zu67MS+QJhpUue15z 2uYsgQZr628hzJB35FORxa2buLB7kM4ne/pDLgt/BfZ6yo6kjHCQjrJQKiiRydSw3qzD nCZB+tu6eRwIaaEYv1CeNQ7cxd8Ri2hV+vKqcL2xSRoAv600x7B7xcrpC4f6YxHRnb9M JS0Jnq0FIjMmUA7UbN7UxUhxKS/vU3v+JIL5D+/YsoG9NQTgNhQ+mefZ43dpH+r6hjM2 1jf1LiTRAsTGLWTfieL+rAcqrgvUBZaHyFx53w9k/Yanaw4fypv5KIvekoIPDYo/7g0R RC6g== X-Gm-Message-State: AOAM530TZxPYBadrb3VpvU9W1qxCWa9U+x/gLegzImodK9/WXiKQAIAA L6tf4xEDjifcpziqlJKkCI6AheTfrpOZDj9IJB8= X-Google-Smtp-Source: ABdhPJyYNX4K9MG7e9q6U0u41gutXtlJbtDJz0OW2Yv6gbl6Ry1SkYdh7Noi8fd5swzMD9EC2+uHUA== X-Received: by 2002:ac2:4e0f:0:b0:44a:8577:1f63 with SMTP id e15-20020ac24e0f000000b0044a85771f63mr7399929lfr.554.1648420325971; Sun, 27 Mar 2022 15:32:05 -0700 (PDT) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com. [209.85.167.53]) by smtp.gmail.com with ESMTPSA id m12-20020a19434c000000b0044a23fdc8e6sm1459385lfj.217.2022.03.27.15.32.03 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Mar 2022 15:32:04 -0700 (PDT) Received: by mail-lf1-f53.google.com with SMTP id p10so15942827lfa.12 for ; Sun, 27 Mar 2022 15:32:03 -0700 (PDT) X-Received: by 2002:ac2:4f92:0:b0:448:7eab:c004 with SMTP id z18-20020ac24f92000000b004487eabc004mr17393349lfs.27.1648420323009; Sun, 27 Mar 2022 15:32:03 -0700 (PDT) MIME-Version: 1.0 References: <20220328090111.26f8980f@canb.auug.org.au> In-Reply-To: From: Linus Torvalds Date: Sun, 27 Mar 2022 15:31:46 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: linux-next: build failure in Linus' tree To: Stephen Rothwell Cc: Linux Kernel Mailing List , Linux Next Mailing List , Michael Ellerman , PowerPC Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org -#endif /* CONFIG_LIVEPATCH */ On Sun, Mar 27, 2022 at 3:23 PM Linus Torvalds wrote: > > I even *looked* at that code when merging, and convinced myself I had > gotten the #ifdef/#endif chain right. Apparently I can't count. > > What a maroon I am. Oh, and I see why I screwed up: I even did a "git diff" against the original powerpc tree, but then I visually matched -#define klp_get_ftrace_location klp_get_ftrace_location ... -#endif /* CONFIG_LIVEPATCH */ as a #ifdef/#endif pair. Now that I look at it knowing that I screwed up, I go "Duh!". Time to take my meds, Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89B19C433EF for ; Sun, 27 Mar 2022 22:32:54 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4KRVvm3zd2z3c4Q for ; Mon, 28 Mar 2022 09:32:52 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linux-foundation.org header.i=@linux-foundation.org header.a=rsa-sha256 header.s=google header.b=K7BQ2fnr; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linuxfoundation.org (client-ip=2a00:1450:4864:20::136; helo=mail-lf1-x136.google.com; envelope-from=torvalds@linuxfoundation.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linux-foundation.org header.i=@linux-foundation.org header.a=rsa-sha256 header.s=google header.b=K7BQ2fnr; dkim-atps=neutral Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KRVv01Wcjz2xBl for ; Mon, 28 Mar 2022 09:32:10 +1100 (AEDT) Received: by mail-lf1-x136.google.com with SMTP id bq24so5870238lfb.5 for ; Sun, 27 Mar 2022 15:32:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yhspFAC09wnm+6Eh2TE7utcbggJMlqMOLI9aX60zVD8=; b=K7BQ2fnrxBITIiKXXqYXNEq1mjbFT/RDmtdUZ9GXVaKpGUTN+WKtKNSkpKXwCrAMJy 78dGOmuOG6vNftRvFPk4qDr4TxLtFm+TI/tQHnTeYhC9GLGkhiiFgovdb3NR/8RzMXdX Nl283+wES+W+ntTy8aPqUED24Da2xl0PWQET8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yhspFAC09wnm+6Eh2TE7utcbggJMlqMOLI9aX60zVD8=; b=PbwLKW8ncFacG1bMXGC4mVwOr6Hr3ldylQHpskx9ZfBklHa/uvwwdikaWP8gT4LLx9 d1DfftKCvVwk0+0jrDhSb9Qlfy419JcfmXgEpROgs1xo5KlZzQaKkiiW7MftHd4nfTfO vpv/4Bw1GH9DkGrLG3Hq9p3FjZwLKjch1MDg4qKkU1g8TrIz2j/TMpMEM9MD5Ph6JDAY 1JPau1Kb4Q7AsBYP8t+zahvkHEpoWrHFZk5ZtuUFYwESknSa0F62bv9IeHEdhU5aXpKa odw3AfdiMWkFtQzX28gr8qnFJMR5ndVBbz252E8iLjFhBdYup+zBnB0tdRjnaZcVCZii re7Q== X-Gm-Message-State: AOAM533ZA1HxQdKOoSZBTOMtghsd7ZdDEXv8fk9F1SXgQLses5HJpft5 uA9JXDw25aOJY+C4S527f3MJLD2tB5yU9uKWjUc= X-Google-Smtp-Source: ABdhPJxlVhrvwV58C0w7tZy8dtUJjKCD/oEaNDfOKs+497JQQwSruwk8paSUfbFKDaODu7ukfQ2nFQ== X-Received: by 2002:ac2:4f8f:0:b0:448:5ddb:e52c with SMTP id z15-20020ac24f8f000000b004485ddbe52cmr16845810lfs.323.1648420325466; Sun, 27 Mar 2022 15:32:05 -0700 (PDT) Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com. [209.85.167.45]) by smtp.gmail.com with ESMTPSA id d13-20020a056512320d00b0044a34c95fc0sm1462978lfe.289.2022.03.27.15.32.03 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Mar 2022 15:32:04 -0700 (PDT) Received: by mail-lf1-f45.google.com with SMTP id 5so21827118lfp.1 for ; Sun, 27 Mar 2022 15:32:03 -0700 (PDT) X-Received: by 2002:ac2:4f92:0:b0:448:7eab:c004 with SMTP id z18-20020ac24f92000000b004487eabc004mr17393349lfs.27.1648420323009; Sun, 27 Mar 2022 15:32:03 -0700 (PDT) MIME-Version: 1.0 References: <20220328090111.26f8980f@canb.auug.org.au> In-Reply-To: From: Linus Torvalds Date: Sun, 27 Mar 2022 15:31:46 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: linux-next: build failure in Linus' tree To: Stephen Rothwell Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux Next Mailing List , PowerPC , Linux Kernel Mailing List Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" -#endif /* CONFIG_LIVEPATCH */ On Sun, Mar 27, 2022 at 3:23 PM Linus Torvalds wrote: > > I even *looked* at that code when merging, and convinced myself I had > gotten the #ifdef/#endif chain right. Apparently I can't count. > > What a maroon I am. Oh, and I see why I screwed up: I even did a "git diff" against the original powerpc tree, but then I visually matched -#define klp_get_ftrace_location klp_get_ftrace_location ... -#endif /* CONFIG_LIVEPATCH */ as a #ifdef/#endif pair. Now that I look at it knowing that I screwed up, I go "Duh!". Time to take my meds, Linus