All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	 Colin Ian King <colin.i.king@gmail.com>,
	Thorsten Leemhuis <regressions@leemhuis.info>,
	 Jakub Kicinski <kuba@kernel.org>, Kalle Valo <kvalo@kernel.org>,
	 Linux kernel regressions list <regressions@lists.linux.dev>
Subject: Re: One-off regression fix for 6.3 [was: Re: [PATCH] wifi: ath9k: Don't mark channelmap stack variable read-only in ath9k_mci_update_wlan_channels()]
Date: Thu, 20 Apr 2023 15:27:09 -0700	[thread overview]
Message-ID: <CAHk-=wis_qQy4oDNynNKi5b7Qhosmxtoj1jxo5wmB6SRUwQUBQ@mail.gmail.com> (raw)
In-Reply-To: <87zg72s1jz.fsf@toke.dk>

On Thu, Apr 20, 2023 at 2:09 PM Toke Høiland-Jørgensen <toke@toke.dk> wrote:
>
> So, with a bit of prodding from Thorsten, I'm writing this to ask you if
> you'd be willing to pull this patch directly from the mailing list as a
> one-off? It's a fairly small patch, and since it's a (partial) revert
> the risk of it being the cause of new regressions should be fairly
> small.

Sure. I'm always open to direct fixes when there is no controversy
about the fix. No problem. I still happily deal with individual
patches.

And yes, I do consider "regression in an earlier release" to be a
regression that needs fixing.

There's obviously a time limit: if that "regression in an earlier
release" was a year or more ago, and just took forever for people to
notice, and it had semantic changes that now mean that fixing the
regression could cause a _new_ regression, then that can cause me to
go "Oh, now the new semantics are what we have to live with".

But something like this, where the regression was in the previous
release and it's just a clear fix with no semantic subtlety, I
consider to be just a regular regression that should be expedited -
partly to make it into stable, and partly to avoid having to put the
fix into _another_ stable kernel..

             Linus

  reply	other threads:[~2023-04-20 22:27 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-13 21:41 [PATCH] wifi: ath9k: Don't mark channelmap stack variable read-only in ath9k_mci_update_wlan_channels() Toke Høiland-Jørgensen
2023-04-14 10:00 ` Kalle Valo
2023-04-14 10:32   ` Toke Høiland-Jørgensen
2023-04-14 12:38     ` Kalle Valo
2023-04-18 10:14       ` Toke Høiland-Jørgensen
2023-04-19  4:54         ` Kalle Valo
2023-04-20 13:50           ` Thorsten Leemhuis
2023-04-20 14:24             ` Toke Høiland-Jørgensen
2023-04-20 14:50               ` Jakub Kicinski
2023-04-20 15:56                 ` Toke Høiland-Jørgensen
2023-04-20 16:39                   ` Jakub Kicinski
2023-04-20 15:59                 ` Thorsten Leemhuis
2023-04-20 16:55                   ` Jakub Kicinski
2023-04-20 18:27                     ` Linux regression tracking (Thorsten Leemhuis)
2023-04-19 14:24 ` Kalle Valo
2023-04-19 15:18   ` Colin King (gmail)
2023-04-20 21:09 ` One-off regression fix for 6.3 [was: Re: [PATCH] wifi: ath9k: Don't mark channelmap stack variable read-only in ath9k_mci_update_wlan_channels()] Toke Høiland-Jørgensen
2023-04-20 22:27   ` Linus Torvalds [this message]
2023-04-20 22:38     ` Toke Høiland-Jørgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=wis_qQy4oDNynNKi5b7Qhosmxtoj1jxo5wmB6SRUwQUBQ@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=colin.i.king@gmail.com \
    --cc=kuba@kernel.org \
    --cc=kvalo@kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=regressions@leemhuis.info \
    --cc=regressions@lists.linux.dev \
    --cc=toke@toke.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.