From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FC0CC636C9 for ; Fri, 16 Jul 2021 01:23:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 01ACB613E7 for ; Fri, 16 Jul 2021 01:23:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231512AbhGPB0B (ORCPT ); Thu, 15 Jul 2021 21:26:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229603AbhGPB0A (ORCPT ); Thu, 15 Jul 2021 21:26:00 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39A8AC06175F for ; Thu, 15 Jul 2021 18:23:05 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id 22so13179472lfy.12 for ; Thu, 15 Jul 2021 18:23:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vwM1T+8Px0FLEGXWA6zrhkQm5HdM2ArGoJTAqP8zhhM=; b=bOAeC7egClGteDwWbqiswPawoH7i+SRUVeXxcWVXxnOr1WLw9CE+ulpGnPyaApeDGY eR71JMdMltJEdM+2w6XQA57uqchLFRO5ZDCxc/QhgxzPCBG2CI2DwtVIklatUWH5mVwm vYSZLhzWvie85hoxZnxnHeBhFgbWcSf51dBtM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vwM1T+8Px0FLEGXWA6zrhkQm5HdM2ArGoJTAqP8zhhM=; b=WipRtFUT8w4qR6bSqy4qoMhGKRerkrF3Si9g1iful2gOpof0JcWGXUkR5zSdhERWwJ bMBDKM76dkPmCOXr/lTdGJxNXmGw0Jcdlm2DyXZNV33xqusrB4L3qMA4sRM/T5ZPYu7p qePjY6kEPBVAKkw9uIQyJBYW33zS9O21WjN0C2XbsWDTxrHDhS8UHxMYQy4AZgJtmCMU 6cnOqYlajsyrUXrwVZl41Gff/KH+sudaE8AlCYcQn8yV3ejfS23iEQGw2Pk5Ypd8wSNf 67Y+GRJ3VDI+nUT7IcXpjIP/kwluhh8U/iCH2Bff5JNwQd1VW+pedmYUZJmoopxbT8Zz mPjw== X-Gm-Message-State: AOAM530sKBiOdl+AVY1cJ9CZF4SEWVlJMX2nH2gStUdFm7B27RWTiLHT CA5XeHijMKEZV2yCHLtiwAm6VFoGbTcy8c4A X-Google-Smtp-Source: ABdhPJytrCTJaKHVRJbRCgebxc4lohNFITgUpZ4e1H2aqLVh/qqu0SoiDVXQuJnM3SACRs0pjTXIoQ== X-Received: by 2002:ac2:58fc:: with SMTP id v28mr5531180lfo.651.1626398582454; Thu, 15 Jul 2021 18:23:02 -0700 (PDT) Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com. [209.85.167.41]) by smtp.gmail.com with ESMTPSA id h22sm796857ljk.133.2021.07.15.18.23.01 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Jul 2021 18:23:02 -0700 (PDT) Received: by mail-lf1-f41.google.com with SMTP id y42so13267851lfa.3 for ; Thu, 15 Jul 2021 18:23:01 -0700 (PDT) X-Received: by 2002:a05:6512:2347:: with SMTP id p7mr5671088lfu.253.1626398581772; Thu, 15 Jul 2021 18:23:01 -0700 (PDT) MIME-Version: 1.0 References: <20210714200523.GA10606@embeddedor> <5d170cc8-501d-0cec-bf03-2f53108a8486@embeddedor.com> In-Reply-To: <5d170cc8-501d-0cec-bf03-2f53108a8486@embeddedor.com> From: Linus Torvalds Date: Thu, 15 Jul 2021 18:22:45 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] fallthrough fixes for Clang for 5.14-rc2 To: "Gustavo A. R. Silva" Cc: "Gustavo A. R. Silva" , Nathan Chancellor , Nick Desaulniers , Kees Cook , Linux Kernel Mailing List , clang-built-linux Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 15, 2021 at 6:14 PM Gustavo A. R. Silva wrote: > > Kees just opened a bug report for this: > > https://bugs.llvm.org/show_bug.cgi?id=51094 I don't have an account on that bugzilla, but it might be worth adding the note that no warning or error should EVER not say where it happens. That's the thing that made me pissed off in the first place. I build my kernels with "make -j128", and if the warning doesn't specify the filename and the line number, the warning is just unacceptably bad. How can a compiler _ever_ give a warning without specifying where it is? The fact that the warning is also entirely wrong-headed in the first place is just the extra cherry on top. But at least it should hopefully make it easy to fix in clang - just remove the incredibly broken thing entirely. Linus