All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Jonathan Corbet" <corbet@lwn.net>,
	"Git List Mailing" <git@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
	"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
Subject: Re: [PATCH] Documentation: networking: device drivers: Remove stray asterisks
Date: Sun, 1 Dec 2019 06:28:06 -0800	[thread overview]
Message-ID: <CAHk-=wj9P8ukXOuTUnpkPNwc8B683Z0Za=-WxpLygMbjEtNxgA@mail.gmail.com> (raw)
In-Reply-To: <xmqqblss1rjp.fsf@gitster-ct.c.googlers.com>

On Sat, Nov 30, 2019 at 10:35 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> OK, so it appears that the tool is working as documented.

Well, yes and no.

I think it's a mistake that --no-keep-cr (which is the default) only
acts on the outer envelope.

Now, *originally* the outer envelope was all that existed so it makes
sense in a historical context of "CR removal happens when splitting
emails in an mbox". And that's the behavior we have.

But then git learnt to do MIME decoding and extracting things from
base64 etc, and the CR removal wasn't updated to that change.

I guess "documented" is arguable in the sense that the git
documentation does talk about "git-mailsplit" as an implementation
detail, but still..

             Linus

  reply	other threads:[~2019-12-01 14:28 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-01  1:03 Fw: [PATCH] Documentation: networking: device drivers: Remove stray asterisks Jonathan Corbet
2019-12-01  1:20 ` Linus Torvalds
2019-12-01  1:45   ` Jonathan Corbet
2019-12-01  6:35     ` Junio C Hamano
2019-12-01 14:28       ` Linus Torvalds [this message]
2019-12-01 15:27         ` Junio C Hamano
2019-12-02  9:50           ` Amit Choudhary
2019-12-02 14:22             ` Junio C Hamano
  -- strict thread matches above, loose matches on Subject: below --
2019-10-02 15:09 Jonathan Neuschäfer
2019-10-02 16:14 ` Shannon Nelson
2019-10-03  0:25 ` David Miller
2019-10-03 14:29   ` Jonathan Corbet
2019-10-09 22:48     ` Jakub Kicinski
2019-10-10 12:55       ` Jonathan Corbet
2019-10-03 16:47 ` Jonathan Corbet
2019-10-03 17:38   ` Jonathan Neuschäfer
2019-10-11  1:23 ` Brown, Aaron F

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=wj9P8ukXOuTUnpkPNwc8B683Z0Za=-WxpLygMbjEtNxgA@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=corbet@lwn.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=j.neuschaefer@gmx.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.