From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 011A0C49361 for ; Wed, 16 Jun 2021 14:34:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D84EB613B4 for ; Wed, 16 Jun 2021 14:34:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234030AbhFPOgo (ORCPT ); Wed, 16 Jun 2021 10:36:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234016AbhFPOgn (ORCPT ); Wed, 16 Jun 2021 10:36:43 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54BE5C061574 for ; Wed, 16 Jun 2021 07:34:36 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id k8so4131387lja.4 for ; Wed, 16 Jun 2021 07:34:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EzpE/PF3cfY1eLzFRA73FlZ1JqOIKKJoSDAttfp8rT8=; b=aEkpR08iY2BVSl2UA6eAtimz49p6r04XmXetfU00ZlbN8/LmIF3FBGRAx3kjX2HwCO C9n5VvNPXa4xruqBOIHjGZSAkFE5wKdNQ8ymaFQoEhHgC2dWyqwBrxUT3tUcDqjctR+l tUR2uAhqEhxYU+e1Wf/wCxiCpnkmXDBh1C2i8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EzpE/PF3cfY1eLzFRA73FlZ1JqOIKKJoSDAttfp8rT8=; b=RstA0nUyEvzT2Q/SCoO+qxH5yv1GD9/ZDTE+bXtIX7B3Mp7lb6/fxNq2MUiisjtjW8 B4aHv3WTVxfLp+2C52kEqPNaEFm7BVWzYq85kaa4OotdbSTDX1KQ+9xLVmCyDn9eBrB4 4Ft3rUKEltZUpnkrGw9kBgAsf5lss9ru87SxZ9f+KTpZssPyUj9fP+VIIIgZWf7A6QgY 7/1aCakMB4J8wn8dY0hoBlkctodrXZh6sBDOh+2z2DxUTAAs4ZNE8za8LnYIAqCJD3l2 EzvLu/TKMoFst81OMCRkIOQfPVE0EFPS6xJ5h13tkJnPJPEn6xNgj1lyMRQDFh9XkZYa ZwoA== X-Gm-Message-State: AOAM531LbCrSEnJ2h08Ct6CUcdvyoQCAqM1MX3iZc2JuSd0F7r1maQxp X5h/eRr5w9UKWYV6rZBi8DJaphv3e0j2+LwMvhA= X-Google-Smtp-Source: ABdhPJywRs0SA6SbrRjvZ8e/xCb5VQYPElBJa3q+6FRyJ9TJ8VBCt/gyvAhcAtztOXHqBPjcDVsJZQ== X-Received: by 2002:a2e:90f:: with SMTP id 15mr92597ljj.277.1623854074260; Wed, 16 Jun 2021 07:34:34 -0700 (PDT) Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com. [209.85.208.170]) by smtp.gmail.com with ESMTPSA id x17sm297820ljx.75.2021.06.16.07.34.33 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Jun 2021 07:34:33 -0700 (PDT) Received: by mail-lj1-f170.google.com with SMTP id d2so4116965ljj.11 for ; Wed, 16 Jun 2021 07:34:33 -0700 (PDT) X-Received: by 2002:a2e:9ad5:: with SMTP id p21mr138537ljj.220.1623854073071; Wed, 16 Jun 2021 07:34:33 -0700 (PDT) MIME-Version: 1.0 References: <162375813191.653958.11993495571264748407.stgit@warthog.procyon.org.uk> <051421e0-afe8-c6ca-95cd-4dc8cd20a43e@huawei.com> <200ea6f7-0182-9da1-734c-c49102663ccc@redhat.com> In-Reply-To: <200ea6f7-0182-9da1-734c-c49102663ccc@redhat.com> From: Linus Torvalds Date: Wed, 16 Jun 2021 07:34:16 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] afs: fix no return statement in function returning non-void To: Tom Rix Cc: Zheng Zengkai , Randy Dunlap , David Howells , Hulk Robot , linux-afs@lists.infradead.org, Marc Dionne , linux-fsdevel , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 16, 2021 at 5:56 AM Tom Rix wrote: > > A fix is to use the __noreturn attribute on this function That's certainly a better thing. It would be better yet to figure out why BUG() didn't do it automatically. Without CONFIG_BUG, it looks like powerpc picks up #ifndef HAVE_ARCH_BUG #define BUG() do {} while (1) which should still make it pointless to have the return. But I might have missed something. Linus