From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C886C433DB for ; Thu, 7 Jan 2021 17:50:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 194DE233FD for ; Thu, 7 Jan 2021 17:50:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728643AbhAGRuJ (ORCPT ); Thu, 7 Jan 2021 12:50:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725944AbhAGRuI (ORCPT ); Thu, 7 Jan 2021 12:50:08 -0500 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95276C0612F5 for ; Thu, 7 Jan 2021 09:48:31 -0800 (PST) Received: by mail-lf1-x136.google.com with SMTP id a12so16563189lfl.6 for ; Thu, 07 Jan 2021 09:48:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=V2vIDRi4w4FrROtR4uQE1WT5c/8OSWqME6TgOEaIYkk=; b=ayTvX31BvLuhk8m3fgGQmOSMsYpjQ54lgMyv8fbSEETOrmRwWzarzGX+vEjcHQSume YgWKMHLIGWJom0QE4ydgQzQRA5Fzav71GE87OAJlyce2ERGLaUyVCt51j7wVrDp1E1De dR1r+z0eZnbfoUzCpgqZ0fd0rk09yR0j30n5g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=V2vIDRi4w4FrROtR4uQE1WT5c/8OSWqME6TgOEaIYkk=; b=CIpFR9tfW+RjfsCmlWF+8tvBIcKcINoz555cR/UBj4JzZVUb2Ag62cSf/NCN1EJ/0m z2+ae0tSm8o8UFp/yu6XtH/csH56x0GlXoJK9C3KRKQMSLcacvwx12vBj/EGSlSCsdQh ChFiJ7u49X1YNT2yH7cMb0jLAFrWua6wi9hHiHYiX5w7rhC868T3ZaCkrgney6Z/NkV3 A2FZUKjj1hzG5zh9jwwnPH3fRXroVrVRn7AihJwH3BCK1SiFIhUf/PNMbmcx6o1+u1yg YW+cDC+ZjzTU3S6Er9MVf0S0H+8EWpLC9+qK1dWyupAi+yzGmmT6WnmU2FVFLIZpCZ1P kD0Q== X-Gm-Message-State: AOAM530UQFSTcBk9xT6MKcoaQ3Bbm+sX3Mehy6vaubdH7nIZDqv0ker0 p+C7zgYRbReaHC02PG9Jr9QGbButjM2z+g== X-Google-Smtp-Source: ABdhPJwNlY9D3jguwX2OoTef0v0AJ1cKv6M+4R1s6lmxrwuFqwJvWDEo5EYTzOgXDliwlg1Lp2jtQA== X-Received: by 2002:ac2:51ab:: with SMTP id f11mr4768801lfk.510.1610041709905; Thu, 07 Jan 2021 09:48:29 -0800 (PST) Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com. [209.85.167.45]) by smtp.gmail.com with ESMTPSA id s1sm1421382ljs.0.2021.01.07.09.48.28 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Jan 2021 09:48:29 -0800 (PST) Received: by mail-lf1-f45.google.com with SMTP id a12so16562996lfl.6 for ; Thu, 07 Jan 2021 09:48:28 -0800 (PST) X-Received: by 2002:a05:6512:3048:: with SMTP id b8mr4577806lfb.421.1610041708536; Thu, 07 Jan 2021 09:48:28 -0800 (PST) MIME-Version: 1.0 References: <20210107164400.17904-1-pmladek@suse.com> <20210107164400.17904-2-pmladek@suse.com> <20210107174638.GH4077@smile.fi.intel.com> In-Reply-To: <20210107174638.GH4077@smile.fi.intel.com> From: Linus Torvalds Date: Thu, 7 Jan 2021 09:48:12 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/1] Revert "init/console: Use ttynull as a fallback when there is no console" To: Andy Shevchenko Cc: Petr Mladek , Sergey Senozhatsky , Steven Rostedt , John Ogness , Guenter Roeck , Shreyas Joshi , shreyasjoshi15@gmail.com, Greg Kroah-Hartman , Sergey Senozhatsky , Greg Ungerer , Vineet Gupta , Thomas Meyer , David Gow , Brendan Higgins , Shuah Khan , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 7, 2021 at 9:45 AM Andy Shevchenko wrote: >> > Shouldn't it have Fixes tag along with Reported-by ones and explanation what > was the actual problem reported? No need for a "Fixes" tag for a revert - the commit it reverts _is_ the thing it fixes, so that's implicitly there. But yes, a reported-by with an explanation of the actual case that broke would be a very good idea, so that the revert documents the particular case that caused it, not just the "big picture" case. Linus