All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Manish Chopra <manishc@marvell.com>
Cc: Paul Menzel <pmenzel@molgen.mpg.de>,
	"kuba@kernel.org" <kuba@kernel.org>,
	 "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Ariel Elior <aelior@marvell.com>,
	 Alok Prasad <palok@marvell.com>,
	Prabhakar Kushwaha <pkushwaha@marvell.com>,
	 "David S. Miller" <davem@davemloft.net>,
	Greg KH <gregkh@linuxfoundation.org>,
	 "stable@vger.kernel.org" <stable@vger.kernel.org>,
	 "it+netdev@molgen.mpg.de" <it+netdev@molgen.mpg.de>,
	 "regressions@lists.linux.dev" <regressions@lists.linux.dev>
Subject: Re: [EXT] Re: [PATCH v2 net-next 1/2] bnx2x: Utilize firmware 7.13.21.0
Date: Wed, 9 Mar 2022 11:24:58 -0800	[thread overview]
Message-ID: <CAHk-=wjN22EeVLviARu=amf1+422U2iswCC6cz7cN8h+S9=-Jg@mail.gmail.com> (raw)
In-Reply-To: <BY3PR18MB4612BC158A048053BAC7A30EAB0A9@BY3PR18MB4612.namprd18.prod.outlook.com>

On Wed, Mar 9, 2022 at 11:22 AM Manish Chopra <manishc@marvell.com> wrote:
>
> This move was intentional, as follow up driver flow [bnx2x_compare_fw_ver()] needs to know which exact FW version (newer or older fw version which will be decided at run time now)
> the function is supposed to be run with in order to compare against already loaded FW on the adapter to decide on function probe/init failure (as opposed to earlier where driver was
> always stick to the one specific/fixed firmware version). So for that reason I chose the right place to invoke the bnx2x_init_firmware() during the probe early instead of later stage.

.. but since that fundamentally DOES NOT WORK, we'll clearly have to
revert that change.

Firmware loading cannot happen early in boot. End of story. You need
to delay firmware loading until the device is actually opened.

                                 Linus

  reply	other threads:[~2022-03-09 19:25 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-17 16:55 [PATCH v2 net-next 1/2] bnx2x: Utilize firmware 7.13.21.0 Manish Chopra
2021-12-17 16:55 ` [PATCH v2 net-next 2/2] bnx2x: Invalidate fastpath HSI version for VFs Manish Chopra
2022-03-09 16:15 ` [PATCH v2 net-next 1/2] bnx2x: Utilize firmware 7.13.21.0 Paul Menzel
2022-03-09 16:18   ` Paul Menzel
2022-03-09 16:35     ` Jakub Kicinski
2022-03-10 10:13     ` Thorsten Leemhuis
2022-03-11 13:09       ` [PATCH v2 net-next 1/2] bnx2x: Utilize firmware 7.13.21.0 #forregzbot Thorsten Leemhuis
2022-03-09 16:46   ` [EXT] Re: [PATCH v2 net-next 1/2] bnx2x: Utilize firmware 7.13.21.0 Manish Chopra
2022-03-09 18:00     ` Paul Menzel
2022-03-09 19:22       ` Manish Chopra
2022-03-09 19:24         ` Linus Torvalds [this message]
2022-03-09 19:46           ` Manish Chopra
2022-03-09 22:18             ` Linus Torvalds
2022-03-10 18:52               ` Jakub Kicinski
2022-03-10 19:14                 ` Ariel Elior
2022-03-10 19:42                   ` Jakub Kicinski
2022-03-11 12:11               ` Manish Chopra
2022-03-11 12:52                 ` Greg KH
2022-03-11 13:00                 ` Paul Menzel
2022-03-14 14:36                 ` Donald Buczek
2022-03-14 15:07                   ` Paul Menzel
2022-03-15  2:57                     ` Jakub Kicinski
2022-03-16 17:14                       ` Paul Menzel
2022-03-16 11:23                     ` Manish Chopra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=wjN22EeVLviARu=amf1+422U2iswCC6cz7cN8h+S9=-Jg@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=aelior@marvell.com \
    --cc=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=it+netdev@molgen.mpg.de \
    --cc=kuba@kernel.org \
    --cc=manishc@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=palok@marvell.com \
    --cc=pkushwaha@marvell.com \
    --cc=pmenzel@molgen.mpg.de \
    --cc=regressions@lists.linux.dev \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.